-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Style] Incorporate wemake-python-styleguide #253
Comments
If somebody wants to contribute, here's what to do:
|
Awesome news! Good to know that you find my project useful! π |
@sobolevn thanks for the kind offer! I think the only thing we need is more free time to fully implement the style. So we probably just need more PRs with adjustments. On the second thought, we should probably generate a flakehell baseline and add |
@sobolevn I tried following https://wemake-python-stylegui.de/en/latest/pages/usage/integrations/flakehell.html but none of Any pointers? |
Try [tool.flakehell]
baseline = ".flakehell_baseline" into It should work afterwards, if not - then it is a bug in |
@sobolevn that's the problem: |
@webknjaz can you please open a new bug report to |
@sobolevn I've discovered that it supports
|
So the above hinted be to look at configs and eventually I landed here: https://flakehell.readthedocs.io/config.html. Adding the example helped. So I guess it needs @sobolevn https://wemake-python-stylegui.de/en/latest/pages/usage/integrations/flakehell.html only offers to add something to |
@sobolevn oh and the default config seems to yell at |
@webknjaz thanks! Are you will to update our docs? I always welcome new contributors! π About |
Or you can even create a separate |
Sorry, I don't have time to contribute to the docs so I can't promise you that. I just wanted to flag it to you so you'd be aware of the problem. I'll keep exploring to see if I can fully integrate the style soon. One more question β should I always run |
@sobolevn I'm trying to use |
@sobolevn |
I hope to finish this task soon https://gitlab.com/pycqa/flake8/issues/602 I have many requests for legacy-first native integrations. |
This comment has been minimized.
This comment has been minimized.
@sobolevn any luck with that? |
Not yet, I will be working on it as a part of |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
life4/flakehell#40 (comment) -> time to look at |
β I'm submitting a ...
π Is your feature request related to a problem? Please describe.
The code style is not consistent across the project.
π£ Describe the solution you'd like
Integrate a set of very linters to keep the style in a good shape of .
First, we need to create a legacy style baseline as per https://wemake-python-stylegui.de/en/latest/pages/usage/integrations/legacy.html and then gradually eliminate linter offenses.
This would be a great first issue for beginners.
We may need to adjust a few rules along the way, though.
π Describe alternatives you've considered
N/A
π Additional context
See also: https://wemake-python-stylegui.de/en/latest/pages/usage/integrations/flakehell.html#flakehell
The text was updated successfully, but these errors were encountered: