Skip to content

Commit b9a1e28

Browse files
jaracowebknjaz
authored andcommitted
🧪 Stop using pytest-forked
This plugin is incompatible with Pytest 7+, it's difficult to fix upstream and there is no timeline for addressing that. The patch also bumps the top version boundary of Pytest to 7.2 due to the pinned `pytest-cov` raising warnings. Fixes ##502 Resolves #511 Closes #680 Resolves #681
1 parent ead1269 commit b9a1e28

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

cheroot/test/test_server.py

-9
Original file line numberDiff line numberDiff line change
@@ -400,15 +400,6 @@ def test_reuse_port(http_server, ip_addr, mocker):
400400
assert spy.spy_exception is None
401401

402402

403-
ISSUE511 = IS_MACOS
404-
405-
406-
if not IS_WINDOWS and not ISSUE511:
407-
test_high_number_of_file_descriptors = pytest.mark.forked(
408-
test_high_number_of_file_descriptors,
409-
)
410-
411-
412403
@pytest.fixture
413404
def _garbage_bin():
414405
"""Disable garbage collection when this fixture is in use."""

requirements/tests.in

+3-6
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,15 @@ pypytools
3434

3535
pytest-clarity
3636
pytest-cov==2.12.0
37-
pytest-forked>=1.2.0; sys_platform != "win32"
3837
pytest-mock>=1.11.0
3938
pytest-rerunfailures
4039
pytest-sugar>=0.9.3
4140
pytest-watch==4.2.0
4241
pytest-xdist>=1.28.0
4342

44-
# pytest-forked is currently incompatible with pytest 7
45-
# Refs:
46-
# * https://github.com/cherrypy/cheroot/issues/511
47-
# * https://github.com/pytest-dev/pytest-forked/issues/67
48-
pytest >= 4.6.6, < 7
43+
# pytest 7.2 introduces deprecations triggered by pytest-cov
44+
# * https://github.com/cherrypy/cheroot/issues/682
45+
pytest >= 7, <7.2
4946

5047
# HTTP over UNIX socket
5148
requests-unixsocket

0 commit comments

Comments
 (0)