Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the here() function out for the pyhere package #40

Open
chendaniely opened this issue Mar 20, 2023 · 2 comments
Open

Refactor the here() function out for the pyhere package #40

chendaniely opened this issue Mar 20, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@chendaniely
Copy link
Owner

Potentially port just the here() function to https://pypi.org/project/pyhere/

I suspect not much will change, but there have been a lot of changes to this package and we want to make it so that the downstream package maintainer has a good + easy time.

@chendaniely chendaniely added the good first issue Good for newcomers label Mar 20, 2023
@jamesmyatt
Copy link
Contributor

All of the here functionality should already be extracted into the pyprojroot.here module. The only issue is that from pyprojroot import here needs to be deprecated.

@chendaniely
Copy link
Owner Author

chendaniely commented Mar 23, 2023

This issue was mainly a placeholder for pyopensci submission to make the import + use as easy as possible for the end user.

it depends on how much we can get this implementation downstream.

There are 2 ways we can choose to import the here() function:

from pyprojroot.here import here

here()

or

# this requires some extra stuff into the __init__.py file
from pyprojroot import here

here()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants