Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'starting_dir' parameter #17

Open
majidaldo opened this issue Aug 22, 2020 · 0 comments · Fixed by #20
Open

add 'starting_dir' parameter #17

majidaldo opened this issue Aug 22, 2020 · 0 comments · Fixed by #20

Comments

@majidaldo
Copy link

majidaldo commented Aug 22, 2020

project_path = py_project_root(Path(".").cwd(), project_files)

There is a problem assuming cwd if this code gets used from outside the assumed project. It would be a user responsibility to provide something like __file__ as a starting dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant