Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation into other languages #8

Open
chelh opened this issue Mar 15, 2017 · 14 comments
Open

Translation into other languages #8

chelh opened this issue Mar 15, 2017 · 14 comments

Comments

@chelh
Copy link
Owner

chelh commented Mar 15, 2017

Are you able to translate VBA Sync into another language? If so, you can help the project by following these steps:

  1. Find VBA Sync's resources file in src/VBASync/Localization/VBASyncResources.resx
  2. Make a translated copy of it, either manually or using Zeta Resource Editor.
  3. Submit the new .resx to me, either via pull request or by posting it right here.

Translators will be given credit in LICENSE.txt and the project's GitHub page.

Thanks in advance!

@hectorticoli
Copy link

Okay, then here is the french translation. I think this could be improved using tests of the application in french (maybe better choice for accelerators, fixes on the translation depending on the context). I translated only from the Resource file, not the application, so I'll probably submit another version once the French Resource file is integrated.
Resources.FR.resx.txt

@chelh
Copy link
Owner Author

chelh commented Mar 20, 2017

Okay, I have your translation set up. Is my attribution in README.md correct, or do you have a different name you'd like to have credit under?

@hectorticoli
Copy link

Resources.FRv2.resx.txt A small fix for french translation. The text for "Macros: {OldFile}, {NewFile} seems different from what I wrote. I didn't check if you modified my file, so maybe there's a small bug with this.

Do you plan to integrate a multilanguage mechanism in some future version?

@chelh
Copy link
Owner Author

chelh commented Mar 20, 2017

{OldFile} and {NewFile} must remain untranslated, because they're macros – the code does a search and replace on them. I added a comment to the original resource file, so any future translators don't trip up over this.

For the moment the translation is entirely based on your Windows language setting, but I can add support for picking the language in the options menu and storing it in the session config file.

@chelh
Copy link
Owner Author

chelh commented Mar 21, 2017

In terms of a multi-language mechanism, how would you feel about being able to override the default language with a command-line switch?

@hectorticoli
Copy link

The best choice would be to be able to select the language from the GUI, that would let the user know what languages are available, but changing the language using a command line argument could be enough with a proper documentation (user would use a shortcut to start the application with the language they want).

I add a new v2 for the translation, that you can import in your repository, with the OldFile/NewFile not translated this time (slightly like what you did).
Resources.FRv2.resx.txt

I added my name in the resource file as a comment. Either the comment has no effect on the file, or you'll delete it, but you'll have the information for the ReadMe document.

@hectorticoli
Copy link

I noticed that some texts are not translated, like the state of the VBA modules and cie ("File modified (--)" for example). Maybe these are not included in the resource file?

@chelh
Copy link
Owner Author

chelh commented Mar 25, 2017

Okay, I've uploaded a new resources file with more localizable strings. Thanks!

@hectorticoli
Copy link

Here is an update for the french translation with all new items translated.
Enjoy
VBASyncResources.fr.resx.txt

@chelh
Copy link
Owner Author

chelh commented Apr 8, 2017

I've recently added an About window. @hectorticoli could you please translate the new strings in the resources file?

@hectorticoli
Copy link

hectorticoli commented Apr 8, 2017

Here is the updated version of resource file. Maybe I'll take some time soon to see how to participate directly to the Git repository ^^
VBASyncResources.fr.resx.txt

I was too lazy to test the latest version to have context for translation, so if you plan to build another RC, maybe I'll check the translation before the release (else, that would wait for 1.3.1 if necessary).

@hectorticoli
Copy link

Hello, here is the updated resource file, ready to go to 1.3.0.
VBASyncResources.fr.resx.txt

@chelh
Copy link
Owner Author

chelh commented May 8, 2017

@hectorticoli could you please check out the strings missing between the latest resources file and the French translation? I've added a few since your last translation update.

Here's an RC of the upcoming version, if it will help: Portable VBA Sync Tool 2.2.0.zip

@hectorticoli
Copy link

Hi chelh, here is the updated french resource file.
VBASyncResources.fr.resx.txt

About key "SWAddNewDocumentsToFile", my direct translation is closer to "Allow to publish new worksheets (expert option)". From my tests, that's what this option allows. I would recommend to disable this option by default, to avoid any file corruption, but I understand you enabled it to keep the same behavior. I just think this option might be dangerous for non expert users.

I didn't really understand the Hook-related options, so I just translated the best I could.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants