-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extractor: YML for list of projects #106
Comments
example of current files https://github.com/checkstyle/test-configs/tree/main/AbbreviationAsWordInName/Example1 Folder structure is: Now we have: list-of-projects.properties We should keep list-of-projects.properties as it is used by diff.yml (old workflow). Folder structure will be: diff.yml workflow will use list-of-projects.properties diff-java-tool will have a logic to load list of properties by extension, if CLI put *.property file it loads it as property file, if *.yml it loads it as yaml. regression-report.yml will download yml file and put yml file as argument value. |
Diff.groovy(corresponding java project) is updated to use YML format of list-of-projects.properties and Extractor is updated to work with list-of-projects.yaml
Discussion started at checkstyle/contribution#866
but we did not come to agreeement.
We have now very weird format of project list.
https://github.com/checkstyle/test-configs/blob/main/extractor/src/main/resources/all-projects.properties
It was quick and old decision. It was format for bash language, we deprecated this version a long time ago.
Let's do yaml format for it.
All long lists, should become elements of array in yaml.
Conceptually, we can use any other type that will allow us to make single line in existing format to be multiple lines that easily to manage.
Look at jdk lines to feel a pain of existing format.
existing:
#checkstyle|git|https://github.com/checkstyle/checkstyle.git|master|**/.ci-temp/**/*,**/resources-noncompilable/**/asttreestringprinter/**/*,**/resources-noncompilable/**/filefilters/**/*,**/resources-noncompilable/**/main/**/*,**/resources-noncompilable/**/suppressionsstringprinter/**/*,**/resources-noncompilable/**/gui/**/*,**/resources-noncompilable/**/javadocpropertiesgenerator/**/*,src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/javaparser/InputJavaParser.java,**/InputAllEscapedUnicodeCharacters.java,**/resources-noncompilable/**/javaparser/InputJavaParser.java,**/resources-noncompilable/**/checks/imports/unusedimports/InputUnusedImportsSingleWordPackage.java,**/resources-noncompilable/**/grammar/java19/*,**/resources-noncompilable/**/treewalker/**/*
proposed:
main reason of updaate is exclusion list, that is long, especially i jdk.
project that new workflow will use instead of diff.groovy, should allow yml config.
The text was updated successfully, but these errors were encountered: