Resolve deprecations warnings

[romani]

Deprecation highlighted by Sonarqube - https://sonarcloud.io/project/issues?id=checkstyle_sonar-checkstyle&resolved=false&rules=java%3AS1874&severities=MINOR

Deprecation usage that were highlighted by Eclipse:

The field RulePriority.BLOCKER is deprecated
The field RulePriority.CRITICAL is deprecated
The field RulePriority.INFO is deprecated
The field RulePriority.MAJOR is deprecated
The field RulePriority.MINOR is deprecated

The method find(RuleQuery) from the type RuleFinder is deprecated
The type RulePriority is deprecated
The type RuleFinder is deprecated
The type ResourcePerspectives is deprecated
The type Project is deprecated
The type BatchExtension is deprecated

The method debtSubCharacteristic() from the type RulesDefinition.Rule is deprecated
The method line(Integer) from the type Issuable.IssueBuilder is deprecated
The method message(String) from the type Issuable.IssueBuilder is deprecated
The method readFileToString(File) from the type FileUtils is deprecated
The method setParent(Rule) from the type Rule is deprecated

The method start(String) from the type TimeProfiler is deprecated
The method stop() from the type TimeProfiler is deprecated

The constructor Project(String) is deprecated
The constructor TimeProfiler() is deprecated

[romani]

@muhlba91 , can you recheck if this is still actual issue ?

[muhlba91]

RulePriority is deprecated but SQ still uses it and returns it in methods we need. Hence, we still rely on it until SQ replaces the return values in their API.

Rule.setParent(Rule) is deprecated -> fixable by replacing it with Rule.setTemplate(Rule)

Not used (anymore):

• ResourcePerspectives
• Project
• BatchExtension
• Issuable.IssueBuilder
• TimeProfiler
• RulesDefinition.Rule.debtSubCharacteristic()
• FileUtils.readFileToString(File) has been replaced by a non-deprecated method

ad RuleFinder:
it is marked as deprecated in SQ 6.7 but in later versions the deprecation gets removed since RuleFinder is kept for importer and exporter (on server side) and has been replaced by ActiveRules on scanner side - this fix has been made in #193.

[romani]

Please close this issue and create new issue on what is left to do.

Hence, we still rely on it until SQ replaces the return values in their API.

Does it make sense to open issue on sonar to get details on such deprecation ?

[romani]

@muhlba91 , as we migrated to new LTS, it is good time for cleanup of deprecations, and remove any adapters we did to keep compatibility with 6.7.

[muhlba91]

closing this in favour of #217 as it addresses sonarcloud.io issues.