Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Checkstyle version and fix Regression #88

Closed
rnveach opened this issue Nov 14, 2017 · 2 comments
Closed

Upgrade Checkstyle version and fix Regression #88

rnveach opened this issue Nov 14, 2017 · 2 comments
Labels

Comments

@rnveach
Copy link
Member

rnveach commented Nov 14, 2017

Based on CI run at #87 , Checkstyle has been modified too much that our regression isn't working anymore.

https://travis-ci.org/checkstyle/regression-tool/jobs/302059902

[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/travis/build/checkstyle/regression-tool/checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/ExtractInfoGeneratorTest.java:[34,48] cannot find symbol
symbol: class CheckUtil
location: package com.puppycrawl.tools.checkstyle.internal
[ERROR] /home/travis/build/checkstyle/regression-tool/checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/ExtractInfoGeneratorTest.java:[49,56] cannot find symbol
symbol: variable CheckUtil
location: class com.puppycrawl.tools.checkstyle.ExtractInfoGeneratorTest
[INFO] 2 errors

@rnveach rnveach added the bug label Nov 14, 2017
@rnveach
Copy link
Member Author

rnveach commented Nov 14, 2017

When I upgrade checkstyle version, I get the following test errors. I tried fixing them but then I get issues because of line endings that I can get around yet and I don't know why this is happening with the next version.

Failed tests: testGenerateConfigTextWithMiscModuleInfos(com.github.checkstyle.regression.configuration.ConfigGeneratorTest): Config is not as expected
testGenerateConfigTextWithCheckerParentModule(com.github.checkstyle.regression.configuration.ConfigGeneratorTest): Config is not as expected
testGenerateConfigTextWithEmptyModuleInfos(com.github.checkstyle.regression.configuration.ConfigGeneratorTest): Config is not as expected
testGenerateConfigTextWithTreeWalkerParentModule(com.github.checkstyle.regression.configuration.ConfigGeneratorTest): Config is not as expected

rnveach added a commit to rnveach/regression-tool that referenced this issue Nov 14, 2017
rnveach added a commit to rnveach/regression-tool that referenced this issue Nov 14, 2017
rnveach added a commit that referenced this issue Nov 14, 2017
@rnveach
Copy link
Member Author

rnveach commented Nov 14, 2017

Fix was merged

@rnveach rnveach closed this as completed Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant