Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: add line changes detection #77

Closed
Luolc opened this issue Aug 16, 2017 · 3 comments
Closed

git: add line changes detection #77

Luolc opened this issue Aug 16, 2017 · 3 comments

Comments

@Luolc
Copy link
Contributor

Luolc commented Aug 16, 2017 •
edited
Loading

We need to update GitChange. Add a field to store the line numbers of the changed code.
And update DiffParser to let it be able to detect line changes.
@Luolc Luolc changed the title git component: add line changes detection git: add line changes detection Aug 16, 2017
@rnveach
Copy link
Member

rnveach commented Aug 16, 2017 •
edited
Loading

the number of changed lines.

Why do we need the number of changed lines instead of the line numbers that changed?
We will need exact line numbers for things like Issue #69 .

Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 16, 2017
@Luolc
Issue checkstyle#77: git: add line changes detection
e988611
Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 16, 2017
@Luolc
Issue checkstyle#77: git: add line changes detection
c3f855a
Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 16, 2017
@Luolc
Issue checkstyle#77: git: add line changes detection
46bb0c4
@Luolc Luolc mentioned this issue Aug 16, 2017
Merged
@Luolc
Copy link
Contributor Author

Luolc commented Aug 16, 2017

Why do we need the number of changed lines instead of the line numbers that changed?

My expression was wrong. I updated the first post.

Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 16, 2017
@Luolc
Issue checkstyle#77: git: add line changes detection
27c7be8
Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 16, 2017
@Luolc
Issue checkstyle#77: git: add line changes detection
c9a72b4
Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 17, 2017
@Luolc
Issue checkstyle#77: git: add line changes detection
23657cf
Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 17, 2017
@Luolc
Issue checkstyle#77: git: add line changes detection
85401bc
rnveach pushed a commit that referenced this issue Aug 17, 2017
@Luolc @rnveach
Issue #77: git: add line changes detection
f92362c
@rnveach
Copy link
Member

rnveach commented Aug 17, 2017

Fix was merged

@rnveach rnveach closed this as completed Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rnveach @Luolc