From 39d0e71623b4abc0be4d7095abb58090ccd1107d Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Fri, 29 Sep 2023 19:46:19 +0200 Subject: [PATCH 01/12] infra: configure OpenRewrite This configures OpenRewrite so it can be run on our repository. There is no change to the normal build, the maven goal must be invoked explicitly (for instance via the new launch configuration). --- net.sf.eclipsecs.checkstyle/pom.xml | 2 + net.sf.eclipsecs.ui/pom.xml | 6 - pom.xml | 282 ++++++++++++++++++++++++++-- rewrite/OpenRewrite.launch | 25 +++ rewrite/rewrite.yml | 271 ++++++++++++++++++++++++++ 5 files changed, 560 insertions(+), 26 deletions(-) create mode 100644 rewrite/OpenRewrite.launch create mode 100644 rewrite/rewrite.yml diff --git a/net.sf.eclipsecs.checkstyle/pom.xml b/net.sf.eclipsecs.checkstyle/pom.xml index bafcbc91d..6fba02a53 100644 --- a/net.sf.eclipsecs.checkstyle/pom.xml +++ b/net.sf.eclipsecs.checkstyle/pom.xml @@ -17,9 +17,11 @@ maven-surefire-plugin + 3.5.2 maven-compiler-plugin + 3.13.0 diff --git a/net.sf.eclipsecs.ui/pom.xml b/net.sf.eclipsecs.ui/pom.xml index cde31dbf4..f39745154 100644 --- a/net.sf.eclipsecs.ui/pom.xml +++ b/net.sf.eclipsecs.ui/pom.xml @@ -15,12 +15,6 @@ org.eclipse.tycho tycho-source-plugin - - maven-surefire-plugin - - - maven-compiler-plugin - \ No newline at end of file diff --git a/pom.xml b/pom.xml index 24d713c89..4fcff1827 100644 --- a/pom.xml +++ b/pom.xml @@ -30,14 +30,12 @@ 3.1.0 3.6.0 3.4.0 - 3.13.0 3.1.3 3.5.0 3.5.2 3.1.3 3.3.1 3.21.0 - 3.5.2 3.9.0 4.0.10 2.18.0 @@ -392,30 +390,13 @@ true - - maven-surefire-plugin - ${maven-surefire-plugin-version} - - - maven-compiler-plugin - ${maven-compiler-plugin-version} - - - compiletests - test-compile - - testCompile - - - - org.apache.maven.plugins maven-enforcer-plugin ${maven-enforcer-plugin-version} - enforce-maven + enforce enforce @@ -537,7 +518,268 @@ versions-maven-plugin ${versions-maven-plugin-version} + + + org.openrewrite.maven + rewrite-maven-plugin + 6.0.4 + + + net.sf.eclipsecs.recipe + + + + + ${maven.multiModuleProjectDirectory}/rewrite/rewrite.yml + + **/target/** + **/bin/** + **/*.groovy + **/*.jar + **/*.properties + **/*.zip + + true + 1 + + + + org.openrewrite.recipe + rewrite-apache + 2.0.0 + + + org.openrewrite.recipe + rewrite-java-security + 3.0.0 + + + org.openrewrite.recipe + rewrite-migrate-java + 3.0.1 + + + org.openrewrite.recipe + rewrite-static-analysis + 2.0.2 + + + org.openrewrite.recipe + rewrite-testing-frameworks + 3.0.0 + + + + + + + rewrite + + + + org.codehaus.mojo + exec-maven-plugin + + + create-sevntu-patch + none + + + + + org.apache.maven.plugins + maven-antrun-plugin + + + calculate-website-timestamp + none + + + + + org.apache.maven.plugins + maven-checkstyle-plugin + + + checkstyle-check + none + + + sevntu-checkstyle-check + none + + + + + org.apache.maven.plugins + maven-enforcer-plugin + ${maven-enforcer-plugin-version} + + + enforce + none + + + + + org.apache.maven.plugins + maven-failsafe-plugin + + + default-verify + none + + + + + org.apache.maven.plugins + maven-resources-plugin + + + default-resources + none + + + default-testResources + none + + + docs + none + + + website + none + + + + + org.eclipse.tycho + tycho-compiler-plugin + + + compiletests + none + + + default-compile + none + + + default-testCompile + none + + + default-validate-classpath + none + + + + + org.eclipse.tycho + tycho-packaging-plugin + + + default-build-qualifier + none + + + default-build-qualifier-aggregator + none + + + default-package-feature + none + + + default-package-plugin + none + + + default-update-consumer-pom + none + + + default-validate-id + none + + + default-validate-version + none + + + + + org.eclipse.tycho + target-platform-configuration + + + default-target-platform + none + + + + + org.eclipse.tycho + tycho-p2-plugin + + + attach-p2-metadata + none + + + default-p2-metadata-default + none + + + + + org.eclipse.tycho + tycho-p2-repository-plugin + + + attach-p2-metadata + none + + + default-assemble-repository + none + + + default-archive-repository + none + + + + + org.eclipse.tycho + tycho-source-plugin + + + feature-source + none + + + plugin-source + none + + + + + org.eclipse.tycho + tycho-surefire-plugin + + + default-integration-test + none + + + + + + + diff --git a/rewrite/OpenRewrite.launch b/rewrite/OpenRewrite.launch new file mode 100644 index 000000000..5621a4bdb --- /dev/null +++ b/rewrite/OpenRewrite.launch @@ -0,0 +1,25 @@ + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/rewrite/rewrite.yml b/rewrite/rewrite.yml new file mode 100644 index 000000000..1975c0631 --- /dev/null +++ b/rewrite/rewrite.yml @@ -0,0 +1,271 @@ +--- +type: specs.openrewrite.org/v1beta/style +name: net.sf.eclipsecs.style +styleConfigs: + - org.openrewrite.java.style.ImportLayoutStyle: + classCountToUseStarImport: 999 + nameCountToUseStarImport: 999 + layout: + - import java.* + - + - import javax.* + - + - import org.* + - + - import com.* + - + - import all other imports + - + - import static all other imports + - org.openrewrite.java.style.TabsAndIndentsStyle: + useTabCharacter: false + tabSize: 2 + indentSize: 2 + continuationIndent: 2 + indentsRelativeToExpressionStart: false +--- +type: specs.openrewrite.org/v1beta/recipe +name: net.sf.eclipsecs.recipe +recipeList: + - org.openrewrite.java.format.EmptyNewlineAtEndOfFile + - org.openrewrite.java.format.NormalizeTabsOrSpaces + - org.openrewrite.java.format.PadEmptyForLoopComponents + - org.openrewrite.java.format.RemoveTrailingWhitespace +# - org.openrewrite.java.format.SingleLineComments, doesn't fit our copyright header comments + - org.openrewrite.java.format.TypecastParenPad + - org.openrewrite.apache.commons.codec.ApacheBase64ToJavaBase64 + - org.openrewrite.apache.commons.io.ApacheCommonsFileUtilsRecipes + - org.openrewrite.apache.commons.io.ApacheFileUtilsToJavaFiles + - org.openrewrite.apache.commons.io.ApacheIOUtilsUseExplicitCharset + - org.openrewrite.apache.commons.io.RelocateApacheCommonsIo + - org.openrewrite.apache.commons.io.UseStandardCharsets + - org.openrewrite.apache.commons.io.UseSystemLineSeparator + - org.openrewrite.apache.commons.lang.ApacheCommonsStringUtilsRecipes + - org.openrewrite.java.migrate.concurrent.JavaConcurrentAPIs + - org.openrewrite.java.migrate.io.ReplaceFileInOrOutputStreamFinalizeWithClose + - org.openrewrite.java.migrate.Java8toJava11 + - org.openrewrite.java.migrate.javax.AddInjectDependencies +# - org.openrewrite.java.migrate.javax.AddJaxbDependencies, unwanted +# - org.openrewrite.java.migrate.javax.AddJaxbRuntime, unwanted +# - org.openrewrite.java.migrate.javax.AddJaxwsDependencies, unwanted +# - org.openrewrite.java.migrate.javax.AddJaxwsRuntime, unwanted + - org.openrewrite.java.migrate.javax.AddScopeToInjectedClass + - org.openrewrite.java.migrate.javax.JavaxLangModelUtil + - org.openrewrite.java.migrate.javax.JavaxManagementMonitorAPIs + - org.openrewrite.java.migrate.javax.JavaxXmlStreamAPIs + - org.openrewrite.java.migrate.javax.MigrateAbstractAnnotationValueVisitor6To9 + - org.openrewrite.java.migrate.javax.MigrateAbstractElementVisitor6To9 + - org.openrewrite.java.migrate.javax.MigrateAbstractTypeVisitor6To9 + - org.openrewrite.java.migrate.javax.MigrateCounterMonitorSetThresholdToSetInitThreshold + - org.openrewrite.java.migrate.javax.MigrateElementKindVisitor6To9 + - org.openrewrite.java.migrate.javax.MigrateElementScanner6To9 + - org.openrewrite.java.migrate.javax.MigrateSimpleAnnotationValueVisitor6To9 + - org.openrewrite.java.migrate.javax.MigrateSimpleElementVisitor6To9 + - org.openrewrite.java.migrate.javax.MigrateSimpleTypeVisitor6To9 + - org.openrewrite.java.migrate.javax.MigrateTypeKindVisitor6To9 + - org.openrewrite.java.migrate.javax.MigrateXMLEventFactoryNewInstanceToNewFactory + - org.openrewrite.java.migrate.javax.MigrateXMLInputFactoryNewInstanceToNewFactory + - org.openrewrite.java.migrate.javax.MigrateXMLOutputFactoryNewInstanceToNewFactory + - org.openrewrite.java.migrate.lang.JavaLangAPIs + - org.openrewrite.java.migrate.lang.MigrateCharacterIsJavaLetterOrDigitToIsJavaIdentifierPart + - org.openrewrite.java.migrate.lang.MigrateCharacterIsJavaLetterToIsJavaIdentifierStart + - org.openrewrite.java.migrate.lang.MigrateCharacterIsSpaceToIsWhitespace + - org.openrewrite.java.migrate.lang.MigrateClassLoaderDefineClass + - org.openrewrite.java.migrate.lang.MigrateClassNewInstanceToGetDeclaredConstructorNewInstance + - org.openrewrite.java.migrate.lang.MigrateRuntimeVersionMajorToFeature + - org.openrewrite.java.migrate.lang.MigrateRuntimeVersionMinorToInterim + - org.openrewrite.java.migrate.lang.MigrateRuntimeVersionSecurityToUpdate + - org.openrewrite.java.migrate.lang.MigrateSecurityManagerMulticast +# - org.openrewrite.java.migrate.lang.StringFormatted, Java 17 + - org.openrewrite.java.migrate.lang.StringRulesRecipes + - org.openrewrite.java.migrate.lang.UseStringIsEmptyRecipe + - org.openrewrite.java.migrate.net.JavaNetAPIs + - org.openrewrite.java.migrate.net.MigrateHttpURLConnectionHttpServerErrorToHttpInternalError + - org.openrewrite.java.migrate.net.MigrateMulticastSocketGetTTLToGetTimeToLive + - org.openrewrite.java.migrate.net.MigrateMulticastSocketSetTTLToSetTimeToLive + - org.openrewrite.java.migrate.net.MigrateURLDecoderDecode + - org.openrewrite.java.migrate.net.MigrateURLEncoderEncode + - org.openrewrite.java.migrate.UseJavaUtilBase64 + - org.openrewrite.java.migrate.util.JavaUtilAPIs + - org.openrewrite.java.migrate.util.MigrateCollectionsSingletonList + - org.openrewrite.java.migrate.util.MigrateCollectionsSingletonMap + - org.openrewrite.java.migrate.util.MigrateCollectionsSingletonSet + - org.openrewrite.java.migrate.util.MigrateCollectionsUnmodifiableList + - org.openrewrite.java.migrate.util.MigrateCollectionsUnmodifiableSet + - org.openrewrite.java.migrate.util.OptionalNotEmptyToIsPresent + - org.openrewrite.java.migrate.util.OptionalNotPresentToIsEmpty + - org.openrewrite.java.migrate.util.RemoveFinalizerFromZip + - org.openrewrite.java.migrate.util.UseEnumSetOf + - org.openrewrite.java.migrate.util.UseLocaleOf + - org.openrewrite.java.migrate.util.UseMapOf + - org.openrewrite.java.security.FindTextDirectionChanges +# - org.openrewrite.java.security.JavaSecurityBestPractices, contains XmlParserXXEVulnerability with bug +# - org.openrewrite.java.security.OwaspTopTen, contains XmlParserXXEVulnerability with bug + - org.openrewrite.java.security.PartialPathTraversalVulnerability + - org.openrewrite.java.security.secrets.FindGitHubSecrets + - org.openrewrite.java.security.secrets.FindPasswordInUrlSecrets + - org.openrewrite.java.security.secrets.FindSshSecrets + - org.openrewrite.java.security.SecureTempFileCreation + - org.openrewrite.java.security.UseFilesCreateTempDirectory +# - org.openrewrite.java.security.XmlParserXXEVulnerability, doesn't recognize that we use a factory for the same + - org.openrewrite.java.security.ZipSlip + - org.openrewrite.java.ShortenFullyQualifiedTypeReferences +# - org.openrewrite.java.testing.assertj.Assertj, contains JUnitToAssertJ, which does unwanted changes + - org.openrewrite.java.testing.assertj.JUnitAssertArrayEqualsToAssertThat + - org.openrewrite.java.testing.assertj.JUnitAssertEqualsToAssertThat + - org.openrewrite.java.testing.assertj.JUnitAssertFalseToAssertThat + - org.openrewrite.java.testing.assertj.JUnitAssertNotEqualsToAssertThat + - org.openrewrite.java.testing.assertj.JUnitAssertNotNullToAssertThat + - org.openrewrite.java.testing.assertj.JUnitAssertNullToAssertThat + - org.openrewrite.java.testing.assertj.JUnitAssertSameToAssertThat + - org.openrewrite.java.testing.assertj.JUnitAssertThrowsToAssertExceptionType + - org.openrewrite.java.testing.assertj.JUnitAssertTrueToAssertThat + - org.openrewrite.java.testing.assertj.JUnitFailToAssertJFail +# - org.openrewrite.java.testing.assertj.JUnitToAssertj, adds POM dependencies unconditionally + - org.openrewrite.java.testing.assertj.SimplifyChainedAssertJAssertion + - org.openrewrite.java.testing.assertj.SimplifyChainedAssertJAssertions + - org.openrewrite.java.testing.assertj.StaticImports +# - org.openrewrite.java.testing.cleanup.BestPractices, contains TestsShouldIncludeAssertions + - org.openrewrite.java.testing.cleanup.RemoveTestPrefix +# - org.openrewrite.java.testing.cleanup.TestsShouldIncludeAssertions, unwanted as our assertion methods are not recognized + - org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic + - org.openrewrite.java.testing.junit5.LifecycleNonPrivate + - org.openrewrite.java.testing.junit5.TempDirNonFinal + - org.openrewrite.maven.cleanup.DependencyManagementDependencyRequiresVersion + - org.openrewrite.maven.RemoveDuplicateDependencies + - org.openrewrite.maven.RemoveRedundantDependencyVersions + - org.openrewrite.staticanalysis.AddSerialVersionUidToSerializable + - org.openrewrite.staticanalysis.AtomicPrimitiveEqualsUsesGet + - org.openrewrite.staticanalysis.AvoidBoxedBooleanExpressions + - org.openrewrite.staticanalysis.BigDecimalRoundingConstantsToEnums + - org.openrewrite.staticanalysis.BooleanChecksNotInverted + - org.openrewrite.staticanalysis.CaseInsensitiveComparisonsDoNotChangeCase + - org.openrewrite.staticanalysis.CatchClauseOnlyRethrows + - org.openrewrite.staticanalysis.ChainStringBuilderAppendCalls +# - org.openrewrite.staticanalysis.CodeCleanup, contains unwanted formatting recipe + - org.openrewrite.staticanalysis.CombineSemanticallyEqualCatchBlocks + - org.openrewrite.staticanalysis.CommonDeclarationSiteTypeVariances # needs manual cleanup +# - org.openrewrite.staticanalysis.CommonStaticAnalysis, contains FinalizePrivateFields with bug + - org.openrewrite.staticanalysis.CompareEnumsWithEqualityOperator + - org.openrewrite.staticanalysis.ControlFlowIndentation + - org.openrewrite.staticanalysis.CovariantEquals + - org.openrewrite.staticanalysis.DefaultComesLast + - org.openrewrite.staticanalysis.EmptyBlock + - org.openrewrite.staticanalysis.EqualsAvoidsNull + - org.openrewrite.staticanalysis.EqualsToContentEquals + - org.openrewrite.staticanalysis.ExplicitCharsetOnStringGetBytes + - org.openrewrite.staticanalysis.ExplicitInitialization + - org.openrewrite.staticanalysis.ExplicitLambdaArgumentTypes + - org.openrewrite.staticanalysis.ExternalizableHasNoArgsConstructor + - org.openrewrite.staticanalysis.FallThrough + - org.openrewrite.staticanalysis.FinalClass +# - org.openrewrite.staticanalysis.FinalizeLocalVariables, unwanted +# - org.openrewrite.staticanalysis.FinalizeMethodArguments, unwanted +# - org.openrewrite.staticanalysis.FinalizePrivateFields, TODO: needs naming changes + - org.openrewrite.staticanalysis.FixStringFormatExpressions + - org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators + - org.openrewrite.staticanalysis.ForLoopIncrementInUpdate + - org.openrewrite.staticanalysis.HiddenField + - org.openrewrite.staticanalysis.HideUtilityClassConstructor + - org.openrewrite.staticanalysis.IndexOfChecksShouldUseAStartPosition + - org.openrewrite.staticanalysis.IndexOfReplaceableByContains + - org.openrewrite.staticanalysis.IndexOfShouldNotCompareGreaterThanZero + - org.openrewrite.staticanalysis.InlineVariable +# - org.openrewrite.staticanalysis.InstanceOfPatternMatch, Java 17 + - org.openrewrite.staticanalysis.IsEmptyCallOnCollections + - org.openrewrite.staticanalysis.JavaApiBestPractices + - org.openrewrite.staticanalysis.LambdaBlockToExpression + - org.openrewrite.staticanalysis.LowercasePackage + - org.openrewrite.staticanalysis.MethodNameCasing + - org.openrewrite.staticanalysis.MinimumSwitchCases +# - org.openrewrite.staticanalysis.MissingOverrideAnnotation, https://github.com/openrewrite/rewrite-static-analysis/issues/178 + - org.openrewrite.staticanalysis.ModifierOrder + - org.openrewrite.staticanalysis.MultipleVariableDeclarations + - org.openrewrite.staticanalysis.NeedBraces + - org.openrewrite.staticanalysis.NestedEnumsAreNotStatic + - org.openrewrite.staticanalysis.NewStringBuilderBufferWithCharArgument + - org.openrewrite.staticanalysis.NoDoubleBraceInitialization + - org.openrewrite.staticanalysis.NoEmptyCollectionWithRawType + - org.openrewrite.staticanalysis.NoEqualityInForCondition +# - org.openrewrite.staticanalysis.NoFinalizedLocalVariables, unwanted + - org.openrewrite.staticanalysis.NoFinalizer + - org.openrewrite.staticanalysis.NoPrimitiveWrappersForToStringOrCompareTo + - org.openrewrite.staticanalysis.NoRedundantJumpStatements + - org.openrewrite.staticanalysis.NoToStringOnStringType + - org.openrewrite.staticanalysis.NoValueOfOnStringType + - org.openrewrite.staticanalysis.ObjectFinalizeCallsSuper + - org.openrewrite.staticanalysis.OperatorWrap + - org.openrewrite.staticanalysis.PrimitiveWrapperClassConstructorToValueOf + - org.openrewrite.staticanalysis.RedundantFileCreation +# - org.openrewrite.staticanalysis.ReferentialEqualityToObjectEquals, unwanted + - org.openrewrite.staticanalysis.RemoveCallsToObjectFinalize + - org.openrewrite.staticanalysis.RemoveCallsToSystemGc + - org.openrewrite.staticanalysis.RemoveEmptyJavaDocParameters + - org.openrewrite.staticanalysis.RemoveExtraSemicolons + - org.openrewrite.staticanalysis.RemoveHashCodeCallsFromArrayInstances +# - org.openrewrite.staticanalysis.RemoveInstanceOfPatternMatch, unwanted + - org.openrewrite.staticanalysis.RemoveJavaDocAuthorTag + - org.openrewrite.staticanalysis.RemoveRedundantTypeCast + - org.openrewrite.staticanalysis.RemoveSystemOutPrintln + - org.openrewrite.staticanalysis.RemoveToStringCallsFromArrayInstances + - org.openrewrite.staticanalysis.RemoveUnneededAssertion + - org.openrewrite.staticanalysis.RemoveUnneededBlock + - org.openrewrite.staticanalysis.RemoveUnusedLocalVariables + - org.openrewrite.staticanalysis.RemoveUnusedPrivateFields + - org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods + - org.openrewrite.staticanalysis.RenameExceptionInEmptyCatch + - org.openrewrite.staticanalysis.RenameLocalVariablesToCamelCase + - org.openrewrite.staticanalysis.RenameMethodsNamedHashcodeEqualOrToString + - org.openrewrite.staticanalysis.RenamePrivateFieldsToCamelCase + - org.openrewrite.staticanalysis.ReplaceApacheCommonsLang3ValidateNotNullWithObjectsRequireNonNull + - org.openrewrite.staticanalysis.ReplaceDeprecatedRuntimeExecMethods + - org.openrewrite.staticanalysis.ReplaceDuplicateStringLiterals + - org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference + - org.openrewrite.staticanalysis.ReplaceOptionalIsPresentWithIfPresent + - org.openrewrite.staticanalysis.ReplaceRedundantFormatWithPrintf + - org.openrewrite.staticanalysis.ReplaceStackWithDeque + - org.openrewrite.staticanalysis.ReplaceStreamToListWithCollect + - org.openrewrite.staticanalysis.ReplaceStringBuilderWithString + - org.openrewrite.staticanalysis.ReplaceTextBlockWithString + - org.openrewrite.staticanalysis.ReplaceThreadRunWithThreadStart + - org.openrewrite.staticanalysis.ReplaceValidateNotNullHavingSingleArgWithObjectsRequireNonNull + - org.openrewrite.staticanalysis.ReplaceValidateNotNullHavingVarargsWithObjectsRequireNonNull + - org.openrewrite.staticanalysis.ReplaceWeekYearWithYear + - org.openrewrite.staticanalysis.SimplifyBooleanExpression + - org.openrewrite.staticanalysis.SimplifyBooleanReturn + - org.openrewrite.staticanalysis.SimplifyCompoundStatement + - org.openrewrite.staticanalysis.SimplifyConsecutiveAssignments + - org.openrewrite.staticanalysis.SimplifyConstantIfBranchExecution + - org.openrewrite.staticanalysis.SimplifyDurationCreationUnits + - org.openrewrite.staticanalysis.SortedSetStreamToLinkedHashSet + - org.openrewrite.staticanalysis.StaticMethodNotFinal + - org.openrewrite.staticanalysis.StringLiteralEquality + - org.openrewrite.staticanalysis.TernaryOperatorsShouldNotBeNested + - org.openrewrite.staticanalysis.TypecastParenPad +# - org.openrewrite.staticanalysis.UnnecessaryCatch, bug + - org.openrewrite.staticanalysis.UnnecessaryCloseInTryWithResources + - org.openrewrite.staticanalysis.UnnecessaryExplicitTypeArguments + - org.openrewrite.staticanalysis.UnnecessaryParentheses + - org.openrewrite.staticanalysis.UnnecessaryPrimitiveAnnotations +# - org.openrewrite.staticanalysis.UnnecessaryThrows, bug + - org.openrewrite.staticanalysis.UnwrapRepeatableAnnotations + - org.openrewrite.staticanalysis.UpperCaseLiteralSuffixes +# - org.openrewrite.staticanalysis.UseAsBuilder, unwanted + - org.openrewrite.staticanalysis.UseCollectionInterfaces + - org.openrewrite.staticanalysis.UseDiamondOperator + - org.openrewrite.staticanalysis.UseForEachRemoveInsteadOfSetRemoveAll + - org.openrewrite.staticanalysis.UseJavaStyleArrayDeclarations + - org.openrewrite.staticanalysis.UseLambdaForFunctionalInterface + - org.openrewrite.staticanalysis.UseListSort + - org.openrewrite.staticanalysis.UseMapContainsKey + - org.openrewrite.staticanalysis.UseObjectNotifyAll + - org.openrewrite.staticanalysis.UseStandardCharset + - org.openrewrite.staticanalysis.UseStringReplace + - org.openrewrite.staticanalysis.UseSystemLineSeparator + - org.openrewrite.staticanalysis.WhileInsteadOfFor + - org.openrewrite.staticanalysis.WriteOctalValuesAsDecimal + - org.openrewrite.xml.RemoveTrailingWhitespace + - org.openrewrite.xml.security.AddOwaspDateBoundSuppressions + - org.openrewrite.xml.security.IsOwaspSuppressionsFile + - org.openrewrite.xml.security.RemoveOwaspSuppressions +# - org.openrewrite.xml.security.UpdateOwaspSuppressionDate, unwanted \ No newline at end of file From 16a66a474fac9fde46fc9ac8177475fb2ad836be Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 16:13:57 +0100 Subject: [PATCH 02/12] refactor: org.openrewrite.staticanalysis.RemoveJavaDocAuthorTag With modern version control system providing more details, the author tag is an anti-pattern, especially when we want to have team ownership of the code. All changes were created automatically. --- .../src/net/sf/eclipsecs/core/CheckstylePluginPrefs.java | 1 - .../src/net/sf/eclipsecs/core/Messages.java | 1 - .../src/net/sf/eclipsecs/core/builder/Auditor.java | 2 -- .../src/net/sf/eclipsecs/core/builder/CheckerFactory.java | 1 - .../net/sf/eclipsecs/core/builder/CheckstyleBuilder.java | 2 -- .../net/sf/eclipsecs/core/config/CheckConfiguration.java | 1 - .../sf/eclipsecs/core/config/CheckConfigurationTester.java | 2 -- .../core/config/CheckConfigurationWorkingCopy.java | 1 - .../eclipsecs/core/config/CheckstyleConfigurationFile.java | 1 - .../net/sf/eclipsecs/core/config/ConfigurationReader.java | 1 - .../net/sf/eclipsecs/core/config/ConfigurationWriter.java | 1 - .../core/config/GlobalCheckConfigurationWorkingSet.java | 1 - .../net/sf/eclipsecs/core/config/ICheckConfiguration.java | 1 - .../core/config/ICheckConfigurationWorkingSet.java | 1 - .../src/net/sf/eclipsecs/core/config/Module.java | 1 - .../net/sf/eclipsecs/core/config/ResolvableProperty.java | 2 -- .../src/net/sf/eclipsecs/core/config/Severity.java | 1 - .../core/config/configtypes/BuiltInConfigurationType.java | 1 - .../config/configtypes/BuiltInFilePropertyResolver.java | 1 - .../core/config/configtypes/ClasspathVariableResolver.java | 1 - .../core/config/configtypes/ConfigurationType.java | 1 - .../core/config/configtypes/ConfigurationTypes.java | 1 - .../config/configtypes/ExternalFileConfigurationType.java | 1 - .../core/config/configtypes/IConfigurationType.java | 1 - .../eclipsecs/core/config/configtypes/IContextAware.java | 1 - .../core/config/configtypes/InternalConfigurationType.java | 1 - .../core/config/configtypes/MultiPropertyResolver.java | 1 - .../core/config/configtypes/ProjectConfigurationType.java | 1 - .../sf/eclipsecs/core/config/configtypes/PropertyUtil.java | 1 - .../core/config/configtypes/RemoteConfigurationType.java | 2 -- .../config/configtypes/ResolvablePropertyResolver.java | 1 - .../config/configtypes/ResourceBundlePropertyResolver.java | 1 - .../core/config/configtypes/StandardPropertyResolver.java | 1 - .../core/config/configtypes/SystemPropertyResolver.java | 1 - .../sf/eclipsecs/core/config/meta/AllTokensProvider.java | 1 - .../net/sf/eclipsecs/core/config/meta/IOptionProvider.java | 1 - .../net/sf/eclipsecs/core/config/meta/MetadataFactory.java | 1 - .../core/config/savefilter/CheckerModuleSaveFilter.java | 1 - .../sf/eclipsecs/core/config/savefilter/ISaveFilter.java | 1 - .../sf/eclipsecs/core/config/savefilter/SaveFilters.java | 1 - .../core/config/savefilter/SortingSaveFilter.java | 2 -- .../savefilter/SuppressWarningsHolderSaveFilter.java | 1 - .../core/config/savefilter/TreeWalkerModuleSaveFilter.java | 1 - .../src/net/sf/eclipsecs/core/jobs/AuditorJob.java | 1 - .../src/net/sf/eclipsecs/core/jobs/BuildProjectJob.java | 1 - .../eclipsecs/core/jobs/ConfigureDeconfigureNatureJob.java | 1 - .../sf/eclipsecs/core/jobs/RunCheckstyleOnFilesJob.java | 1 - .../eclipsecs/core/jobs/TransformCheckstyleRulesJob.java | 1 - .../sf/eclipsecs/core/jobs/TransformFormatterRulesJob.java | 1 - .../core/projectconfig/IProjectConfiguration.java | 1 - .../projectconfig/LocalCheckConfigurationWorkingSet.java | 1 - .../net/sf/eclipsecs/core/projectconfig/PluginFilters.java | 1 - .../eclipsecs/core/projectconfig/ProjectConfiguration.java | 1 - .../projectconfig/ProjectConfigurationWorkingCopy.java | 1 - .../core/projectconfig/filters/AbstractFilter.java | 1 - .../core/projectconfig/filters/DerivedFilesFilter.java | 1 - .../core/projectconfig/filters/FilesInSyncFilter.java | 1 - .../sf/eclipsecs/core/projectconfig/filters/IFilter.java | 1 - .../core/projectconfig/filters/NonSrcDirsFilter.java | 1 - .../core/projectconfig/filters/PackageFilter.java | 1 - .../core/projectconfig/filters/UnOpenedFilesFilter.java | 1 - .../core/projectconfig/filters/WriteProtectedFilter.java | 1 - .../eclipsecs/core/transformer/CTransformationClass.java | 1 - .../eclipsecs/core/transformer/CheckstyleFileWriter.java | 1 - .../sf/eclipsecs/core/transformer/CheckstyleSetting.java | 1 - .../eclipsecs/core/transformer/CheckstyleTransformer.java | 1 - .../eclipsecs/core/transformer/FTransformationClass.java | 1 - .../eclipsecs/core/transformer/FormatterConfigParser.java | 1 - .../eclipsecs/core/transformer/FormatterConfigWriter.java | 3 --- .../eclipsecs/core/transformer/FormatterConfiguration.java | 1 - .../eclipsecs/core/transformer/FormatterTransformer.java | 1 - .../sf/eclipsecs/core/transformer/XmlProfileWriter.java | 1 - .../ctransformerclasses/AvoidStarImportTransformer.java | 1 - .../ctransformerclasses/FileTabCharacterTransformer.java | 1 - .../ctransformerclasses/FinalLocalVariableTransformer.java | 1 - .../ctransformerclasses/FinalParametersTransformer.java | 1 - .../ctransformerclasses/GenericWhitespaceTransformer.java | 1 - .../ctransformerclasses/IndentationTransformer.java | 1 - .../ctransformerclasses/LeftCurlyTransformer.java | 1 - .../ctransformerclasses/LineLengthTransformer.java | 1 - .../ctransformerclasses/MethodParamPadTransformer.java | 1 - .../ctransformerclasses/MissingDeprecatedTransformer.java | 1 - .../ctransformerclasses/MissingOverrideTransformer.java | 1 - .../ctransformerclasses/NeedBracesTransformer.java | 1 - .../ctransformerclasses/NewlineAtEndOfFileTransformer.java | 1 - .../ctransformerclasses/NoWhitespaceAfterTransformer.java | 1 - .../ctransformerclasses/NoWhitespaceBeforeTransformer.java | 1 - .../ctransformerclasses/ParenPadTransformer.java | 1 - .../ctransformerclasses/RedundantImportTransformer.java | 1 - .../ctransformerclasses/RequireThisTransformer.java | 1 - .../ctransformerclasses/RightCurlyTransformer.java | 1 - .../ctransformerclasses/TabCharacterTransformer.java | 1 - .../ctransformerclasses/TypecastParenPadTransformer.java | 1 - .../ctransformerclasses/UnusedImportsTransformer.java | 1 - .../ctransformerclasses/WhitespaceAfterTransformer.java | 1 - .../ctransformerclasses/WhitespaceAroundTransformer.java | 1 - ...rt_space_before_opening_paren_in_method_invocation.java | 1 - .../transformer/ftransformerclasses/T_tabulation_char.java | 1 - .../src/net/sf/eclipsecs/core/util/EclipseLogHandler.java | 1 - .../net/sf/eclipsecs/core/util/ExtensionClassLoader.java | 1 - .../src/net/sf/eclipsecs/core/util/XMLUtil.java | 1 - .../net/sf/eclipsecs/ui/CheckstyleMarkerImageProvider.java | 1 - .../src/net/sf/eclipsecs/ui/CheckstyleUIPluginImages.java | 1 - .../src/net/sf/eclipsecs/ui/CheckstyleUIPluginPrefs.java | 1 - net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/Messages.java | 1 - .../sf/eclipsecs/ui/actions/ActivateProjectsAction.java | 2 -- .../sf/eclipsecs/ui/actions/CheckSelectedFilesAction.java | 1 - .../eclipsecs/ui/actions/CheckstyleTransformingAction.java | 1 - .../sf/eclipsecs/ui/actions/ClearSelectedFilesAction.java | 2 -- .../ui/actions/ConfigureProjectFromBluePrintAction.java | 2 -- .../sf/eclipsecs/ui/actions/DeactivateProjectsAction.java | 2 -- .../eclipsecs/ui/actions/FormatterTransformingAction.java | 1 - .../src/net/sf/eclipsecs/ui/actions/PurgeCachesAction.java | 1 - .../ui/config/CheckConfigurationConfigureDialog.java | 7 ------- .../ui/config/CheckConfigurationPropertiesDialog.java | 1 - .../ui/config/CheckConfigurationWorkingSetEditor.java | 3 --- .../ui/config/PropertiesContentAssistProcessor.java | 1 - .../sf/eclipsecs/ui/config/ResolvablePropertiesDialog.java | 3 --- .../ui/config/configtypes/BuiltInConfigurationEditor.java | 1 - .../ui/config/configtypes/ConfigurationTypesUI.java | 1 - .../configtypes/ExternalFileConfigurationEditor.java | 1 - .../ui/config/configtypes/ICheckConfigurationEditor.java | 1 - .../ui/config/configtypes/InternalConfigurationEditor.java | 1 - .../ui/config/configtypes/ProjectConfigurationEditor.java | 1 - .../ui/config/configtypes/RemoteConfigurationEditor.java | 1 - .../ui/config/widgets/ConfigPropertyWidgetMultiCheck.java | 1 - .../ui/config/widgets/ConfigPropertyWidgetRegex.java | 1 - .../eclipsecs/ui/preferences/CheckstylePreferencePage.java | 1 - .../ui/preferences/CheckstyleSettingsTransfer.java | 1 - .../ui/properties/CheckConfigurationContentProvider.java | 1 - .../sf/eclipsecs/ui/properties/CheckstylePropertyPage.java | 2 -- .../ui/properties/FileMatchPatternEditDialog.java | 2 -- .../net/sf/eclipsecs/ui/properties/FileSetEditDialog.java | 1 - .../net/sf/eclipsecs/ui/properties/IFileSetsEditor.java | 1 - .../sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java | 2 -- .../ui/properties/filter/CheckFileOnOpenPartListener.java | 1 - .../ui/properties/filter/FileTypesFilterEditor.java | 2 -- .../sf/eclipsecs/ui/properties/filter/IFilterEditor.java | 1 - .../ui/properties/filter/PackageFilterEditor.java | 2 -- .../ui/properties/filter/PluginFilterEditors.java | 1 - .../sf/eclipsecs/ui/quickfixes/AbstractASTResolution.java | 2 -- .../ui/quickfixes/CheckstyleMarkerResolutionGenerator.java | 1 - .../ui/quickfixes/FixCheckstyleMarkersAction.java | 1 - .../ui/quickfixes/FixCheckstyleMarkersHandler.java | 1 - .../eclipsecs/ui/quickfixes/FixCheckstyleMarkersJob.java | 1 - .../ui/quickfixes/ICheckstyleMarkerResolution.java | 1 - .../ui/quickfixes/blocks/AvoidNestedBlocksQuickfix.java | 1 - .../eclipsecs/ui/quickfixes/blocks/NeedBracesQuickfix.java | 1 - .../ui/quickfixes/coding/DefaultComesLastQuickfix.java | 1 - .../ui/quickfixes/coding/EmptyStatementQuickfix.java | 1 - .../quickfixes/coding/ExplicitInitializationQuickfix.java | 1 - .../ui/quickfixes/coding/FinalLocalVariableQuickfix.java | 2 -- .../ui/quickfixes/coding/MissingSwitchDefaultQuickfix.java | 1 - .../ui/quickfixes/coding/RequireThisQuickfix.java | 1 - .../quickfixes/coding/SimplifyBooleanReturnQuickfix.java | 1 - .../quickfixes/coding/StringLiteralEqualityQuickfix.java | 1 - .../ui/quickfixes/design/DesignForExtensionQuickfix.java | 2 -- .../eclipsecs/ui/quickfixes/design/FinalClassQuickfix.java | 2 -- .../ui/quickfixes/misc/ArrayTypeStyleQuickfix.java | 1 - .../ui/quickfixes/misc/FinalParametersQuickfix.java | 2 -- .../ui/quickfixes/misc/UncommentedMainQuickfix.java | 1 - .../sf/eclipsecs/ui/quickfixes/misc/UpperEllQuickfix.java | 1 - .../ui/quickfixes/modifier/ModifierOrderQuickfix.java | 1 - .../ui/quickfixes/modifier/RedundantModifierQuickfix.java | 1 - .../src/net/sf/eclipsecs/ui/stats/Messages.java | 1 - .../src/net/sf/eclipsecs/ui/stats/data/CreateStatsJob.java | 1 - .../src/net/sf/eclipsecs/ui/stats/data/MarkerStat.java | 1 - .../src/net/sf/eclipsecs/ui/stats/data/Stats.java | 1 - .../net/sf/eclipsecs/ui/stats/views/AbstractStatsView.java | 2 -- .../ui/stats/views/internal/CheckstyleMarkerFilter.java | 1 - .../stats/views/internal/CheckstyleMarkerFilterDialog.java | 3 --- .../eclipsecs/ui/stats/views/internal/FiltersAction.java | 1 - .../src/net/sf/eclipsecs/ui/util/SWTUtil.java | 4 ---- .../sf/eclipsecs/ui/util/table/EnhancedTableViewer.java | 3 --- .../eclipsecs/ui/util/table/ITableComparableProvider.java | 1 - .../sf/eclipsecs/ui/util/table/ITableSettingsProvider.java | 1 - 176 files changed, 216 deletions(-) diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/CheckstylePluginPrefs.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/CheckstylePluginPrefs.java index 038f634da..116b2b91b 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/CheckstylePluginPrefs.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/CheckstylePluginPrefs.java @@ -33,7 +33,6 @@ /** * Class for handling preferences of the net.sf.eclipsecs.core plugin. * - * @author Lars Ködderitzsch */ public class CheckstylePluginPrefs extends AbstractPreferenceInitializer { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/Messages.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/Messages.java index c40d15b99..f288f5c28 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/Messages.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/Messages.java @@ -25,7 +25,6 @@ /** * Class providing messages for the checkstyle plugin. Uses the eclipse new nls mechanism. * - * @author Lars Ködderitzsch */ public final class Messages extends NLS { // CHECKSTYLE:OFF diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java index f2b833f68..3a75cbb1b 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java @@ -226,8 +226,6 @@ private List getFilesList() { * Implementation of the audit listener. This listener creates markers on the file resources if * checkstyle messages are reported. * - * @author David Schneider - * @author Lars Ködderitzsch */ private class CheckstyleAuditListener implements AuditListener { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckerFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckerFactory.java index 44ed8c519..093a71372 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckerFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckerFactory.java @@ -55,7 +55,6 @@ /** * Factory class to create (and cache) checker objects. * - * @author Lars Ködderitzsch */ public final class CheckerFactory { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckstyleBuilder.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckstyleBuilder.java index 8aaa42871..836a42a00 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckstyleBuilder.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckstyleBuilder.java @@ -61,8 +61,6 @@ /** * Project builder for Checkstyle plug-in. * - * @author David Schneider - * @author Lars Ködderitzsch */ public class CheckstyleBuilder extends IncrementalProjectBuilder { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfiguration.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfiguration.java index 8a8d4ee0b..b9ba873a8 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfiguration.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfiguration.java @@ -35,7 +35,6 @@ * Base implementation of a check configuration. Leaves the specific tasks to the concrete * subclasses. * - * @author Lars Ködderitzsch */ public class CheckConfiguration implements ICheckConfiguration { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationTester.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationTester.java index 4b0de10e3..0d9cd56f1 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationTester.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationTester.java @@ -45,7 +45,6 @@ * * . * - * @author Lars Ködderitzsch */ public class CheckConfigurationTester { @@ -112,7 +111,6 @@ public List getUnresolvedProperties() throws CheckstylePlugi * not being resolved by a given other property resolver. This is used to find unresolved * properties after all other property reolvers have been asked. * - * @author Lars Ködderitzsch */ private static class MissingPropertyCollector implements PropertyResolver { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationWorkingCopy.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationWorkingCopy.java index aaa427d02..5027accb2 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationWorkingCopy.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationWorkingCopy.java @@ -53,7 +53,6 @@ * This class acts as wrapper around check configurations to add editing aspects. Check * configurations by themself are not editable. * - * @author Lars Ködderitzsch */ public class CheckConfigurationWorkingCopy implements ICheckConfiguration, Cloneable { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckstyleConfigurationFile.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckstyleConfigurationFile.java index c3bdfcbf6..fbd9b9563 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckstyleConfigurationFile.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckstyleConfigurationFile.java @@ -31,7 +31,6 @@ * Simple object containing all sort of data of a Checkstyle configuration. This is done to not * access the Checkstyle configuration file too many times to get small bits of information. * - * @author Lars Ködderitzsch */ public class CheckstyleConfigurationFile { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java index f4b2f3381..ad283bf91 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java @@ -43,7 +43,6 @@ /** * Utility class to read a checkstyle configuration and transform to the plugins module objects. * - * @author Lars Ködderitzsch */ public final class ConfigurationReader { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java index 544eb7457..6bc3332eb 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java @@ -42,7 +42,6 @@ /** * Writes the modules of a checkstyle configuration to an output stream. * - * @author Lars Ködderitzsch */ public final class ConfigurationWriter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java index 8398b60d8..392d487f6 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java @@ -52,7 +52,6 @@ * Working set implementation that manages global configurations configured for the Eclipse * workspace. * - * @author Lars Ködderitzsch */ public class GlobalCheckConfigurationWorkingSet implements ICheckConfigurationWorkingSet { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ICheckConfiguration.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ICheckConfiguration.java index 554907bd1..234dbd479 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ICheckConfiguration.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ICheckConfiguration.java @@ -30,7 +30,6 @@ /** * Interface for a check configuration object. * - * @author Lars Ködderitzsch */ public interface ICheckConfiguration { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ICheckConfigurationWorkingSet.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ICheckConfigurationWorkingSet.java index 8ddf74de1..fe6735231 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ICheckConfigurationWorkingSet.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ICheckConfigurationWorkingSet.java @@ -30,7 +30,6 @@ /** * Interface for implementations that provide editing services for a group of check configuration. * - * @author Lars Ködderitzsch */ public interface ICheckConfigurationWorkingSet { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Module.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Module.java index c45991e08..c5bce6f81 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Module.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Module.java @@ -32,7 +32,6 @@ /** * Object representing a module from a checkstyle configuration. Can be augmented with meta data. * - * @author Lars Ködderitzsch */ public class Module implements Cloneable { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ResolvableProperty.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ResolvableProperty.java index a8899b982..405ae33b0 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ResolvableProperty.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ResolvableProperty.java @@ -27,8 +27,6 @@ /** * Represents a configuration property who's value must be resolved. * - * @author David Schneider - * @author Lars Ködderitzsch */ public class ResolvableProperty implements Cloneable { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Severity.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Severity.java index 23e4f7fdd..ff654c771 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Severity.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Severity.java @@ -24,7 +24,6 @@ * Enumeration for Checkstyle's severity levels. The intent is to decouple highler level funtions * (UI) from dealing with Checkstyle code API. * - * @author Lars Ködderitzsch */ public enum Severity { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/BuiltInConfigurationType.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/BuiltInConfigurationType.java index 67d65b64f..8203b906d 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/BuiltInConfigurationType.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/BuiltInConfigurationType.java @@ -36,7 +36,6 @@ * Implementation of the configuration type for a built in check configuration, that is located * inside the plugin. * - * @author Lars Ködderitzsch */ public class BuiltInConfigurationType extends ConfigurationType { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/BuiltInFilePropertyResolver.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/BuiltInFilePropertyResolver.java index b9381672e..18ab37f11 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/BuiltInFilePropertyResolver.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/BuiltInFilePropertyResolver.java @@ -33,7 +33,6 @@ * Adds support for additional checkstyle config files (header, suppressions etc.) to be delivered * with a builtin configuration. * - * @author Lars Ködderitzsch */ public class BuiltInFilePropertyResolver implements PropertyResolver { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ClasspathVariableResolver.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ClasspathVariableResolver.java index 213e6c9a0..b9de365a2 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ClasspathVariableResolver.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ClasspathVariableResolver.java @@ -28,7 +28,6 @@ /** * Property resolver that tries to resolve values from classpath variables. * - * @author Lars Ködderitzsch */ public class ClasspathVariableResolver implements PropertyResolver { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ConfigurationType.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ConfigurationType.java index 660b7c565..13b34831d 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ConfigurationType.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ConfigurationType.java @@ -42,7 +42,6 @@ /** * Base implementation of IConfigurationType. * - * @author Lars Ködderitzsch */ public abstract class ConfigurationType implements IConfigurationType { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ConfigurationTypes.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ConfigurationTypes.java index 730546531..9650001be 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ConfigurationTypes.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ConfigurationTypes.java @@ -37,7 +37,6 @@ * Register for the configuration types thats use the net.sf.eclipsecs.core.configurationtypes * extension point. * - * @author Lars Ködderitzsch */ public final class ConfigurationTypes { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ExternalFileConfigurationType.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ExternalFileConfigurationType.java index d4745375a..18734824d 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ExternalFileConfigurationType.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ExternalFileConfigurationType.java @@ -34,7 +34,6 @@ /** * Implementation of a check configuration that uses an exteral checkstyle configuration file. * - * @author Lars Ködderitzsch */ public class ExternalFileConfigurationType extends ConfigurationType { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/IConfigurationType.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/IConfigurationType.java index 51f40e131..8c1f00872 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/IConfigurationType.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/IConfigurationType.java @@ -29,7 +29,6 @@ /** * Interface for a configuration type. * - * @author Lars Ködderitzsch */ public interface IConfigurationType { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/IContextAware.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/IContextAware.java index aeb6f51c3..48af900e6 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/IContextAware.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/IContextAware.java @@ -25,7 +25,6 @@ /** * Interface for plugin property resolvers. * - * @author Lars Ködderitzsch */ public interface IContextAware { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/InternalConfigurationType.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/InternalConfigurationType.java index 488dd0ad3..ede1d105e 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/InternalConfigurationType.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/InternalConfigurationType.java @@ -36,7 +36,6 @@ * Implementation of the configuration type for a internal check configuration, that is located * inside the plugin. * - * @author Lars Ködderitzsch */ public class InternalConfigurationType extends ConfigurationType { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/MultiPropertyResolver.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/MultiPropertyResolver.java index 7565cce37..ae856d75a 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/MultiPropertyResolver.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/MultiPropertyResolver.java @@ -34,7 +34,6 @@ * child resolvers are asked to resolve the properties in the order they are added. This * PropertyResolver adds the property chaining feature, to allow properties within properties. * - * @author Lars Ködderitzsch */ public class MultiPropertyResolver implements PropertyResolver, IContextAware { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ProjectConfigurationType.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ProjectConfigurationType.java index edab8c720..2524ba271 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ProjectConfigurationType.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ProjectConfigurationType.java @@ -39,7 +39,6 @@ /** * Implementation of a check configuration that uses an exteral checkstyle configuration file. * - * @author Lars Ködderitzsch */ public class ProjectConfigurationType extends ConfigurationType { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/PropertyUtil.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/PropertyUtil.java index b6f1fdcc7..2f1a61647 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/PropertyUtil.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/PropertyUtil.java @@ -31,7 +31,6 @@ * Utility class for handling strings that contain properties using the very common ${propertyName} * pattern. The code originally comes from the ANT project. * - * @author Lars Ködderitzsch */ public final class PropertyUtil { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/RemoteConfigurationType.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/RemoteConfigurationType.java index c0e64825c..2ed35235b 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/RemoteConfigurationType.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/RemoteConfigurationType.java @@ -57,7 +57,6 @@ /** * Implementation of a check configuration that uses an exteral checkstyle configuration file. * - * @author Lars Ködderitzsch */ public class RemoteConfigurationType extends ConfigurationType { @@ -332,7 +331,6 @@ protected byte[] getBytesFromURLConnection(URLConnection connection) throws IOEx /** * Support for http authentication. * - * @author Lars Ködderitzsch */ public static final class RemoteConfigAuthenticator { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ResolvablePropertyResolver.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ResolvablePropertyResolver.java index d9b572315..75ba20ae7 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ResolvablePropertyResolver.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ResolvablePropertyResolver.java @@ -30,7 +30,6 @@ /** * Resolves properties set up with the check configuration. * - * @author Lars Ködderitzsch */ public class ResolvablePropertyResolver implements PropertyResolver { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ResourceBundlePropertyResolver.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ResourceBundlePropertyResolver.java index 9c4954050..cfdddcc1e 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ResourceBundlePropertyResolver.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/ResourceBundlePropertyResolver.java @@ -28,7 +28,6 @@ /** * Property resolver that resolves properties from a resource bundle. * - * @author Lars Ködderitzsch */ class ResourceBundlePropertyResolver implements PropertyResolver { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/StandardPropertyResolver.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/StandardPropertyResolver.java index d8b21ff77..eb47fbeec 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/StandardPropertyResolver.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/StandardPropertyResolver.java @@ -28,7 +28,6 @@ /** * Property resolver that resolves some eclipse standard variables. * - * @author Lars Ködderitzsch */ public class StandardPropertyResolver implements PropertyResolver, IContextAware { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/SystemPropertyResolver.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/SystemPropertyResolver.java index 47d3136ca..49bd83a9c 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/SystemPropertyResolver.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/configtypes/SystemPropertyResolver.java @@ -25,7 +25,6 @@ /** * Property resolver implementation that resolves system properties. * - * @author Lars Ködderitzsch */ public class SystemPropertyResolver implements PropertyResolver { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/AllTokensProvider.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/AllTokensProvider.java index 9ccb6df49..95f07c67e 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/AllTokensProvider.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/AllTokensProvider.java @@ -30,7 +30,6 @@ * Class that provides all known tokens from the checkstyle java grammar. This is used for modules * that allow all tokens as options - which is very tedious to maintain in the metadata. * - * @author Lars Ködderitzsch */ public class AllTokensProvider implements IOptionProvider { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/IOptionProvider.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/IOptionProvider.java index ffa6b88bf..cbed44ee2 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/IOptionProvider.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/IOptionProvider.java @@ -27,7 +27,6 @@ * which would be too difficult to handle in metadata. For instance this is true for module metadata * that need all token types as options. * - * @author Lars Ködderitzsch */ public interface IOptionProvider { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java index 2accee45d..e0afdfa00 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java @@ -873,7 +873,6 @@ private static String localize(String localizationCandidate, ResourceBundle meta * Custom ResourceBundle.Control implementation which allows explicitly read the properties files * as UTF-8. * - * @author Aleksey Nesterenko */ private static class UTF8Control extends Control { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/CheckerModuleSaveFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/CheckerModuleSaveFilter.java index ab6e83872..631137e8c 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/CheckerModuleSaveFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/CheckerModuleSaveFilter.java @@ -29,7 +29,6 @@ /** * Special module logic for the Checker module. * - * @author Lars Ködderitzsch */ public class CheckerModuleSaveFilter implements ISaveFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/ISaveFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/ISaveFilter.java index e8b346b5c..91b005bf8 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/ISaveFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/ISaveFilter.java @@ -27,7 +27,6 @@ /** * Interface to implement special module logic. * - * @author Lars Ködderitzsch */ public interface ISaveFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SaveFilters.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SaveFilters.java index 539ddbf84..bb0a5aea2 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SaveFilters.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SaveFilters.java @@ -35,7 +35,6 @@ * Register for the filters thats use the net.sf.eclipsecs.core.checkstyleFilter extension * point. Checkstyle filters can be enabled per project. * - * @author Lars Ködderitzsch */ public final class SaveFilters { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SortingSaveFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SortingSaveFilter.java index f704d812c..296f4709a 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SortingSaveFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SortingSaveFilter.java @@ -30,7 +30,6 @@ /** * Save filter that sorts modules in a certain order. * - * @author Lars Ködderitzsch */ public class SortingSaveFilter implements ISaveFilter { @@ -45,7 +44,6 @@ public void postProcessConfiguredModules(List configuredModules) { * Comparator to sort modules so that Checker and TreeWalker come first. This is done because of a * bug in SuppressionCommentFilter. * - * @author Lars Ködderitzsch */ private static class ModuleComparator implements Comparator { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SuppressWarningsHolderSaveFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SuppressWarningsHolderSaveFilter.java index 2db973757..c3662395f 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SuppressWarningsHolderSaveFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/SuppressWarningsHolderSaveFilter.java @@ -29,7 +29,6 @@ /** * Special module logic for the SuppressWarningsHolder module. * - * @author Lars Ködderitzsch */ public class SuppressWarningsHolderSaveFilter implements ISaveFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/TreeWalkerModuleSaveFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/TreeWalkerModuleSaveFilter.java index 328cd3faf..5cdbbb7e9 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/TreeWalkerModuleSaveFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/savefilter/TreeWalkerModuleSaveFilter.java @@ -29,7 +29,6 @@ /** * Special module logic for the TreeWalker module. * - * @author Lars Ködderitzsch */ public class TreeWalkerModuleSaveFilter implements ISaveFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/AuditorJob.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/AuditorJob.java index 6974305c0..9cc8cd2be 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/AuditorJob.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/AuditorJob.java @@ -37,7 +37,6 @@ * Job to de-couple an audit. Used for the "Run Checkstyle in background on full build" * functionality. * - * @author Lars Ködderitzsch */ public class AuditorJob extends AbstractCheckJob { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/BuildProjectJob.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/BuildProjectJob.java index 595617b96..5f21684e0 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/BuildProjectJob.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/BuildProjectJob.java @@ -34,7 +34,6 @@ /** * Operation which builds a project. * - * @author Lars Ködderitzsch */ public class BuildProjectJob extends Job { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/ConfigureDeconfigureNatureJob.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/ConfigureDeconfigureNatureJob.java index b59dc2657..fac787a4f 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/ConfigureDeconfigureNatureJob.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/ConfigureDeconfigureNatureJob.java @@ -39,7 +39,6 @@ * already configured with this nature, the nature will be deconfigured. Otherwise if the project is * not configured with this nature, the nature will be configured for this project * - * @author Lars Ködderitzsch */ public class ConfigureDeconfigureNatureJob extends WorkspaceJob { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/RunCheckstyleOnFilesJob.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/RunCheckstyleOnFilesJob.java index d0f9d624a..e37afbe53 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/RunCheckstyleOnFilesJob.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/RunCheckstyleOnFilesJob.java @@ -47,7 +47,6 @@ /** * Job that invokes Checkstyle on a list of workspace files. * - * @author Lars Ködderitzsch */ public class RunCheckstyleOnFilesJob extends AbstractCheckJob { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/TransformCheckstyleRulesJob.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/TransformCheckstyleRulesJob.java index 3247b5d80..0301be24a 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/TransformCheckstyleRulesJob.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/TransformCheckstyleRulesJob.java @@ -53,7 +53,6 @@ /** * Job which starts transforming the checkstyle-rules to eclipse-formatter-settings. * - * @author Lukas Frena * */ public class TransformCheckstyleRulesJob extends WorkspaceJob { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/TransformFormatterRulesJob.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/TransformFormatterRulesJob.java index 7f6803ae5..120e6bcc2 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/TransformFormatterRulesJob.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/jobs/TransformFormatterRulesJob.java @@ -40,7 +40,6 @@ /** * Job who starts transforming the formatter-rules to checkstyle-settings. * - * @author Lukas Frena * */ public class TransformFormatterRulesJob extends WorkspaceJob { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/IProjectConfiguration.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/IProjectConfiguration.java index dce7df16b..962aafb2b 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/IProjectConfiguration.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/IProjectConfiguration.java @@ -30,7 +30,6 @@ /** * The public interface of a project configuration. * - * @author Lars Ködderitzsch */ public interface IProjectConfiguration { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java index 20ac50029..93c63e439 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java @@ -37,7 +37,6 @@ /** * Working set implementation that manages local configurations configured for the project. * - * @author Lars Ködderitzsch */ public class LocalCheckConfigurationWorkingSet implements ICheckConfigurationWorkingSet { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/PluginFilters.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/PluginFilters.java index 582fafd72..44afccd97 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/PluginFilters.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/PluginFilters.java @@ -34,7 +34,6 @@ * Register for the filters thats use the net.sf.eclipsecs.core.checkstyleFilter extension * point. Checkstyle filters can be enabled per project. * - * @author Lars Ködderitzsch */ public final class PluginFilters { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfiguration.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfiguration.java index d1ec2fbc3..7f22d9ef9 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfiguration.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfiguration.java @@ -39,7 +39,6 @@ * Represents the configuration for a project. Contains the file sets configured for the project * plus the additional filters. * - * @author Lars Ködderitzsch */ public class ProjectConfiguration implements Cloneable, IProjectConfiguration { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationWorkingCopy.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationWorkingCopy.java index 12d64b485..503046c4e 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationWorkingCopy.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationWorkingCopy.java @@ -56,7 +56,6 @@ /** * A modifiable project configuration implementation. * - * @author Lars Ködderitzsch */ public class ProjectConfigurationWorkingCopy implements Cloneable, IProjectConfiguration { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/AbstractFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/AbstractFilter.java index 081fe9542..82802d53a 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/AbstractFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/AbstractFilter.java @@ -28,7 +28,6 @@ /** * Base implementation of a filter. * - * @author Lars Ködderitzsch */ public abstract class AbstractFilter implements IFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/DerivedFilesFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/DerivedFilesFilter.java index 550161b44..92d0d2826 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/DerivedFilesFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/DerivedFilesFilter.java @@ -25,7 +25,6 @@ /** * Implementation of a filter that filters all ressources that are derived (e.g. generated sources). * - * @author Lars Ködderitzsch */ public class DerivedFilesFilter extends AbstractFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/FilesInSyncFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/FilesInSyncFilter.java index 0a322bdc4..69a5a7430 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/FilesInSyncFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/FilesInSyncFilter.java @@ -34,7 +34,6 @@ /** * Filters all files that are in sync with the source repository. * - * @author Lars Ködderitzsch */ public class FilesInSyncFilter extends AbstractFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/IFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/IFilter.java index 3180d3ae9..22344461b 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/IFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/IFilter.java @@ -25,7 +25,6 @@ /** * Interface for a filter. * - * @author Lars Ködderitzsch */ public interface IFilter extends Cloneable { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/NonSrcDirsFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/NonSrcDirsFilter.java index f860ddce4..98fbe7c62 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/NonSrcDirsFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/NonSrcDirsFilter.java @@ -36,7 +36,6 @@ /** * Implementation of a filter that filters all ressources that are not within a source directory. * - * @author Lars Ködderitzsch */ public class NonSrcDirsFilter extends AbstractFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/PackageFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/PackageFilter.java index 4e2047895..7bd1fd35c 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/PackageFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/PackageFilter.java @@ -33,7 +33,6 @@ * filters resources that lie within excluded packages. This filter is used for the checkstyle audit * function of this plugin. * - * @author Lars Ködderitzsch */ public class PackageFilter extends AbstractFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/UnOpenedFilesFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/UnOpenedFilesFilter.java index 41356c159..5eba2bad9 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/UnOpenedFilesFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/UnOpenedFilesFilter.java @@ -28,7 +28,6 @@ /** * Filter that excludes all files that are not opened in an eclipse editor. * - * @author Lars Ködderitzsch */ public class UnOpenedFilesFilter extends AbstractFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/WriteProtectedFilter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/WriteProtectedFilter.java index 0fb944c0d..acaff1373 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/WriteProtectedFilter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/filters/WriteProtectedFilter.java @@ -26,7 +26,6 @@ /** * Implementation of a filter that filters all ressources that are write protected. * - * @author Lars Ködderitzsch */ public class WriteProtectedFilter extends AbstractFilter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CTransformationClass.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CTransformationClass.java index 306f6e52e..c0f266ccc 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CTransformationClass.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CTransformationClass.java @@ -30,7 +30,6 @@ * Abstract class which all transformationclasses have to implement. These classes handle how to * react on a checkstyle-rule. * - * @author Lukas Frena */ public abstract class CTransformationClass { /** The eclipse-configuration for this rule. */ diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleFileWriter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleFileWriter.java index b1213f0c7..2239ca052 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleFileWriter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleFileWriter.java @@ -31,7 +31,6 @@ /** * Class for writing the checkstyle configuration to a xml-file. * - * @author Lukas Frena * */ public class CheckstyleFileWriter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleSetting.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleSetting.java index 67c8877c2..ec1d48595 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleSetting.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleSetting.java @@ -26,7 +26,6 @@ /** * Class for storing all settings of a checkstyle-configuration file. * - * @author Lukas Frena * */ public class CheckstyleSetting { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleTransformer.java index db8c9a4b4..b4b54d27f 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleTransformer.java @@ -35,7 +35,6 @@ * The Class for transforming the checkstyle-rules into eclipse-formatter-settings. A new * formatter-profile gets created. * - * @author Lukas Frena */ public class CheckstyleTransformer { /** An object containing all settings for the eclipse-formatter. */ diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FTransformationClass.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FTransformationClass.java index 096535de2..2f8fbf6a1 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FTransformationClass.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FTransformationClass.java @@ -26,7 +26,6 @@ * Abstract class which all transformationclasses have to implement. These classes handle how to * react on a formatter-setting. * - * @author Lukas Frena */ public abstract class FTransformationClass { /** The checkstyle-configuration for this rule. */ diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfigParser.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfigParser.java index 18ea631ea..a7b7c1c55 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfigParser.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfigParser.java @@ -28,7 +28,6 @@ /** * Class for parsing a eclipse-formatter-configuration-file for formatter-settings. * - * @author Lukas Frena */ public class FormatterConfigParser { /** A FormatterConfiguration with all rules that will be found. */ diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfigWriter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfigWriter.java index 95809cb64..029e85122 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfigWriter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfigWriter.java @@ -36,9 +36,6 @@ * Class for writing a new eclipse-configuration-file. Gets used by class Transformer. Two * eclipse-formatter-profile files gets written to the project root. * - * @author Alexandros Karypidis - * @author Lukas Frena - * @author Lars Ködderitzsch */ public class FormatterConfigWriter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfiguration.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfiguration.java index 24991bed0..136e05ed6 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfiguration.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterConfiguration.java @@ -28,7 +28,6 @@ /** * Class containing all configurations for a eclipse-formatter-profile. * - * @author Lukas Frena */ public class FormatterConfiguration { /** Map containing all eclipse editor-settings. */ diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterTransformer.java index 943677017..77840f524 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/FormatterTransformer.java @@ -31,7 +31,6 @@ * The Class for transforming the formatter-settings to Checkstyle-rules. A new checkstyle-xml file * gets generated. * - * @author Lukas Frena */ public class FormatterTransformer { /** An object containing all settings for the checkstyle-file. */ diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/XmlProfileWriter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/XmlProfileWriter.java index 97cc6069e..e6f467558 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/XmlProfileWriter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/XmlProfileWriter.java @@ -45,7 +45,6 @@ /** * Utility class to write eclipse formatter/cleanup profile XML files. * - * @author Alexandros Karypidis * */ public final class XmlProfileWriter { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/AvoidStarImportTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/AvoidStarImportTransformer.java index 531e45a6b..e0d4168d7 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/AvoidStarImportTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/AvoidStarImportTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule AvoidStarImport to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class AvoidStarImportTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FileTabCharacterTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FileTabCharacterTransformer.java index be7bdbc1b..8d13a4bfb 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FileTabCharacterTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FileTabCharacterTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule FileTabCharacter to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class FileTabCharacterTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalLocalVariableTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalLocalVariableTransformer.java index accbc0186..2bf3fe0e4 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalLocalVariableTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalLocalVariableTransformer.java @@ -29,7 +29,6 @@ * Wrapperclass for converting the checkstyle-rule FinalLocalVariableWrap to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class FinalLocalVariableTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalParametersTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalParametersTransformer.java index f1b23ccdd..6fd52ee59 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalParametersTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalParametersTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule FinalParameters to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class FinalParametersTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/GenericWhitespaceTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/GenericWhitespaceTransformer.java index c5310ce60..bc58b8be8 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/GenericWhitespaceTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/GenericWhitespaceTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule GerenricWhitespace to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class GenericWhitespaceTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/IndentationTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/IndentationTransformer.java index 890b67fbd..9f9e9800a 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/IndentationTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/IndentationTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule IdentationWrap to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class IndentationTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LeftCurlyTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LeftCurlyTransformer.java index 4460869ed..ca9fb58f1 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LeftCurlyTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LeftCurlyTransformer.java @@ -28,7 +28,6 @@ /** * Wrapperclass for converting the checkstyle-rule LeftCurly to appropriate eclipse-formatter-rules. * - * @author Lukas Frena */ public class LeftCurlyTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LineLengthTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LineLengthTransformer.java index c2ca1bf6d..1a3a00ef2 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LineLengthTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LineLengthTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule LineLength to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class LineLengthTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MethodParamPadTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MethodParamPadTransformer.java index 2b6877d1c..183610822 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MethodParamPadTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MethodParamPadTransformer.java @@ -29,7 +29,6 @@ * Wrapperclass for converting the checkstyle-rule MethodParamPad to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class MethodParamPadTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MissingDeprecatedTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MissingDeprecatedTransformer.java index ef91cf9e8..00d17d647 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MissingDeprecatedTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MissingDeprecatedTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule MissingDeprecated to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class MissingDeprecatedTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MissingOverrideTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MissingOverrideTransformer.java index 3d0be5c0c..f4743ab48 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MissingOverrideTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MissingOverrideTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule MissingOverride to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class MissingOverrideTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NeedBracesTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NeedBracesTransformer.java index 2f98f5c0c..8453b220f 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NeedBracesTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NeedBracesTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule NeedBraces to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class NeedBracesTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NewlineAtEndOfFileTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NewlineAtEndOfFileTransformer.java index f45938d69..47acdda87 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NewlineAtEndOfFileTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NewlineAtEndOfFileTransformer.java @@ -26,7 +26,6 @@ /** * Transforms the "New Line At End Of File" checkstyle rule to the respective formatter setting. * - * @author Lukas Frena */ public class NewlineAtEndOfFileTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceAfterTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceAfterTransformer.java index 4a054b11d..443e8b93a 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceAfterTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceAfterTransformer.java @@ -29,7 +29,6 @@ * Wrapperclass for converting the checkstyle-rule NoWhitespaceAfter to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class NoWhitespaceAfterTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceBeforeTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceBeforeTransformer.java index a37121224..47ba852a2 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceBeforeTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceBeforeTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule NoWhitespaceBefore to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class NoWhitespaceBeforeTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/ParenPadTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/ParenPadTransformer.java index 837c6a638..9a372825b 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/ParenPadTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/ParenPadTransformer.java @@ -28,7 +28,6 @@ /** * Wrapperclass for converting the checkstyle-rule ParenPad to appropriate eclipse-formatter-rules. * - * @author Lukas Frena */ public class ParenPadTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RedundantImportTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RedundantImportTransformer.java index 46f16a212..c2519fdaf 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RedundantImportTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RedundantImportTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule RedundantImport to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class RedundantImportTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RequireThisTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RequireThisTransformer.java index 67976dd28..2d18b0379 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RequireThisTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RequireThisTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule RequireThis to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class RequireThisTransformer extends CTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RightCurlyTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RightCurlyTransformer.java index 71bebd294..a0677179f 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RightCurlyTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RightCurlyTransformer.java @@ -29,7 +29,6 @@ * Wrapperclass for converting the checkstyle-rule RightCurly to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class RightCurlyTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TabCharacterTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TabCharacterTransformer.java index 20dc323bc..5a4947402 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TabCharacterTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TabCharacterTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule TabCharacter to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class TabCharacterTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TypecastParenPadTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TypecastParenPadTransformer.java index 30cb0c644..fd0f399e7 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TypecastParenPadTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TypecastParenPadTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule TypecastParenPad to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class TypecastParenPadTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/UnusedImportsTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/UnusedImportsTransformer.java index 957ce72d2..f16d99fc0 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/UnusedImportsTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/UnusedImportsTransformer.java @@ -27,7 +27,6 @@ * Wrapperclass for converting the checkstyle-rule UnusedImports to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class UnusedImportsTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAfterTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAfterTransformer.java index 23553cac0..e62604d2b 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAfterTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAfterTransformer.java @@ -29,7 +29,6 @@ * Wrapperclass for converting the checkstyle-rule WhitespaceAfter to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class WhitespaceAfterTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAroundTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAroundTransformer.java index bc12247e1..ca752a7ae 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAroundTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAroundTransformer.java @@ -29,7 +29,6 @@ * Wrapperclass for converting the checkstyle-rule WhitespaceAround to appropriate * eclipse-formatter-rules. * - * @author Lukas Frena */ public class WhitespaceAroundTransformer extends CTransformationClass { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ftransformerclasses/T_insert_space_before_opening_paren_in_method_invocation.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ftransformerclasses/T_insert_space_before_opening_paren_in_method_invocation.java index ed41a45a6..4d9a8e97f 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ftransformerclasses/T_insert_space_before_opening_paren_in_method_invocation.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ftransformerclasses/T_insert_space_before_opening_paren_in_method_invocation.java @@ -29,7 +29,6 @@ * Transformerclass for converting the formatter-setting * "insert.space.before.opening.paren.in.method.invocation" to appropriate checkstyle-modules. * - * @author Lukas Frena */ public class T_insert_space_before_opening_paren_in_method_invocation extends FTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ftransformerclasses/T_tabulation_char.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ftransformerclasses/T_tabulation_char.java index c80f1c461..8df6f528b 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ftransformerclasses/T_tabulation_char.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ftransformerclasses/T_tabulation_char.java @@ -27,7 +27,6 @@ * Transformerclass for converting the formatter-setting tabulation.char to appropriate * checkstyle-modules. * - * @author Lukas Frena */ public class T_tabulation_char extends FTransformationClass { @Override diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/EclipseLogHandler.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/EclipseLogHandler.java index 8666fe06c..135643f76 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/EclipseLogHandler.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/EclipseLogHandler.java @@ -37,7 +37,6 @@ * log events that get directly passed into the internal eclipse logging.
* This class act as bridge from java.util.logging to eclipse logging. * - * @author Lars Ködderitzsch */ public class EclipseLogHandler extends Handler { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/ExtensionClassLoader.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/ExtensionClassLoader.java index aaa1c22e6..63f973805 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/ExtensionClassLoader.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/ExtensionClassLoader.java @@ -37,7 +37,6 @@ * Classloader implementation which can load classes and resources from bundles implementing a * specific extension point. * - * @author Lars Ködderitzsch */ public class ExtensionClassLoader extends ClassLoader { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/XMLUtil.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/XMLUtil.java index 3dd830212..6a20d034c 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/XMLUtil.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/util/XMLUtil.java @@ -67,7 +67,6 @@ public static byte[] toByteArray(Document document) throws IOException { /** * Entity resolver which handles mapping public DTDs to internal DTD resource. * - * @author Lars Ködderitzsch */ public static class InternalDtdEntityResolver implements EntityResolver { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleMarkerImageProvider.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleMarkerImageProvider.java index 259f2b056..746d6938c 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleMarkerImageProvider.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleMarkerImageProvider.java @@ -30,7 +30,6 @@ /** * Image provider for Checkstyle markers. * - * @author Lars Ködderitzsch */ public class CheckstyleMarkerImageProvider implements IAnnotationImageProvider { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleUIPluginImages.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleUIPluginImages.java index cb44e022a..9f199eb97 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleUIPluginImages.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleUIPluginImages.java @@ -34,7 +34,6 @@ /** * Manages and caches images for the plugin. * - * @author Lars Ködderitzsch */ public enum CheckstyleUIPluginImages { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleUIPluginPrefs.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleUIPluginPrefs.java index 39c0f4c3f..44bdeeb86 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleUIPluginPrefs.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/CheckstyleUIPluginPrefs.java @@ -34,7 +34,6 @@ /** * Initialize the plugin preferences. * - * @author Lars Ködderitzsch */ public class CheckstyleUIPluginPrefs extends AbstractPreferenceInitializer { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/Messages.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/Messages.java index d7032a65e..0ca5ccbdc 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/Messages.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/Messages.java @@ -26,7 +26,6 @@ * Class providing messages for the checkstyle plugin. Uses the eclipse new nls * mechanism. * - * @author Lars Ködderitzsch */ public final class Messages extends NLS { // CHECKSTYLE:OFF diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ActivateProjectsAction.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ActivateProjectsAction.java index 415dd12e5..9bd20bb65 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ActivateProjectsAction.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ActivateProjectsAction.java @@ -41,7 +41,6 @@ /** * Action to enable Checkstyle on one ore more projects. * - * @author Lars Ködderitzsch */ public class ActivateProjectsAction implements IObjectActionDelegate { @@ -70,7 +69,6 @@ public void run(IAction action) { /** * Activates Checkstyle on a collection of projects. * - * @author Lars Ködderitzsch */ private static class BulkCheckstyleActivateJob extends WorkspaceJob { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/CheckSelectedFilesAction.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/CheckSelectedFilesAction.java index 6071c4801..3231700ef 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/CheckSelectedFilesAction.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/CheckSelectedFilesAction.java @@ -47,7 +47,6 @@ /** * Action to run Checkstyle on one ore more projects. * - * @author Lars Ködderitzsch */ public class CheckSelectedFilesAction extends AbstractHandler implements IObjectActionDelegate { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/CheckstyleTransformingAction.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/CheckstyleTransformingAction.java index 4a43e70e5..bff3190b9 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/CheckstyleTransformingAction.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/CheckstyleTransformingAction.java @@ -32,7 +32,6 @@ /** * Action to start transforming checkstyle-rules to formatter-rules. * - * @author lakiluk */ public class CheckstyleTransformingAction implements IObjectActionDelegate { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ClearSelectedFilesAction.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ClearSelectedFilesAction.java index 25f6088ec..3d0c5ab8b 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ClearSelectedFilesAction.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ClearSelectedFilesAction.java @@ -41,7 +41,6 @@ /** * Action to diable Checkstyle on one ore more projects. * - * @author Lars Ködderitzsch */ public class ClearSelectedFilesAction implements IObjectActionDelegate { @@ -73,7 +72,6 @@ public void run(IAction action) { /** * Activates Checkstyle on a collection of projects. * - * @author Lars Ködderitzsch */ private static class ClearMarkersJob extends WorkspaceJob { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ConfigureProjectFromBluePrintAction.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ConfigureProjectFromBluePrintAction.java index 3739d0167..8b1535248 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ConfigureProjectFromBluePrintAction.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/ConfigureProjectFromBluePrintAction.java @@ -54,7 +54,6 @@ * Action to configure one ore more projects at once by using another project as * blueprint. * - * @author Lars Ködderitzsch */ public class ConfigureProjectFromBluePrintAction implements IObjectActionDelegate { @@ -109,7 +108,6 @@ public void run(IAction action) { * Job implementation that configures several projects from a blueprint * project. * - * @author Lars Ködderitzsch */ private static class BulkConfigureJob extends WorkspaceJob { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/DeactivateProjectsAction.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/DeactivateProjectsAction.java index b0e4f3d5a..111c892a2 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/DeactivateProjectsAction.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/DeactivateProjectsAction.java @@ -41,7 +41,6 @@ /** * Action to diable Checkstyle on one ore more projects. * - * @author Lars Ködderitzsch */ public class DeactivateProjectsAction implements IObjectActionDelegate { @@ -70,7 +69,6 @@ public void run(IAction action) { /** * Activates Checkstyle on a collection of projects. * - * @author Lars Ködderitzsch */ private static class BulkCheckstyleActivateJob extends WorkspaceJob { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/FormatterTransformingAction.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/FormatterTransformingAction.java index 46566441c..a8eca7615 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/FormatterTransformingAction.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/FormatterTransformingAction.java @@ -30,7 +30,6 @@ /** * Action to start transforming checkstyle-rules to formatter-rules. * - * @author lakiluk */ public class FormatterTransformingAction implements IObjectActionDelegate { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/PurgeCachesAction.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/PurgeCachesAction.java index b3d475491..2d49ff89a 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/PurgeCachesAction.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/actions/PurgeCachesAction.java @@ -34,7 +34,6 @@ * Simple handle which clears the CheckerFactory caches in order to force reload of supplementary * Checkstyle configuration files (suppressions, import control files etc.). * - * @author Lars Ködderitzsch */ public class PurgeCachesAction extends AbstractHandler implements IWorkbenchWindowActionDelegate { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationConfigureDialog.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationConfigureDialog.java index cf090beba..982161651 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationConfigureDialog.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationConfigureDialog.java @@ -100,7 +100,6 @@ /** * Enhanced checkstyle configuration editor. * - * @author Lars Ködderitzsch */ public class CheckConfigurationConfigureDialog extends TitleAreaDialog { @@ -500,7 +499,6 @@ private static String convertInlineCodeTags(String html) { /** * Controller for this page. * - * @author Lars Ködderitzsch */ private class PageController implements ISelectionChangedListener, ICheckStateListener, IDoubleClickListener, SelectionListener, KeyListener, ModifyListener { @@ -817,7 +815,6 @@ private boolean isAlreadyConfigured(RuleMetadata metadata) { /** * TreeContentProvider that provides the structure of the rule metadata. * - * @author Lars Ködderitzsch */ private static class MetaDataContentProvider implements ITreeContentProvider { @@ -877,7 +874,6 @@ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { /** * Label-provider for meta data information. * - * @author Lars Ködderitzsch */ private class MetaDataLabelProvider extends LabelProvider { @@ -941,7 +937,6 @@ private boolean isMetadataUsed(RuleMetadata metadata) { /** * Label provider for the table showing the configured modules. * - * @author Lars Ködderitzsch */ private static class ModuleLabelProvider extends LabelProvider implements ITableLabelProvider, ITableComparableProvider, ITableSettingsProvider { @@ -1008,7 +1003,6 @@ public IDialogSettings getTableSettings() { /** * Viewer filter that includes all modules that belong to the currently selected group. * - * @author Lars Ködderitzsch */ private static class RuleGroupModuleFilter extends ViewerFilter { @@ -1051,7 +1045,6 @@ public boolean select(Viewer viewer, Object parentElement, Object element) { * Filter implementation that filters the module tree with respect of a filter text field to input * a search word. * - * @author Lars Ködderitzsch */ private class TreeFilter extends ViewerFilter { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationPropertiesDialog.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationPropertiesDialog.java index 05b156e45..9a3a1a613 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationPropertiesDialog.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationPropertiesDialog.java @@ -65,7 +65,6 @@ * Dialog to show/edit the properties (name, location, description) of a check * configuration. Also used to create new check configurations. * - * @author Lars Ködderitzsch */ public class CheckConfigurationPropertiesDialog extends TitleAreaDialog { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationWorkingSetEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationWorkingSetEditor.java index 6072f3aa9..7e06b1247 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationWorkingSetEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationWorkingSetEditor.java @@ -76,7 +76,6 @@ /** * This class provides the editor GUI for a check configuration working set. * - * @author Lars Ködderitzsch */ public class CheckConfigurationWorkingSetEditor { @@ -557,7 +556,6 @@ private void exportCheckstyleCheckConfig() { * Label provider for the check configuration table. Implements also support for table sorting and * storing of the table settings. * - * @author Lars Ködderitzsch */ private class ConfigurationLabelProvider extends CheckConfigurationLabelProvider implements ITableLabelProvider, ITableComparableProvider, ITableSettingsProvider { @@ -628,7 +626,6 @@ public IDialogSettings getTableSettings() { /** * Controller for this page. * - * @author Lars Ködderitzsch */ private class PageController implements SelectionListener, IDoubleClickListener, ISelectionChangedListener { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/PropertiesContentAssistProcessor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/PropertiesContentAssistProcessor.java index 71ebfa4fe..acb4bd775 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/PropertiesContentAssistProcessor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/PropertiesContentAssistProcessor.java @@ -37,7 +37,6 @@ /** * Provides content assist for builtin properties. * - * @author Lars Ködderitzsch */ public class PropertiesContentAssistProcessor implements ISubjectControlContentAssistProcessor { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/ResolvablePropertiesDialog.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/ResolvablePropertiesDialog.java index 1c78a6e47..9f99150c9 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/ResolvablePropertiesDialog.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/ResolvablePropertiesDialog.java @@ -70,7 +70,6 @@ * Dialog to show/edit the properties (name, location, description) of a check * configuration. Also used to create new check configurations. * - * @author Lars Ködderitzsch */ public class ResolvablePropertiesDialog extends TitleAreaDialog { @@ -293,7 +292,6 @@ private void initialize() { /** * Controller for this dialog. * - * @author Lars Ködderitzsch */ private class Controller implements SelectionListener, IDoubleClickListener, KeyListener { @@ -437,7 +435,6 @@ private void findPropertyItems() { * Label provider for the check configuration table. Implements also support * for table sorting and storing of the table settings. * - * @author Lars Ködderitzsch */ private class PropertiesLabelProvider extends LabelProvider implements ITableLabelProvider, ITableComparableProvider, ITableSettingsProvider { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/BuiltInConfigurationEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/BuiltInConfigurationEditor.java index 1801afabc..0d12ce642 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/BuiltInConfigurationEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/BuiltInConfigurationEditor.java @@ -38,7 +38,6 @@ * Implementation of a location editor with only a not editable text field. This * is used to just show the location. * - * @author Lars Ködderitzsch */ public class BuiltInConfigurationEditor implements ICheckConfigurationEditor { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ConfigurationTypesUI.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ConfigurationTypesUI.java index 8cf2b7b23..40035cb3f 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ConfigurationTypesUI.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ConfigurationTypesUI.java @@ -41,7 +41,6 @@ * Register for the configuration types ui thats use the * net.sf.eclipsecs.ui.configtypesui extension point. * - * @author Lars Ködderitzsch */ public final class ConfigurationTypesUI { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ExternalFileConfigurationEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ExternalFileConfigurationEditor.java index 5090637e0..d73c20a73 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ExternalFileConfigurationEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ExternalFileConfigurationEditor.java @@ -53,7 +53,6 @@ * Implementation of a file based location editor. Contains a text field with * the config file path and a 'Browse...' button opening a file dialog. * - * @author Lars Ködderitzsch */ public class ExternalFileConfigurationEditor implements ICheckConfigurationEditor { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ICheckConfigurationEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ICheckConfigurationEditor.java index c39a91c45..47a117732 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ICheckConfigurationEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ICheckConfigurationEditor.java @@ -31,7 +31,6 @@ /** * Interface for the check configuration type specific location editor. * - * @author Lars Ködderitzsch */ public interface ICheckConfigurationEditor { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/InternalConfigurationEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/InternalConfigurationEditor.java index 9f282644c..38bcaafd9 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/InternalConfigurationEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/InternalConfigurationEditor.java @@ -55,7 +55,6 @@ * Implementation of a location editor to input a remote location. Contains just * a text field to input the URL. * - * @author Lars Ködderitzsch */ public class InternalConfigurationEditor implements ICheckConfigurationEditor { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ProjectConfigurationEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ProjectConfigurationEditor.java index c9ed84393..5bab7c346 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ProjectConfigurationEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ProjectConfigurationEditor.java @@ -71,7 +71,6 @@ * Implementation of a file based location editor. Contains a text field with * the config file path and a 'Browse...' button opening a file dialog. * - * @author Lars Ködderitzsch */ public class ProjectConfigurationEditor implements ICheckConfigurationEditor { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/RemoteConfigurationEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/RemoteConfigurationEditor.java index d20ef3f69..b849a11a1 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/RemoteConfigurationEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/RemoteConfigurationEditor.java @@ -47,7 +47,6 @@ * Implementation of a location editor to input a remote location. Contains just * a text field to input the URL. * - * @author Lars Ködderitzsch */ public class RemoteConfigurationEditor implements ICheckConfigurationEditor { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetMultiCheck.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetMultiCheck.java index 5ad0350e0..615a82d3c 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetMultiCheck.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetMultiCheck.java @@ -185,7 +185,6 @@ public void preferenceChange(PreferenceChangeEvent event) { /** * Label provider to translate checkstyle tokens into readable form. * - * @author Lars Ködderitzsch */ private class TokenLabelProvider extends LabelProvider { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetRegex.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetRegex.java index 2fdef5317..0c23b0c9c 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetRegex.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetRegex.java @@ -160,7 +160,6 @@ private void testRegex() { /** * Simple key listener to test the regular expression. * - * @author Lars Ködderitzsch */ private class RegexTestListener implements KeyListener { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java index 6a86f4895..3b7680b22 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java @@ -502,7 +502,6 @@ public boolean performOk() { /** * Controller for this page. * - * @author Lars Ködderitzsch */ private class PageController extends SelectionAdapter { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstyleSettingsTransfer.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstyleSettingsTransfer.java index 79566c562..f880068f8 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstyleSettingsTransfer.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstyleSettingsTransfer.java @@ -34,7 +34,6 @@ * Support for transferring internal eclipse-cs workspace settings to another * workspace. * - * @author Lars Ködderitzsch */ public class CheckstyleSettingsTransfer extends SettingsTransfer { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckConfigurationContentProvider.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckConfigurationContentProvider.java index c8fdc4252..a904573da 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckConfigurationContentProvider.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckConfigurationContentProvider.java @@ -34,7 +34,6 @@ /** * Content provider implementation that provides check configurations. * - * @author Lars Ködderitzsch */ class CheckConfigurationContentProvider implements IStructuredContentProvider { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckstylePropertyPage.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckstylePropertyPage.java index b30d31482..4ee4d0e0a 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckstylePropertyPage.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckstylePropertyPage.java @@ -84,7 +84,6 @@ /** * Property page for projects to enable checkstyle audit. * - * @author Lars Ködderitzsch */ public class CheckstylePropertyPage extends PropertyPage { @@ -535,7 +534,6 @@ public boolean performOk() { * This class works as controller for the page. It listenes for events to occur and handles the * pages context. * - * @author Lars Ködderitzsch */ private class PageController extends SelectionAdapter implements ISelectionChangedListener, ICheckStateListener, IDoubleClickListener { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/FileMatchPatternEditDialog.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/FileMatchPatternEditDialog.java index e2b5b1e26..412f5abc7 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/FileMatchPatternEditDialog.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/FileMatchPatternEditDialog.java @@ -43,8 +43,6 @@ /** * Dialog to edit file match patterns. * - * @author David Schneider - * @author Lars Ködderitzsch */ public class FileMatchPatternEditDialog extends TitleAreaDialog { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/FileSetEditDialog.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/FileSetEditDialog.java index fa811b6a5..2d626f9fa 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/FileSetEditDialog.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/FileSetEditDialog.java @@ -571,7 +571,6 @@ private List getFiles(IContainer container) throws CoreException { /** * Controller of this dialog. * - * @author Lars Ködderitzsch */ private class Controller implements SelectionListener, IDoubleClickListener, ICheckStateListener, ISelectionChangedListener { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/IFileSetsEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/IFileSetsEditor.java index a459584e8..cbbb62808 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/IFileSetsEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/IFileSetsEditor.java @@ -32,7 +32,6 @@ * Interface for the part of the checkstyle plugin properties page that * configures file sets for the project. * - * @author Lars Ködderitzsch */ public interface IFileSetsEditor { /** diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java index 18235f55b..0aa84906b 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java @@ -58,7 +58,6 @@ * Simple file sets editor producing only one file set that contains all files. Only the check * configuration can be chosen. * - * @author Lars Ködderitzsch */ public class SimpleFileSetsEditor implements IFileSetsEditor { @@ -185,7 +184,6 @@ public void refresh() { /** * Controller for this file set editor. * - * @author Lars Ködderitzsch */ private class Controller implements SelectionListener, ISelectionChangedListener { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/CheckFileOnOpenPartListener.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/CheckFileOnOpenPartListener.java index afa821a98..365e57b6e 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/CheckFileOnOpenPartListener.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/CheckFileOnOpenPartListener.java @@ -71,7 +71,6 @@ * opened file if the UnOpenedFileFilter is active. * * @see feature request - * @author Lars Ködderitzsch * @implNote To avoid the restricted access, we would need to copy 2 constants of * {@link IWorkbenchConstants}. However, by referencing those we can verify their * existence more easily by simply switching the target platform to a current version. diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/FileTypesFilterEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/FileTypesFilterEditor.java index 49240cfe6..d1177a53b 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/FileTypesFilterEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/FileTypesFilterEditor.java @@ -46,7 +46,6 @@ /** * Editor dialog for the package filter. * - * @author Lars Ködderitzsch */ public class FileTypesFilterEditor implements IFilterEditor { @@ -98,7 +97,6 @@ private List getFilterDataFromDialog() { /** * Dialog to edit file types to check. * - * @author Lars Ködderitzsch */ private class FileTypesDialog extends Dialog { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/IFilterEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/IFilterEditor.java index 98b1497f5..84afaf9b4 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/IFilterEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/IFilterEditor.java @@ -28,7 +28,6 @@ /** * Interface for a filter editor. * - * @author Lars Ködderitzsch */ public interface IFilterEditor { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PackageFilterEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PackageFilterEditor.java index b07746404..143d43b39 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PackageFilterEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PackageFilterEditor.java @@ -64,7 +64,6 @@ /** * Editor dialog for the package filter. * - * @author Lars Ködderitzsch */ public class PackageFilterEditor implements IFilterEditor { @@ -192,7 +191,6 @@ private List getFilterDataFromDialog() { /** * Content provider that provides the source folders of a project and their container members. * - * @author Lars Ködderitzsch */ private static class SourceFolderContentProvider implements ITreeContentProvider { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PluginFilterEditors.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PluginFilterEditors.java index 62c6e860f..f3cfdf685 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PluginFilterEditors.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PluginFilterEditors.java @@ -35,7 +35,6 @@ * Register for the filter editors thats use the * net.sf.eclipsecs.ui.filtereditors extension point. * - * @author Lars Ködderitzsch */ public final class PluginFilterEditors { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/AbstractASTResolution.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/AbstractASTResolution.java index 131fea62d..98af614a7 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/AbstractASTResolution.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/AbstractASTResolution.java @@ -64,8 +64,6 @@ /** * Abstract base class for marker resolutions using AST rewrite techniques. * - * @author Lars Ködderitzsch - * @author Philip Graf */ public abstract class AbstractASTResolution extends WorkbenchMarkerResolution implements ICheckstyleMarkerResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleMarkerResolutionGenerator.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleMarkerResolutionGenerator.java index 4d292bbe7..26637b071 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleMarkerResolutionGenerator.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleMarkerResolutionGenerator.java @@ -30,7 +30,6 @@ /** * Provides marker resolutions (quickfixes) for Checkstyle markers. * - * @author Lars Ködderitzsch */ public class CheckstyleMarkerResolutionGenerator implements IMarkerResolutionGenerator2 { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersAction.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersAction.java index ae480c259..30c7ceca7 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersAction.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersAction.java @@ -33,7 +33,6 @@ * This action tries to run all quickfixes for markers on a selected compilation * unit. * - * @author Lars Ködderitzsch */ public class FixCheckstyleMarkersAction implements IObjectActionDelegate { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersHandler.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersHandler.java index 1b0720b3f..908e34288 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersHandler.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersHandler.java @@ -37,7 +37,6 @@ * Command handler to enable key-binding support for the "Apply Checkstyle * fixes" action. * - * @author Lars Ködderitzsch */ public class FixCheckstyleMarkersHandler extends AbstractHandler { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersJob.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersJob.java index 905c9e86a..12a622025 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersJob.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/FixCheckstyleMarkersJob.java @@ -36,7 +36,6 @@ /** * Job implementation that tries to fix all Checkstyle markers in a file. * - * @author Lars Ködderitzsch */ public class FixCheckstyleMarkersJob extends UIJob { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/ICheckstyleMarkerResolution.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/ICheckstyleMarkerResolution.java index 8b9497e9d..260e7c25f 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/ICheckstyleMarkerResolution.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/ICheckstyleMarkerResolution.java @@ -26,7 +26,6 @@ /** * Interface for a quickfix implementation for checkstyle markers. * - * @author Lars Ködderitzsch */ public interface ICheckstyleMarkerResolution extends IMarkerResolution2 { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksQuickfix.java index 456ed7868..d2375a92e 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksQuickfix.java @@ -36,7 +36,6 @@ /** * Quickfix implementation that removes nested blocks. * - * @author Lars Ködderitzsch */ public class AvoidNestedBlocksQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesQuickfix.java index 9cda54820..5f56bc4c8 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesQuickfix.java @@ -39,7 +39,6 @@ /** * Quickfix implementation that adds braces to if/for/while/do statements. * - * @author Lars Ködderitzsch */ public class NeedBracesQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastQuickfix.java index 28116dc25..ff1e0c231 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastQuickfix.java @@ -38,7 +38,6 @@ * Quickfix implementation that moves the default case of a switch statement to * the last position. * - * @author Lars Ködderitzsch */ public class DefaultComesLastQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementQuickfix.java index a78a2322c..a8233b1eb 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementQuickfix.java @@ -35,7 +35,6 @@ * Quickfix implementation that removes an empty statement (unneccessary * semicolon). * - * @author Lars Ködderitzsch */ public class EmptyStatementQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationQuickfix.java index 0e81a2a64..4dc6e9268 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationQuickfix.java @@ -42,7 +42,6 @@ * Quickfix implementation which removes the explicit default initialization of * a class or object member. * - * @author Philip Graf */ public class ExplicitInitializationQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableQuickfix.java index 1b7a2d9c7..caa57bf7d 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableQuickfix.java @@ -36,8 +36,6 @@ * Quickfix implementation which adds final modifiers to parameters in method * declarations. * - * @author Levon Saldamli - * @author Lars Ködderitzsch */ public class FinalLocalVariableQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultQuickfix.java index 49e8b46c8..e6482638b 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultQuickfix.java @@ -34,7 +34,6 @@ * Quickfix implementation that add a missing default statement to a switch * case. * - * @author Levon Saldamli */ public class MissingSwitchDefaultQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisQuickfix.java index 72acaaba5..608c3b5d1 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisQuickfix.java @@ -45,7 +45,6 @@ * Quickfix implementation which adds the this qualifier to a field * access or method invocation. * - * @author Philip Graf */ public class RequireThisQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java index f4adb0780..bb980e6d2 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java @@ -64,7 +64,6 @@ * return condition; * * - * @author Philip Graf */ public class SimplifyBooleanReturnQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityQuickfix.java index 75bda04c6..42bf823c3 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityQuickfix.java @@ -43,7 +43,6 @@ * Quickfix implementation that replaces a string literal comparison using == or * != with a proper equals() comparison. * - * @author Lars Ködderitzsch */ public class StringLiteralEqualityQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionQuickfix.java index d9e41e09d..498885fe9 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionQuickfix.java @@ -38,8 +38,6 @@ /** * Quickfix implementation which adds the final modifiers a method declaration. * - * @author Levon Saldamli - * @author Lars Ködderitzsch */ public class DesignForExtensionQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/design/FinalClassQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/design/FinalClassQuickfix.java index 7eb32c106..0eecaaec9 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/design/FinalClassQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/design/FinalClassQuickfix.java @@ -37,8 +37,6 @@ /** * Quickfix implementation which adds the final modifiers a method declaration. * - * @author Levon Saldamli - * @author Lars Ködderitzsch */ public class FinalClassQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleQuickfix.java index b85df78d0..132ec3b3a 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleQuickfix.java @@ -42,7 +42,6 @@ * Quickfix implementation which moves the array declaration (C-style to * Java-style and reverse). * - * @author Lars Ködderitzsch */ public class ArrayTypeStyleQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersQuickfix.java index eff7ba0b5..cebc08ead 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersQuickfix.java @@ -35,8 +35,6 @@ * Quickfix implementation which adds final modifiers to parameters in method * declarations. * - * @author Levon Saldamli - * @author Lars Ködderitzsch */ public class FinalParametersQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainQuickfix.java index 1f3e85f08..a86cc1c09 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainQuickfix.java @@ -33,7 +33,6 @@ * Quickfix implementation which removes uncommented main methods (debugging leftovers) from the * code. * - * @author Lars Ködderitzsch */ public class UncommentedMainQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllQuickfix.java index 32338790d..c65a50dd7 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllQuickfix.java @@ -33,7 +33,6 @@ * Quickfix implementation which changes lowercase 'l' occurrances in long * literals into uppercase 'L' to enchance readability. * - * @author Lars Ködderitzsch */ public class UpperEllQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderQuickfix.java index 19b938c82..64314f75e 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderQuickfix.java @@ -47,7 +47,6 @@ /** * Quickfix implementation that orders modifiers into the suggested order by the JLS. * - * @author Lars Ködderitzsch */ public class ModifierOrderQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierQuickfix.java index 40dcd9763..9b3390e50 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierQuickfix.java @@ -44,7 +44,6 @@ /** * Quickfix implementation that removes redundant modifiers. * - * @author Lars Ködderitzsch */ public class RedundantModifierQuickfix extends AbstractASTResolution { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/Messages.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/Messages.java index 185325e72..3d88bb453 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/Messages.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/Messages.java @@ -25,7 +25,6 @@ /** * Class used for i18n. * - * @author Fabrice BELLINGARD */ public final class Messages extends NLS { // CHECKSTYLE:OFF diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/CreateStatsJob.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/CreateStatsJob.java index cdd0b2c91..75c38e3a6 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/CreateStatsJob.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/CreateStatsJob.java @@ -44,7 +44,6 @@ /** * Job implementation that builds the data objects for the statistic views. * - * @author Lars Ködderitzsch */ public class CreateStatsJob extends Job { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/MarkerStat.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/MarkerStat.java index dd6fdc984..f62ac2ddc 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/MarkerStat.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/MarkerStat.java @@ -29,7 +29,6 @@ /** * Objet qui donne des statistiques sur les marqueurs. * - * @author Fabrice BELLINGARD */ public class MarkerStat implements Comparable { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/Stats.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/Stats.java index 5a0836e5d..ac688da07 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/Stats.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/data/Stats.java @@ -26,7 +26,6 @@ * Classe qui véhicule les statistiques Checkstyle. Elle contient notamment la * liste des différentes erreurs avec leur comptage. * - * @author Fabrice BELLINGARD */ public class Stats { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/AbstractStatsView.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/AbstractStatsView.java index c63b5448f..156ea1181 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/AbstractStatsView.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/AbstractStatsView.java @@ -68,8 +68,6 @@ /** * Abstract view that gathers common behaviour for the stats views. * - * @author Fabrice BELLINGARD - * @author Lars Ködderitzsch */ public abstract class AbstractStatsView extends ViewPart { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilter.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilter.java index c6d65ff67..a0ff650a5 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilter.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilter.java @@ -43,7 +43,6 @@ /** * Filter class for Checkstyle markers. This filter is used by the Checkstyle statistics views. * - * @author Lars Ködderitzsch */ public class CheckstyleMarkerFilter implements Cloneable { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilterDialog.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilterDialog.java index 0a968d49c..911623d65 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilterDialog.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilterDialog.java @@ -56,7 +56,6 @@ /** * Dialog to edit the marker filter. * - * @author Lars Ködderitzsch */ public class CheckstyleMarkerFilterDialog extends TitleAreaDialog { @@ -397,7 +396,6 @@ private void initRegexLabel() { /** * The controller for this dialog. * - * @author Lars Ködderitzsch */ private class PageController implements SelectionListener { @@ -472,7 +470,6 @@ private void updateControlState() { /** * Dialog to edit regular expressions to filter by. * - * @author Lars Ködderitzsch */ private class RegexDialog extends TitleAreaDialog { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/FiltersAction.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/FiltersAction.java index 3d5b9afb5..7f1bb0957 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/FiltersAction.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/FiltersAction.java @@ -29,7 +29,6 @@ /** * Action implementation for the filters action. * - * @author Lars Ködderitzsch */ public class FiltersAction extends Action { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/SWTUtil.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/SWTUtil.java index 4f02169af..68387d3bb 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/SWTUtil.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/SWTUtil.java @@ -50,7 +50,6 @@ /** * Some widely used helper funktionality regarding SWT shortcomings. * - * @author Lars Ködderitzsch */ public final class SWTUtil { @@ -106,7 +105,6 @@ public static void addResizeSupport(Dialog dialog, IDialogSettings settings, Str /** * Listener that adds tooltip-on-press support. * - * @author Lars Ködderitzsch */ private static final class TooltipOnPressListener extends MouseAdapter implements MouseTrackListener { @@ -157,7 +155,6 @@ public void mouseHover(MouseEvent e) { /** * Verifier that allows only digits to be input. * - * @author Lars Ködderitzsch */ private static final class OnlyDigitsVerifyListener implements VerifyListener { @@ -191,7 +188,6 @@ public void verifyText(VerifyEvent e) { /** * Listener that adds resize support ((re)storing of size and location information). * - * @author Lars Ködderitzsch */ private static final class ShellResizeSupportListener extends ShellAdapter implements ControlListener, DisposeListener { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedTableViewer.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedTableViewer.java index 1cb86b03a..f8a742eee 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedTableViewer.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedTableViewer.java @@ -42,7 +42,6 @@ * This subclass of TableViewer adds easier sorting support and * support for storing table settings (column width, sorter state). * - * @author Lars Ködderitzsch */ public class EnhancedTableViewer extends TableViewer { // @@ -312,7 +311,6 @@ public void run() { /** * Listener for header clicks and resize events. * - * @author Lars Ködderitzsch */ private class TableListener implements SelectionListener, ControlListener { @@ -360,7 +358,6 @@ public void controlMoved(ControlEvent e) { * Sorter implementation that uses the values provided by the comparable * provider to sort the table. * - * @author Lars Ködderitzsch */ private class TableSorter extends ViewerComparator { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/ITableComparableProvider.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/ITableComparableProvider.java index 011539d10..b889f52f1 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/ITableComparableProvider.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/ITableComparableProvider.java @@ -26,7 +26,6 @@ * ITableLabelProvider except that other comparable objects than Strings can be * returned. * - * @author Lars Ködderitzsch */ public interface ITableComparableProvider { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/ITableSettingsProvider.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/ITableSettingsProvider.java index 396fcd114..9fe164651 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/ITableSettingsProvider.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/ITableSettingsProvider.java @@ -26,7 +26,6 @@ * Interface for implementations that provide settings where the * EnhancedTableViewer can store its current state. * - * @author Lars Ködderitzsch */ public interface ITableSettingsProvider { From ebd5a7e1edc6587348be67c1e0f7856247da0386 Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 16:22:06 +0100 Subject: [PATCH 03/12] refactor: org.openrewrite.staticanalysis.EqualsAvoidsNull --- .../core/config/ConfigurationReader.java | 4 +- .../core/config/ConfigurationWriter.java | 2 +- .../core/config/meta/MetadataFactory.java | 4 +- .../FinalLocalVariableTransformer.java | 4 +- .../IndentationTransformer.java | 4 +- .../LeftCurlyTransformer.java | 22 +++++----- .../MethodParamPadTransformer.java | 6 +-- .../NoWhitespaceAfterTransformer.java | 8 ++-- .../ParenPadTransformer.java | 10 ++--- .../RightCurlyTransformer.java | 8 ++-- .../TypecastParenPadTransformer.java | 2 +- .../WhitespaceAfterTransformer.java | 4 +- .../WhitespaceAroundTransformer.java | 40 +++++++++---------- 13 files changed, 59 insertions(+), 59 deletions(-) diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java index ad283bf91..a9c720d20 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java @@ -200,14 +200,14 @@ private static void addProperties(final Element moduleEl, final Module module) { final boolean isPropertyRef = (value != null) && PROPERTY_REF_PATTERN.matcher(value).matches(); - if (name.equals(XMLTags.SEVERITY_TAG) && (module.getMetaData() != null) + if (XMLTags.SEVERITY_TAG.equals(name) && (module.getMetaData() != null) && module.getMetaData().hasSeverity()) { try { module.setSeverity(Severity.valueOf(value)); } catch (final IllegalArgumentException ex) { module.setSeverity(Severity.inherit); } - } else if (name.equals(XMLTags.ID_TAG)) { + } else if (XMLTags.ID_TAG.equals(name)) { module.setId(Strings.emptyToNull(value)); } else if (module.getMetaData() != null) { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java index 6bc3332eb..581b3638e 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java @@ -239,7 +239,7 @@ private static List getChildModules(Module module, List remainin String childParent = tmp.getMetaData().getParentModule(); // only the checker module has no parent - if (parentInternalName == null && childParent.equals("Root")) { + if (parentInternalName == null && "Root".equals(childParent)) { childModules.add(tmp); } else if (childParent.equals(parentInternalName)) { childModules.add(tmp); diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java index e0afdfa00..b628ac9f5 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java @@ -220,9 +220,9 @@ private static ConfigPropertyMetadata createPropertyConfig(ModuleDetails moduleD if (sPropertyTypeMap.get(propertyType) != null) { String validationType = modulePropertyDetails.getValidationType(); if (validationType != null) { - if (validationType.equals(TYPE_ID_PATTERN)) { + if (TYPE_ID_PATTERN.equals(validationType)) { dataType = ConfigPropertyType.Regex; - } else if (validationType.equals("tokenSet") || validationType.equals("tokenTypesSet")) { + } else if ("tokenSet".equals(validationType) || "tokenTypesSet".equals(validationType)) { dataType = ConfigPropertyType.MultiCheck; } } else { diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalLocalVariableTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalLocalVariableTransformer.java index 2bf3fe0e4..cb24b9332 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalLocalVariableTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/FinalLocalVariableTransformer.java @@ -42,10 +42,10 @@ public FormatterConfiguration transformRule() { String token; while (args.hasMoreTokens()) { token = args.nextToken(); - if (token.equals("VARIABLE_DEF")) { + if ("VARIABLE_DEF".equals(token)) { useCleanupSetting("make_local_variable_final", "true"); useCleanupSetting("make_private_fields_final", "true"); - } else if (token.equals("PARAMETER_DEF")) { + } else if ("PARAMETER_DEF".equals(token)) { useCleanupSetting("make_parameters_final", "true"); } } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/IndentationTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/IndentationTransformer.java index 9f9e9800a..cb40220ac 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/IndentationTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/IndentationTransformer.java @@ -46,9 +46,9 @@ public FormatterConfiguration transformRule() { val = "4"; } - if (val.equals("4")) { + if ("4".equals(val)) { userFormatterSetting("indent_switchstatements_compare_to_switch", "true"); - } else if (val.equals("0")) { + } else if ("0".equals(val)) { userFormatterSetting("indent_switchstatements_compare_to_switch", "false"); } return getFormatterSetting(); diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LeftCurlyTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LeftCurlyTransformer.java index ca9fb58f1..7a29d8062 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LeftCurlyTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/LeftCurlyTransformer.java @@ -45,33 +45,33 @@ public FormatterConfiguration transformRule() { if (option == null) { option = "eol"; } - if (option.equals("eol")) { + if ("eol".equals(option)) { option = "end_of_line"; - } else if (option.equals("nl") || option.equals("nlow")) { + } else if ("nl".equals(option) || "nlow".equals(option)) { option = "next_line"; } while (token.hasMoreTokens()) { tok = token.nextToken(); - if (tok.equals("CLASS_DEF")) { + if ("CLASS_DEF".equals(tok)) { userFormatterSetting("brace_position_for_anonymous_type_declaration", option); userFormatterSetting("brace_position_for_enum_constant", option); userFormatterSetting("brace_position_for_enum_declaration", option); userFormatterSetting("brace_position_for_type_declaration", option); userFormatterSetting("brace_position_for_annotation_type_declaration", option); - } else if (tok.equals("INTERFACE_DEF")) { + } else if ("INTERFACE_DEF".equals(tok)) { userFormatterSetting("brace_position_for_annotation_type_declaration", option); userFormatterSetting("brace_position_for_type_declaration", option); - } else if (tok.equals("CTOR_DEF")) { + } else if ("CTOR_DEF".equals(tok)) { userFormatterSetting("brace_position_for_constructor_declaration", option); - } else if (tok.equals("METHOD_DEF")) { + } else if ("METHOD_DEF".equals(tok)) { userFormatterSetting("brace_position_for_method_declaration", option); - } else if (tok.equals("LITERAL_DO") || tok.equals("LITERAL_ELSE") || tok.equals("LITERAL_FOR") - || tok.equals("LITERAL_IF") || tok.equals("LITERAL_WHILE") - || tok.equals("LITERAL_CATCH") || tok.equals("LITERAL_FINALLY") - || tok.equals("LITERAL_TRY")) { + } else if ("LITERAL_DO".equals(tok) || "LITERAL_ELSE".equals(tok) || "LITERAL_FOR".equals(tok) + || "LITERAL_IF".equals(tok) || "LITERAL_WHILE".equals(tok) + || "LITERAL_CATCH".equals(tok) || "LITERAL_FINALLY".equals(tok) + || "LITERAL_TRY".equals(tok)) { userFormatterSetting("brace_position_for_block", option); - } else if (tok.equals("LITERAL_SWITCH")) { + } else if ("LITERAL_SWITCH".equals(tok)) { userFormatterSetting("brace_position_for_switch", option); } } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MethodParamPadTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MethodParamPadTransformer.java index 183610822..53174ee68 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MethodParamPadTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/MethodParamPadTransformer.java @@ -43,13 +43,13 @@ public FormatterConfiguration transformRule() { String token; while (args.hasMoreTokens()) { token = args.nextToken(); - if (token.equals("CTOR_DEF")) { + if ("CTOR_DEF".equals(token)) { userFormatterSetting("insert_space_before_opening_paren_in_constructor_declaration", "do not insert"); - } else if (token.equals("METHOD_CALL") || token.equals("SUPER_CTOR_CALL")) { + } else if ("METHOD_CALL".equals(token) || "SUPER_CTOR_CALL".equals(token)) { userFormatterSetting("insert_space_before_opening_paren_in_method_invocation", "do not insert"); - } else if (token.equals("METHOD_DEF")) { + } else if ("METHOD_DEF".equals(token)) { userFormatterSetting("insert_space_before_opening_paren_in_method_declaration", "do not insert"); } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceAfterTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceAfterTransformer.java index 443e8b93a..a4580c93b 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceAfterTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/NoWhitespaceAfterTransformer.java @@ -44,12 +44,12 @@ public FormatterConfiguration transformRule() { // TODO tokens DOT ARRAY_INIT while (args.hasMoreTokens()) { token = args.nextToken(); - if (token.equals("DEC") || token.equals("INC")) { + if ("DEC".equals(token) || "INC".equals(token)) { userFormatterSetting("insert_space_after_prefix_operator", "do not insert"); - } else if (token.equals("UNARY_MINUS") || token.equals("LNOT") || token.equals("UNARY_PLUS") - || token.equals("BNOT")) { + } else if ("UNARY_MINUS".equals(token) || "LNOT".equals(token) || "UNARY_PLUS".equals(token) + || "BNOT".equals(token)) { userFormatterSetting("insert_space_after_unary_operator", "do not insert"); - } else if (token.equals("TYPECAST")) { + } else if ("TYPECAST".equals(token)) { userFormatterSetting("insert_space_after_closing_paren_in_cast", "do not insert"); } } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/ParenPadTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/ParenPadTransformer.java index 9a372825b..c73cae760 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/ParenPadTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/ParenPadTransformer.java @@ -41,7 +41,7 @@ public FormatterConfiguration transformRule() { if (option == null) { option = "nospace"; } - if (option.equals("nospace")) { + if ("nospace".equals(option)) { option = "do not insert"; } else { option = "insert"; @@ -51,7 +51,7 @@ public FormatterConfiguration transformRule() { String token; while (tokens.hasMoreTokens()) { token = tokens.nextToken(); - if (token.equals("LPAREN")) { + if ("LPAREN".equals(token)) { userFormatterSetting("insert_space_after_opening_paren_in_parenthesized_expression", option); userFormatterSetting("insert_space_after_opening_paren_in_while", option); @@ -65,7 +65,7 @@ public FormatterConfiguration transformRule() { userFormatterSetting("insert_space_after_opening_paren_in_constructor_declaration", option); userFormatterSetting("insert_space_after_opening_paren_in_enum_constant", option); userFormatterSetting("insert_space_after_opening_paren_in_method_declaration", option); - } else if (token.equals("RPAREN")) { + } else if ("RPAREN".equals(token)) { userFormatterSetting("insert_space_before_closing_paren_in_parenthesized_expression", option); userFormatterSetting("insert_space_before_closing_paren_in_while", option); @@ -80,8 +80,8 @@ public FormatterConfiguration transformRule() { option); userFormatterSetting("insert_space_before_closing_paren_in_enum_constant", option); userFormatterSetting("insert_space_before_closing_paren_in_annotation", option); - } else if (token.equals("CTOR_CALL") || token.equals("METHOD_CALL") - || token.equals("SUPER_CTOR_CALL")) { + } else if ("CTOR_CALL".equals(token) || "METHOD_CALL".equals(token) + || "SUPER_CTOR_CALL".equals(token)) { userFormatterSetting("insert_space_before_closing_paren_in_method_invocation", option); userFormatterSetting("insert_space_after_opening_paren_in_method_invocation", option); } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RightCurlyTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RightCurlyTransformer.java index a0677179f..1dd402b5b 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RightCurlyTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/RightCurlyTransformer.java @@ -46,7 +46,7 @@ public FormatterConfiguration transformRule() { if (option == null) { option = "same"; } - if (option.equals("same")) { + if ("same".equals(option)) { option = "do not insert"; } else { option = "insert"; @@ -54,11 +54,11 @@ public FormatterConfiguration transformRule() { while (token.hasMoreTokens()) { tok = token.nextToken(); - if (tok.equals("LITERAL_CATCH")) { + if ("LITERAL_CATCH".equals(tok)) { userFormatterSetting("insert_new_line_before_catch_in_try_statement", option); - } else if (tok.equals("LITERAL_FINALLY")) { + } else if ("LITERAL_FINALLY".equals(tok)) { userFormatterSetting("insert_new_line_before_finally_in_try_statement", option); - } else if (tok.equals("LITERAL_ELSE")) { + } else if ("LITERAL_ELSE".equals(tok)) { userFormatterSetting("insert_new_line_before_else_in_if_statement", option); } } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TypecastParenPadTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TypecastParenPadTransformer.java index fd0f399e7..d8bbc3c65 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TypecastParenPadTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/TypecastParenPadTransformer.java @@ -36,7 +36,7 @@ public FormatterConfiguration transformRule() { if (option == null) { option = "nospace"; } - if (option.equals("space")) { + if ("space".equals(option)) { option = "insert"; } else { option = "do not insert"; diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAfterTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAfterTransformer.java index e62604d2b..e664b7679 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAfterTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAfterTransformer.java @@ -44,7 +44,7 @@ public FormatterConfiguration transformRule() { while (token.hasMoreTokens()) { tok = token.nextToken(); - if (tok.equals("COMMA")) { + if ("COMMA".equals(tok)) { userFormatterSetting("insert_space_after_comma_in_annotation", "insert"); userFormatterSetting("insert_space_after_comma_in_type_arguments", "insert"); userFormatterSetting("insert_space_after_comma_in_type_parameters", "insert"); @@ -67,7 +67,7 @@ public FormatterConfiguration transformRule() { userFormatterSetting("insert_space_after_comma_in_parameterized_type_reference", "insert"); userFormatterSetting("insert_space_after_comma_in_method_invocation_arguments", "insert"); userFormatterSetting("insert_space_after_comma_in_multiple_local_declarations", "insert"); - } else if (tok.equals("TYPECAST")) { + } else if ("TYPECAST".equals(tok)) { userFormatterSetting("insert_space_after_closing_paren_in_cast", "insert"); } } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAroundTransformer.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAroundTransformer.java index ca752a7ae..246b61f85 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAroundTransformer.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/ctransformerclasses/WhitespaceAroundTransformer.java @@ -49,29 +49,29 @@ public FormatterConfiguration transformRule() { while (token.hasMoreTokens()) { tok = token.nextToken(); - if (tok.equals("ASSIGN") || tok.equals("BAND_ASSIGN") || tok.equals("BOR_ASSIGN") - || tok.equals("BSR_ASSIGN") || tok.equals("BXOR_ASSIGN") || tok.equals("DIV_ASSIGN") - || tok.equals("MINUS_ASSIGN") || tok.equals("MOD_ASSIGN") || tok.equals("PLUS_ASSIGN") - || tok.equals("SL_ASSIGN") || tok.equals("SR_ASSIGN") || tok.equals("STAR_ASSIGN")) { + if ("ASSIGN".equals(tok) || "BAND_ASSIGN".equals(tok) || "BOR_ASSIGN".equals(tok) + || "BSR_ASSIGN".equals(tok) || "BXOR_ASSIGN".equals(tok) || "DIV_ASSIGN".equals(tok) + || "MINUS_ASSIGN".equals(tok) || "MOD_ASSIGN".equals(tok) || "PLUS_ASSIGN".equals(tok) + || "SL_ASSIGN".equals(tok) || "SR_ASSIGN".equals(tok) || "STAR_ASSIGN".equals(tok)) { userFormatterSetting("insert_space_after_assignment_operator", "insert"); userFormatterSetting("insert_space_before_assignment_operator", "insert"); - } else if ((tok.equals("BAND") || tok.equals("BOR") || tok.equals("BSR") || tok.equals("BXOR") - || tok.equals("DIV") || tok.equals("EQUAL") || tok.equals("GE") || tok.equals("GT") - || tok.equals("LAND") || tok.equals("LE") || tok.equals("LOR") || tok.equals("LT") - || tok.equals("MINUS") || tok.equals("MOD") || tok.equals("NOT_EQUAL") - || tok.equals("PLUS") || tok.equals("SL") || tok.equals("SR") - || tok.equals("STAR"))) { + } else if (("BAND".equals(tok) || "BOR".equals(tok) || "BSR".equals(tok) || "BXOR".equals(tok) + || "DIV".equals(tok) || "EQUAL".equals(tok) || "GE".equals(tok) || "GT".equals(tok) + || "LAND".equals(tok) || "LE".equals(tok) || "LOR".equals(tok) || "LT".equals(tok) + || "MINUS".equals(tok) || "MOD".equals(tok) || "NOT_EQUAL".equals(tok) + || "PLUS".equals(tok) || "SL".equals(tok) || "SR".equals(tok) + || "STAR".equals(tok))) { userFormatterSetting("insert_space_after_binary_operator", "insert"); userFormatterSetting("insert_space_before_binary_operator", "insert"); - } else if (tok.equals("COLON")) { + } else if ("COLON".equals(tok)) { userFormatterSetting("insert_space_before_colon_in_for", "insert"); userFormatterSetting("insert_space_after_colon_in_for", "insert"); userFormatterSetting("insert_space_before_colon_in_conditional", "insert"); userFormatterSetting("insert_space_after_colon_in_conditional", "insert"); - } else if (tok.equals("QUESTION")) { + } else if ("QUESTION".equals(tok)) { userFormatterSetting("insert_space_after_question_in_conditional", "insert"); userFormatterSetting("insert_space_before_question_in_conditional", "insert"); - } else if (tok.equals("LCURLY")) { + } else if ("LCURLY".equals(tok)) { userFormatterSetting("insert_space_before_opening_brace_in_type_declaration", "insert"); userFormatterSetting("insert_space_after_opening_brace_in_array_initializer", "insert"); userFormatterSetting("insert_space_before_opening_brace_in_annotation_type_declaration", @@ -86,20 +86,20 @@ public FormatterConfiguration transformRule() { userFormatterSetting("insert_space_before_opening_brace_in_anonymous_type_declaration", "insert"); userFormatterSetting("insert_space_before_opening_brace_in_array_initializer", "insert"); - } else if (tok.equals("RCURLY")) { + } else if ("RCURLY".equals(tok)) { userFormatterSetting("insert_space_after_closing_brace_in_block", "insert"); userFormatterSetting("insert_space_before_closing_brace_in_array_initializer", "insert"); - } else if (tok.equals("LITERAL_CATCH")) { + } else if ("LITERAL_CATCH".equals(tok)) { userFormatterSetting("insert_space_before_opening_paren_in_catch", "insert"); - } else if (tok.equals("LITERAL_FOR")) { + } else if ("LITERAL_FOR".equals(tok)) { userFormatterSetting("insert_space_before_opening_paren_in_for", "insert"); - } else if (tok.equals("LITERAL_IF")) { + } else if ("LITERAL_IF".equals(tok)) { userFormatterSetting("insert_space_before_opening_paren_in_if", "insert"); - } else if (tok.equals("LITERAL_RETURN")) { + } else if ("LITERAL_RETURN".equals(tok)) { userFormatterSetting("insert_space_before_parenthesized_expression_in_return", "insert"); - } else if (tok.equals("LITERAL_SYNCHRONIZED")) { + } else if ("LITERAL_SYNCHRONIZED".equals(tok)) { userFormatterSetting("insert_space_before_opening_paren_in_synchronized", "insert"); - } else if (tok.equals("LITERAL_WHILE")) { + } else if ("LITERAL_WHILE".equals(tok)) { userFormatterSetting("insert_space_before_opening_paren_in_while", "insert"); } } From 7f906666284a8f2940b6c9a608e9143c2c31bbbe Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 16:35:24 +0100 Subject: [PATCH 04/12] refactor: org.openrewrite.java.testing.cleanup.RemoveTestPrefix --- .../sf/eclipsecs/checkstyle/ChecksTest.java | 2 +- .../blocks/AvoidNestedBlocksTest.java | 2 +- .../ui/quickfixes/blocks/NeedBracesTest.java | 12 +++++----- .../coding/DefaultComesLastTest.java | 4 ++-- .../quickfixes/coding/EmptyStatementTest.java | 4 ++-- .../coding/ExplicitInitializationTest.java | 2 +- .../coding/FinalLocalVariableTest.java | 2 +- .../coding/MissingSwitchDefaultTest.java | 4 ++-- .../ui/quickfixes/coding/RequireThisTest.java | 18 +++++++------- .../coding/SimplifyBooleanReturnTest.java | 24 +++++++++---------- .../coding/StringLiteralEqualityTest.java | 2 +- .../design/DesignForExtensionTest.java | 2 +- .../ui/quickfixes/design/FinalClassTest.java | 2 +- .../quickfixes/misc/ArrayTypeStyleTest.java | 6 ++--- .../quickfixes/misc/FinalParametersTest.java | 2 +- .../quickfixes/misc/UncommentedMainTest.java | 2 +- .../ui/quickfixes/misc/UpperEllTest.java | 2 +- .../modifier/ModifierOrderTest.java | 2 +- .../modifier/RedundantModifierTest.java | 2 +- 19 files changed, 48 insertions(+), 48 deletions(-) diff --git a/net.sf.eclipsecs.checkstyle/test/net/sf/eclipsecs/checkstyle/ChecksTest.java b/net.sf.eclipsecs.checkstyle/test/net/sf/eclipsecs/checkstyle/ChecksTest.java index e87ec9965..fc683ac96 100644 --- a/net.sf.eclipsecs.checkstyle/test/net/sf/eclipsecs/checkstyle/ChecksTest.java +++ b/net.sf.eclipsecs.checkstyle/test/net/sf/eclipsecs/checkstyle/ChecksTest.java @@ -46,7 +46,7 @@ public class ChecksTest { @Test - public void testMetadataFiles() throws Exception { + public void metadataFiles() throws Exception { final Set> modules = new HashSet<>(CheckUtil.getCheckstyleModules()); // don't test root modules diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksTest.java index 509bf9705..efec2c729 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksTest.java @@ -27,7 +27,7 @@ public class AvoidNestedBlocksTest extends AbstractQuickfixTestCase { @Test - public void testAvoidNestedBlocks() throws Exception { + public void avoidNestedBlocks() throws Exception { testQuickfix("AvoidNestedBlocksInput.xml", new AvoidNestedBlocksQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesTest.java index 202292d03..3b01e35d2 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesTest.java @@ -27,32 +27,32 @@ public class NeedBracesTest extends AbstractQuickfixTestCase { @Test - public void testNeedBracesIf() throws Exception { + public void needBracesIf() throws Exception { testQuickfix("NeedBracesInputIf.xml", new NeedBracesQuickfix()); } @Test - public void testNeedBracesElse() throws Exception { + public void needBracesElse() throws Exception { testQuickfix("NeedBracesInputElse.xml", new NeedBracesQuickfix()); } @Test - public void testNeedBracesElseIf() throws Exception { + public void needBracesElseIf() throws Exception { testQuickfix("NeedBracesInputElseIf.xml", new NeedBracesQuickfix()); } @Test - public void testNeedBracesFor() throws Exception { + public void needBracesFor() throws Exception { testQuickfix("NeedBracesInputFor.xml", new NeedBracesQuickfix()); } @Test - public void testNeedBracesWhile() throws Exception { + public void needBracesWhile() throws Exception { testQuickfix("NeedBracesInputWhile.xml", new NeedBracesQuickfix()); } @Test - public void testNeedBracesDoWhile() throws Exception { + public void needBracesDoWhile() throws Exception { testQuickfix("NeedBracesInputDoWhile.xml", new NeedBracesQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastTest.java index 35f0c0303..bff7bec67 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastTest.java @@ -27,12 +27,12 @@ public class DefaultComesLastTest extends AbstractQuickfixTestCase { @Test - public void testDefaultComesLast() throws Exception { + public void defaultComesLast() throws Exception { testQuickfix("DefaultComesLastInput.xml", new DefaultComesLastQuickfix()); } @Test - public void testDefaultComesLastInner() throws Exception { + public void defaultComesLastInner() throws Exception { testQuickfix("DefaultComesLastInputInner.xml", new DefaultComesLastQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementTest.java index f6cc6a731..d509d17a3 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementTest.java @@ -27,12 +27,12 @@ public class EmptyStatementTest extends AbstractQuickfixTestCase { @Test - public void testEmptyStatement() throws Exception { + public void emptyStatement() throws Exception { testQuickfix("EmptyStatementInput.xml", new EmptyStatementQuickfix()); } @Test - public void testEmptyStatementNeg() throws Exception { + public void emptyStatementNeg() throws Exception { testQuickfix("EmptyStatementInputNeg.xml", new EmptyStatementQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationTest.java index 9fd9d8050..9dc75a3aa 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationTest.java @@ -27,7 +27,7 @@ public class ExplicitInitializationTest extends AbstractQuickfixTestCase { @Test - public void testExplicitInitialization() throws Exception { + public void explicitInitialization() throws Exception { testQuickfix("ExplicitInitialization.xml", new ExplicitInitializationQuickfix()); } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableTest.java index 1c0ef67ad..2552225b8 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableTest.java @@ -27,7 +27,7 @@ public class FinalLocalVariableTest extends AbstractQuickfixTestCase { @Test - public void testFinalLocalVariable() throws Exception { + public void finalLocalVariable() throws Exception { testQuickfix("FinalLocalVariableInput.xml", new FinalLocalVariableQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultTest.java index dcc7100a7..64a67be5b 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultTest.java @@ -27,12 +27,12 @@ public class MissingSwitchDefaultTest extends AbstractQuickfixTestCase { @Test - public void testMissingSwitchDefault() throws Exception { + public void missingSwitchDefault() throws Exception { testQuickfix("MissingSwitchDefaultInput.xml", new MissingSwitchDefaultQuickfix()); } @Test - public void testMissingSwitchDefaultInner() throws Exception { + public void missingSwitchDefaultInner() throws Exception { testQuickfix("MissingSwitchDefaultInputInner.xml", new MissingSwitchDefaultQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisTest.java index a837beb43..26831076d 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisTest.java @@ -27,47 +27,47 @@ public class RequireThisTest extends AbstractQuickfixTestCase { @Test - public void testRequireThisFieldAccessAssignmentLHS() throws Exception { + public void requireThisFieldAccessAssignmentLHS() throws Exception { testQuickfix("RequireThisFieldAccessAssignmentLHS.xml", new RequireThisQuickfix()); } @Test - public void testRequireThisFieldAccessAssignmentRHS() throws Exception { + public void requireThisFieldAccessAssignmentRHS() throws Exception { testQuickfix("RequireThisFieldAccessAssignmentRHS.xml", new RequireThisQuickfix()); } @Test - public void testRequireThisFieldAccessArrayInitializer() throws Exception { + public void requireThisFieldAccessArrayInitializer() throws Exception { testQuickfix("RequireThisFieldAccessArrayInitializer.xml", new RequireThisQuickfix()); } @Test - public void testRequireThisFieldAccessInnerClass() throws Exception { + public void requireThisFieldAccessInnerClass() throws Exception { testQuickfix("RequireThisFieldAccessInnerClass.xml", new RequireThisQuickfix()); } @Test - public void testRequireThisMethodInvocation() throws Exception { + public void requireThisMethodInvocation() throws Exception { testQuickfix("RequireThisMethodInvocation.xml", new RequireThisQuickfix()); } @Test - public void testRequireThisMethodInvocationWithParam() throws Exception { + public void requireThisMethodInvocationWithParam() throws Exception { testQuickfix("RequireThisMethodInvocationWithParam.xml", new RequireThisQuickfix()); } @Test - public void testRequireThisMethodInvocationAssignmentRHS() throws Exception { + public void requireThisMethodInvocationAssignmentRHS() throws Exception { testQuickfix("RequireThisMethodInvocationAssignmentRHS.xml", new RequireThisQuickfix()); } @Test - public void testRequireThisMethodInvocationArrayInitializer() throws Exception { + public void requireThisMethodInvocationArrayInitializer() throws Exception { testQuickfix("RequireThisMethodInvocationArrayInitializer.xml", new RequireThisQuickfix()); } @Test - public void testRequireThisMethodInvocationInnerClass() throws Exception { + public void requireThisMethodInvocationInnerClass() throws Exception { testQuickfix("RequireThisMethodInvocationInnerClass.xml", new RequireThisQuickfix()); } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnTest.java index 0da9fc17c..310c2f14c 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnTest.java @@ -27,72 +27,72 @@ public class SimplifyBooleanReturnTest extends AbstractQuickfixTestCase { @Test - public void testSimplifyBooleanReturnWithoutCurlyBraces() throws Exception { + public void simplifyBooleanReturnWithoutCurlyBraces() throws Exception { testQuickfix("SimplifyBooleanReturnWithoutCurlyBraces.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithCurlyBraces() throws Exception { + public void simplifyBooleanReturnWithCurlyBraces() throws Exception { testQuickfix("SimplifyBooleanReturnWithCurlyBraces.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithBooleanLiteralCondition() throws Exception { + public void simplifyBooleanReturnWithBooleanLiteralCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithBooleanLiteralCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithFieldAccessCondition() throws Exception { + public void simplifyBooleanReturnWithFieldAccessCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithFieldAccessCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithMethodInvocationCondition() throws Exception { + public void simplifyBooleanReturnWithMethodInvocationCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithMethodInvocationCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithQualifiedNameCondition() throws Exception { + public void simplifyBooleanReturnWithQualifiedNameCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithQualifiedNameCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithSimpleNameCondition() throws Exception { + public void simplifyBooleanReturnWithSimpleNameCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithSimpleNameCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithParanthesizedExpressionCondition() throws Exception { + public void simplifyBooleanReturnWithParanthesizedExpressionCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithParanthesizedExpressionCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithSuperFieldAccessCondition() throws Exception { + public void simplifyBooleanReturnWithSuperFieldAccessCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithSuperFieldAccessCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithSuperMethodInvocationCondition() throws Exception { + public void simplifyBooleanReturnWithSuperMethodInvocationCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithSuperMethodInvocationCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithThisExpressionCondition() throws Exception { + public void simplifyBooleanReturnWithThisExpressionCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithThisExpressionCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void testSimplifyBooleanReturnWithNotCondition() throws Exception { + public void simplifyBooleanReturnWithNotCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithNotCondition.xml", new SimplifyBooleanReturnQuickfix()); } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityTest.java index 3f5eafcdf..3ab64150d 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityTest.java @@ -27,7 +27,7 @@ public class StringLiteralEqualityTest extends AbstractQuickfixTestCase { @Test - public void testStringLiteralEquality() throws Exception { + public void stringLiteralEquality() throws Exception { testQuickfix("StringLiteralEqualityInput.xml", new StringLiteralEqualityQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionTest.java index fb62275b7..a0fb281be 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionTest.java @@ -27,7 +27,7 @@ public class DesignForExtensionTest extends AbstractQuickfixTestCase { @Test - public void testDesignForExtension() throws Exception { + public void designForExtension() throws Exception { testQuickfix("DesignForExtensionInput.xml", new DesignForExtensionQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/FinalClassTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/FinalClassTest.java index 33377edbd..9bcb21879 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/FinalClassTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/FinalClassTest.java @@ -27,7 +27,7 @@ public class FinalClassTest extends AbstractQuickfixTestCase { @Test - public void testFinalClass() throws Exception { + public void finalClass() throws Exception { testQuickfix("FinalClassInput.xml", new FinalClassQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleTest.java index a0feb4e1c..5e7d99b0c 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleTest.java @@ -27,17 +27,17 @@ public class ArrayTypeStyleTest extends AbstractQuickfixTestCase { @Test - public void testArrayTypeStyleField() throws Exception { + public void arrayTypeStyleField() throws Exception { testQuickfix("ArrayTypeStyleInputField.xml", new ArrayTypeStyleQuickfix()); } @Test - public void testArrayTypeStyleMethodParam() throws Exception { + public void arrayTypeStyleMethodParam() throws Exception { testQuickfix("ArrayTypeStyleInputMethodParam.xml", new ArrayTypeStyleQuickfix()); } @Test - public void testArrayTypeStyleVariable() throws Exception { + public void arrayTypeStyleVariable() throws Exception { testQuickfix("ArrayTypeStyleInputVariable.xml", new ArrayTypeStyleQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersTest.java index 8766ac8a9..cc2159dab 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersTest.java @@ -27,7 +27,7 @@ public class FinalParametersTest extends AbstractQuickfixTestCase { @Test - public void testFinalParameters() throws Exception { + public void finalParameters() throws Exception { testQuickfix("FinalParametersInput.xml", new FinalParametersQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainTest.java index 89bdbc33a..99e3f1b99 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainTest.java @@ -27,7 +27,7 @@ public class UncommentedMainTest extends AbstractQuickfixTestCase { @Test - public void testUncommentedMain() throws Exception { + public void uncommentedMain() throws Exception { testQuickfix("UncommentedMainInput.xml", new UncommentedMainQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllTest.java index 21ab477ae..abaa2c9cf 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllTest.java @@ -27,7 +27,7 @@ public class UpperEllTest extends AbstractQuickfixTestCase { @Test - public void testUpperEll() throws Exception { + public void upperEll() throws Exception { testQuickfix("UpperEllInput.xml", new UpperEllQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderTest.java index c180b374d..828f57e0b 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderTest.java @@ -27,7 +27,7 @@ public class ModifierOrderTest extends AbstractQuickfixTestCase { @Test - public void testModifierOrder() throws Exception { + public void modifierOrder() throws Exception { testQuickfix("ModifierOrderInput.xml", new ModifierOrderQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierTest.java index 4c1aabdc9..40bd1c7e1 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierTest.java @@ -27,7 +27,7 @@ public class RedundantModifierTest extends AbstractQuickfixTestCase { @Test - public void testRedundantModifier() throws Exception { + public void redundantModifier() throws Exception { testQuickfix("RedundantModifierInput.xml", new RedundantModifierQuickfix()); } } From 1e3bbd2667ddac6a84364796fa435dc57962ac8d Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 16:37:27 +0100 Subject: [PATCH 05/12] refactor: org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic --- .../sf/eclipsecs/checkstyle/ChecksTest.java | 4 +-- .../blocks/AvoidNestedBlocksTest.java | 4 +-- .../ui/quickfixes/blocks/NeedBracesTest.java | 14 +++++----- .../coding/DefaultComesLastTest.java | 6 ++--- .../quickfixes/coding/EmptyStatementTest.java | 6 ++--- .../coding/ExplicitInitializationTest.java | 4 +-- .../coding/FinalLocalVariableTest.java | 4 +-- .../coding/MissingSwitchDefaultTest.java | 6 ++--- .../ui/quickfixes/coding/RequireThisTest.java | 20 +++++++------- .../coding/SimplifyBooleanReturnTest.java | 26 +++++++++---------- .../coding/StringLiteralEqualityTest.java | 4 +-- .../design/DesignForExtensionTest.java | 4 +-- .../ui/quickfixes/design/FinalClassTest.java | 4 +-- .../quickfixes/misc/ArrayTypeStyleTest.java | 8 +++--- .../quickfixes/misc/FinalParametersTest.java | 4 +-- .../quickfixes/misc/UncommentedMainTest.java | 4 +-- .../ui/quickfixes/misc/UpperEllTest.java | 4 +-- .../modifier/ModifierOrderTest.java | 4 +-- .../modifier/RedundantModifierTest.java | 4 +-- 19 files changed, 67 insertions(+), 67 deletions(-) diff --git a/net.sf.eclipsecs.checkstyle/test/net/sf/eclipsecs/checkstyle/ChecksTest.java b/net.sf.eclipsecs.checkstyle/test/net/sf/eclipsecs/checkstyle/ChecksTest.java index fc683ac96..6aedff746 100644 --- a/net.sf.eclipsecs.checkstyle/test/net/sf/eclipsecs/checkstyle/ChecksTest.java +++ b/net.sf.eclipsecs.checkstyle/test/net/sf/eclipsecs/checkstyle/ChecksTest.java @@ -43,10 +43,10 @@ import net.sf.eclipsecs.checkstyle.utils.CheckUtil; import net.sf.eclipsecs.checkstyle.utils.XmlUtil; -public class ChecksTest { +class ChecksTest { @Test - public void metadataFiles() throws Exception { + void metadataFiles() throws Exception { final Set> modules = new HashSet<>(CheckUtil.getCheckstyleModules()); // don't test root modules diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksTest.java index efec2c729..c60c32d9d 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/AvoidNestedBlocksTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class AvoidNestedBlocksTest extends AbstractQuickfixTestCase { +class AvoidNestedBlocksTest extends AbstractQuickfixTestCase { @Test - public void avoidNestedBlocks() throws Exception { + void avoidNestedBlocks() throws Exception { testQuickfix("AvoidNestedBlocksInput.xml", new AvoidNestedBlocksQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesTest.java index 3b01e35d2..f40386511 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/blocks/NeedBracesTest.java @@ -24,35 +24,35 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class NeedBracesTest extends AbstractQuickfixTestCase { +class NeedBracesTest extends AbstractQuickfixTestCase { @Test - public void needBracesIf() throws Exception { + void needBracesIf() throws Exception { testQuickfix("NeedBracesInputIf.xml", new NeedBracesQuickfix()); } @Test - public void needBracesElse() throws Exception { + void needBracesElse() throws Exception { testQuickfix("NeedBracesInputElse.xml", new NeedBracesQuickfix()); } @Test - public void needBracesElseIf() throws Exception { + void needBracesElseIf() throws Exception { testQuickfix("NeedBracesInputElseIf.xml", new NeedBracesQuickfix()); } @Test - public void needBracesFor() throws Exception { + void needBracesFor() throws Exception { testQuickfix("NeedBracesInputFor.xml", new NeedBracesQuickfix()); } @Test - public void needBracesWhile() throws Exception { + void needBracesWhile() throws Exception { testQuickfix("NeedBracesInputWhile.xml", new NeedBracesQuickfix()); } @Test - public void needBracesDoWhile() throws Exception { + void needBracesDoWhile() throws Exception { testQuickfix("NeedBracesInputDoWhile.xml", new NeedBracesQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastTest.java index bff7bec67..992ab5e83 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastTest.java @@ -24,15 +24,15 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class DefaultComesLastTest extends AbstractQuickfixTestCase { +class DefaultComesLastTest extends AbstractQuickfixTestCase { @Test - public void defaultComesLast() throws Exception { + void defaultComesLast() throws Exception { testQuickfix("DefaultComesLastInput.xml", new DefaultComesLastQuickfix()); } @Test - public void defaultComesLastInner() throws Exception { + void defaultComesLastInner() throws Exception { testQuickfix("DefaultComesLastInputInner.xml", new DefaultComesLastQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementTest.java index d509d17a3..d58795d64 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/EmptyStatementTest.java @@ -24,15 +24,15 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class EmptyStatementTest extends AbstractQuickfixTestCase { +class EmptyStatementTest extends AbstractQuickfixTestCase { @Test - public void emptyStatement() throws Exception { + void emptyStatement() throws Exception { testQuickfix("EmptyStatementInput.xml", new EmptyStatementQuickfix()); } @Test - public void emptyStatementNeg() throws Exception { + void emptyStatementNeg() throws Exception { testQuickfix("EmptyStatementInputNeg.xml", new EmptyStatementQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationTest.java index 9dc75a3aa..2997aed6f 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/ExplicitInitializationTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class ExplicitInitializationTest extends AbstractQuickfixTestCase { +class ExplicitInitializationTest extends AbstractQuickfixTestCase { @Test - public void explicitInitialization() throws Exception { + void explicitInitialization() throws Exception { testQuickfix("ExplicitInitialization.xml", new ExplicitInitializationQuickfix()); } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableTest.java index 2552225b8..d92eeea60 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/FinalLocalVariableTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class FinalLocalVariableTest extends AbstractQuickfixTestCase { +class FinalLocalVariableTest extends AbstractQuickfixTestCase { @Test - public void finalLocalVariable() throws Exception { + void finalLocalVariable() throws Exception { testQuickfix("FinalLocalVariableInput.xml", new FinalLocalVariableQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultTest.java index 64a67be5b..e89e9ff2f 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/MissingSwitchDefaultTest.java @@ -24,15 +24,15 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class MissingSwitchDefaultTest extends AbstractQuickfixTestCase { +class MissingSwitchDefaultTest extends AbstractQuickfixTestCase { @Test - public void missingSwitchDefault() throws Exception { + void missingSwitchDefault() throws Exception { testQuickfix("MissingSwitchDefaultInput.xml", new MissingSwitchDefaultQuickfix()); } @Test - public void missingSwitchDefaultInner() throws Exception { + void missingSwitchDefaultInner() throws Exception { testQuickfix("MissingSwitchDefaultInputInner.xml", new MissingSwitchDefaultQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisTest.java index 26831076d..34c41e40f 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/RequireThisTest.java @@ -24,50 +24,50 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class RequireThisTest extends AbstractQuickfixTestCase { +class RequireThisTest extends AbstractQuickfixTestCase { @Test - public void requireThisFieldAccessAssignmentLHS() throws Exception { + void requireThisFieldAccessAssignmentLHS() throws Exception { testQuickfix("RequireThisFieldAccessAssignmentLHS.xml", new RequireThisQuickfix()); } @Test - public void requireThisFieldAccessAssignmentRHS() throws Exception { + void requireThisFieldAccessAssignmentRHS() throws Exception { testQuickfix("RequireThisFieldAccessAssignmentRHS.xml", new RequireThisQuickfix()); } @Test - public void requireThisFieldAccessArrayInitializer() throws Exception { + void requireThisFieldAccessArrayInitializer() throws Exception { testQuickfix("RequireThisFieldAccessArrayInitializer.xml", new RequireThisQuickfix()); } @Test - public void requireThisFieldAccessInnerClass() throws Exception { + void requireThisFieldAccessInnerClass() throws Exception { testQuickfix("RequireThisFieldAccessInnerClass.xml", new RequireThisQuickfix()); } @Test - public void requireThisMethodInvocation() throws Exception { + void requireThisMethodInvocation() throws Exception { testQuickfix("RequireThisMethodInvocation.xml", new RequireThisQuickfix()); } @Test - public void requireThisMethodInvocationWithParam() throws Exception { + void requireThisMethodInvocationWithParam() throws Exception { testQuickfix("RequireThisMethodInvocationWithParam.xml", new RequireThisQuickfix()); } @Test - public void requireThisMethodInvocationAssignmentRHS() throws Exception { + void requireThisMethodInvocationAssignmentRHS() throws Exception { testQuickfix("RequireThisMethodInvocationAssignmentRHS.xml", new RequireThisQuickfix()); } @Test - public void requireThisMethodInvocationArrayInitializer() throws Exception { + void requireThisMethodInvocationArrayInitializer() throws Exception { testQuickfix("RequireThisMethodInvocationArrayInitializer.xml", new RequireThisQuickfix()); } @Test - public void requireThisMethodInvocationInnerClass() throws Exception { + void requireThisMethodInvocationInnerClass() throws Exception { testQuickfix("RequireThisMethodInvocationInnerClass.xml", new RequireThisQuickfix()); } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnTest.java index 310c2f14c..f0732d149 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnTest.java @@ -24,75 +24,75 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class SimplifyBooleanReturnTest extends AbstractQuickfixTestCase { +class SimplifyBooleanReturnTest extends AbstractQuickfixTestCase { @Test - public void simplifyBooleanReturnWithoutCurlyBraces() throws Exception { + void simplifyBooleanReturnWithoutCurlyBraces() throws Exception { testQuickfix("SimplifyBooleanReturnWithoutCurlyBraces.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithCurlyBraces() throws Exception { + void simplifyBooleanReturnWithCurlyBraces() throws Exception { testQuickfix("SimplifyBooleanReturnWithCurlyBraces.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithBooleanLiteralCondition() throws Exception { + void simplifyBooleanReturnWithBooleanLiteralCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithBooleanLiteralCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithFieldAccessCondition() throws Exception { + void simplifyBooleanReturnWithFieldAccessCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithFieldAccessCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithMethodInvocationCondition() throws Exception { + void simplifyBooleanReturnWithMethodInvocationCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithMethodInvocationCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithQualifiedNameCondition() throws Exception { + void simplifyBooleanReturnWithQualifiedNameCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithQualifiedNameCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithSimpleNameCondition() throws Exception { + void simplifyBooleanReturnWithSimpleNameCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithSimpleNameCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithParanthesizedExpressionCondition() throws Exception { + void simplifyBooleanReturnWithParanthesizedExpressionCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithParanthesizedExpressionCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithSuperFieldAccessCondition() throws Exception { + void simplifyBooleanReturnWithSuperFieldAccessCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithSuperFieldAccessCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithSuperMethodInvocationCondition() throws Exception { + void simplifyBooleanReturnWithSuperMethodInvocationCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithSuperMethodInvocationCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithThisExpressionCondition() throws Exception { + void simplifyBooleanReturnWithThisExpressionCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithThisExpressionCondition.xml", new SimplifyBooleanReturnQuickfix()); } @Test - public void simplifyBooleanReturnWithNotCondition() throws Exception { + void simplifyBooleanReturnWithNotCondition() throws Exception { testQuickfix("SimplifyBooleanReturnWithNotCondition.xml", new SimplifyBooleanReturnQuickfix()); } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityTest.java index 3ab64150d..269609a69 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/coding/StringLiteralEqualityTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class StringLiteralEqualityTest extends AbstractQuickfixTestCase { +class StringLiteralEqualityTest extends AbstractQuickfixTestCase { @Test - public void stringLiteralEquality() throws Exception { + void stringLiteralEquality() throws Exception { testQuickfix("StringLiteralEqualityInput.xml", new StringLiteralEqualityQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionTest.java index a0fb281be..95b52f1e3 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/DesignForExtensionTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class DesignForExtensionTest extends AbstractQuickfixTestCase { +class DesignForExtensionTest extends AbstractQuickfixTestCase { @Test - public void designForExtension() throws Exception { + void designForExtension() throws Exception { testQuickfix("DesignForExtensionInput.xml", new DesignForExtensionQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/FinalClassTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/FinalClassTest.java index 9bcb21879..e0b3633be 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/FinalClassTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/design/FinalClassTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class FinalClassTest extends AbstractQuickfixTestCase { +class FinalClassTest extends AbstractQuickfixTestCase { @Test - public void finalClass() throws Exception { + void finalClass() throws Exception { testQuickfix("FinalClassInput.xml", new FinalClassQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleTest.java index 5e7d99b0c..128f0b169 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleTest.java @@ -24,20 +24,20 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class ArrayTypeStyleTest extends AbstractQuickfixTestCase { +class ArrayTypeStyleTest extends AbstractQuickfixTestCase { @Test - public void arrayTypeStyleField() throws Exception { + void arrayTypeStyleField() throws Exception { testQuickfix("ArrayTypeStyleInputField.xml", new ArrayTypeStyleQuickfix()); } @Test - public void arrayTypeStyleMethodParam() throws Exception { + void arrayTypeStyleMethodParam() throws Exception { testQuickfix("ArrayTypeStyleInputMethodParam.xml", new ArrayTypeStyleQuickfix()); } @Test - public void arrayTypeStyleVariable() throws Exception { + void arrayTypeStyleVariable() throws Exception { testQuickfix("ArrayTypeStyleInputVariable.xml", new ArrayTypeStyleQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersTest.java index cc2159dab..e8655e4f9 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/FinalParametersTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class FinalParametersTest extends AbstractQuickfixTestCase { +class FinalParametersTest extends AbstractQuickfixTestCase { @Test - public void finalParameters() throws Exception { + void finalParameters() throws Exception { testQuickfix("FinalParametersInput.xml", new FinalParametersQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainTest.java index 99e3f1b99..c014f8f68 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UncommentedMainTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class UncommentedMainTest extends AbstractQuickfixTestCase { +class UncommentedMainTest extends AbstractQuickfixTestCase { @Test - public void uncommentedMain() throws Exception { + void uncommentedMain() throws Exception { testQuickfix("UncommentedMainInput.xml", new UncommentedMainQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllTest.java index abaa2c9cf..b301e9bab 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/misc/UpperEllTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class UpperEllTest extends AbstractQuickfixTestCase { +class UpperEllTest extends AbstractQuickfixTestCase { @Test - public void upperEll() throws Exception { + void upperEll() throws Exception { testQuickfix("UpperEllInput.xml", new UpperEllQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderTest.java index 828f57e0b..6c8bff661 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class ModifierOrderTest extends AbstractQuickfixTestCase { +class ModifierOrderTest extends AbstractQuickfixTestCase { @Test - public void modifierOrder() throws Exception { + void modifierOrder() throws Exception { testQuickfix("ModifierOrderInput.xml", new ModifierOrderQuickfix()); } } diff --git a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierTest.java b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierTest.java index 40bd1c7e1..44a47a6dc 100644 --- a/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierTest.java +++ b/net.sf.eclipsecs.ui/test/net/sf/eclipsecs/ui/quickfixes/modifier/RedundantModifierTest.java @@ -24,10 +24,10 @@ import net.sf.eclipsecs.ui.quickfixes.AbstractQuickfixTestCase; -public class RedundantModifierTest extends AbstractQuickfixTestCase { +class RedundantModifierTest extends AbstractQuickfixTestCase { @Test - public void redundantModifier() throws Exception { + void redundantModifier() throws Exception { testQuickfix("RedundantModifierInput.xml", new RedundantModifierQuickfix()); } } From 39c643c62dacb0040f50db4b44c8374dcf0564c8 Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 17:21:53 +0100 Subject: [PATCH 06/12] refactor: org.openrewrite.staticanalysis.IsEmptyCallOnCollections --- .../sf/eclipsecs/core/config/CheckConfigurationFactory.java | 2 +- .../src/net/sf/eclipsecs/core/config/ConfigurationWriter.java | 2 +- .../core/config/GlobalCheckConfigurationWorkingSet.java | 2 +- .../core/projectconfig/LocalCheckConfigurationWorkingSet.java | 2 +- .../core/projectconfig/ProjectConfigurationFactory.java | 2 +- .../sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java | 4 ++-- .../net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java | 2 +- .../ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java index f3d1f9ff9..e74cff326 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java @@ -145,7 +145,7 @@ public static ICheckConfiguration getDefaultCheckConfiguration() { return sDefaultCheckConfig; } else if (sDefaultBuiltInConfig != null) { return sDefaultBuiltInConfig; - } else if (sConfigurations.size() > 0) { + } else if (!sConfigurations.isEmpty()) { return sConfigurations.get(0); } else { return null; diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java index 581b3638e..29b4e0399 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java @@ -109,7 +109,7 @@ public static void write(OutputStream out, List modules, ICheckConfigura // find the root module (Checker) // the root module is the only module that has no parent List rootModules = getChildModules(null, modules); - if (rootModules.size() < 1) { + if (rootModules.isEmpty()) { throw new CheckstylePluginException(Messages.errorNoRootModule); } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java index 392d487f6..71263225e 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java @@ -167,7 +167,7 @@ public void store() throws CheckstylePluginException { @Override public boolean isDirty() { - if (mDeletedConfigurations.size() > 0) { + if (!mDeletedConfigurations.isEmpty()) { return true; } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java index 93c63e439..659be0551 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java @@ -110,7 +110,7 @@ public void store() throws CheckstylePluginException { @Override public boolean isDirty() { - if (mDeletedConfigurations.size() > 0) { + if (!mDeletedConfigurations.isEmpty()) { return true; } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationFactory.java index d2bbf77b0..c546af788 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationFactory.java @@ -123,7 +123,7 @@ public static IProjectConfiguration getConfiguration(IProject project) */ public static boolean isCheckConfigInUse(ICheckConfiguration checkConfig) throws CheckstylePluginException { - return getProjectsUsingConfig(checkConfig).size() > 0; + return !getProjectsUsingConfig(checkConfig).isEmpty(); } /** diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java index 3b7680b22..d25f85183 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java @@ -460,13 +460,13 @@ public boolean performOk() { .getString(CheckstyleUIPluginPrefs.PREF_ASK_BEFORE_REBUILD); boolean rebuild = MessageDialogWithToggle.ALWAYS.equals(promptRebuildPref) - && (needRebuildAllProjects || projectsToBuild.size() > 0); + && (needRebuildAllProjects || !projectsToBuild.isEmpty()); // // Prompt for rebuild // if (MessageDialogWithToggle.PROMPT.equals(promptRebuildPref) - && (needRebuildAllProjects || projectsToBuild.size() > 0)) { + && (needRebuildAllProjects || !projectsToBuild.isEmpty())) { MessageDialogWithToggle dialog = MessageDialogWithToggle.openYesNoQuestion(getShell(), Messages.CheckstylePreferencePage_titleRebuild, diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java index 0aa84906b..2bf03df1c 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java @@ -93,7 +93,7 @@ public void setFileSets(List fileSets) throws CheckstylePluginException mFileSets = fileSets; ICheckConfiguration config = null; - if (mFileSets.size() > 0) { + if (!mFileSets.isEmpty()) { config = (mFileSets.get(0)).getCheckConfig(); } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java index bb980e6d2..c24605af1 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java @@ -133,7 +133,7 @@ private Boolean isReturnStatementTrue(final Statement node) { // the return statement might be wrapped in a block statement @SuppressWarnings("unchecked") final List statements = ((Block) node).statements(); - if (statements.size() > 0) { + if (!statements.isEmpty()) { return isReturnStatementTrue(statements.get(0)); } } From f0293acdab1f3c2668300c3610b01c7163c30aee Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 17:23:37 +0100 Subject: [PATCH 07/12] refactor: org.openrewrite.staticanalysis.ExplicitInitialization --- .../src/net/sf/eclipsecs/core/builder/Auditor.java | 4 ++-- .../src/net/sf/eclipsecs/core/config/CheckConfiguration.java | 2 +- .../sf/eclipsecs/ui/config/RuleConfigurationEditDialog.java | 2 +- .../sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java | 2 +- net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/SWTUtil.java | 2 +- .../eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java index 3a75cbb1b..297f78953 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java @@ -82,10 +82,10 @@ public class Auditor { private IProgressMonitor mMonitor; /** Add the check rule name to the message. */ - private boolean mAddRuleName = false; + private boolean mAddRuleName; /** Add the check module id to the message. */ - private boolean mAddModuleId = false; + private boolean mAddModuleId; /** * Creates an auditor. diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfiguration.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfiguration.java index b9ba873a8..6af4954ee 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfiguration.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfiguration.java @@ -63,7 +63,7 @@ public class CheckConfiguration implements ICheckConfiguration { private CheckstyleConfigurationFile mCheckstyleConfigurationFile; /** Time stamp when the cached configuration file data expires. */ - private long mExpirationTime = 0; + private long mExpirationTime; /** * Creates a check configuration instance. diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/RuleConfigurationEditDialog.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/RuleConfigurationEditDialog.java index 1cea77e8f..5fd0e68c9 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/RuleConfigurationEditDialog.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/RuleConfigurationEditDialog.java @@ -92,7 +92,7 @@ public class RuleConfigurationEditDialog extends TitleAreaDialog { private Map mCustomMessages; - private boolean mReadonly = false; + private boolean mReadonly; /** * Constructor. diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java index d25f85183..8cb0db8b7 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java @@ -113,7 +113,7 @@ public class CheckstylePreferencePage extends PreferencePage implements IWorkben private CheckConfigurationWorkingSetEditor mWorkingSetEditor; - private boolean mRebuildAll = false; + private boolean mRebuildAll; /** * Constructor. diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/SWTUtil.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/SWTUtil.java index 68387d3bb..0c008dc81 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/SWTUtil.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/SWTUtil.java @@ -237,7 +237,7 @@ private static final class ShellResizeSupportListener extends ShellAdapter private String mDialogKey; /** flag that indicates if the dialog was already initally activated. */ - private boolean mInitialyActivated = false; + private boolean mInitialyActivated; // // constructors diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java index 05b19b1d2..8cdd478c9 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedCheckBoxTableViewer.java @@ -490,7 +490,7 @@ static final class CustomHashtable { transient HashMapEntry[] elementData; - transient int firstSlot = 0; + transient int firstSlot; transient int lastSlot = -1; From 3deb9fa465cb0f0c127028292da612dcf05ea78e Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 17:26:36 +0100 Subject: [PATCH 08/12] refactor: org.openrewrite.staticanalysis.InlineVariable --- .../src/net/sf/eclipsecs/core/builder/CheckerFactory.java | 4 +--- .../sf/eclipsecs/core/config/CheckConfigurationFactory.java | 6 ++---- .../src/net/sf/eclipsecs/core/config/ConfigProperty.java | 3 +-- .../net/sf/eclipsecs/core/config/ResolvableProperty.java | 3 +-- .../net/sf/eclipsecs/core/config/meta/MetadataFactory.java | 3 +-- .../ui/config/CheckConfigurationConfigureDialog.java | 4 +--- .../ui/config/CheckConfigurationWorkingSetEditor.java | 3 +-- .../ui/config/configtypes/ConfigurationTypesUI.java | 3 +-- .../ui/config/widgets/ConfigPropertyWidgetSingleSelect.java | 3 +-- .../ui/properties/filter/CheckFileOnOpenPartListener.java | 3 +-- .../eclipsecs/ui/properties/filter/PluginFilterEditors.java | 3 +-- .../ui/quickfixes/misc/ArrayTypeStyleQuickfix.java | 4 +--- 12 files changed, 13 insertions(+), 29 deletions(-) diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckerFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckerFactory.java index 093a71372..49debf14e 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckerFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/CheckerFactory.java @@ -162,9 +162,7 @@ private static String getCacheKey(ICheckConfiguration config, IProject project) URL configLocation = configFileData.getResolvedConfigFileURL(); String checkConfigName = config.getName() + "#" + (config.isGlobal() ? "Global" : "Local"); - String cacheKey = project.getName() + "#" + configLocation + "#" + checkConfigName; - - return cacheKey; + return project.getName() + "#" + configLocation + "#" + checkConfigName; } /** diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java index e74cff326..a24946a8a 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java @@ -282,8 +282,7 @@ private static IPath getTargetStateLocation(IPath newWorkspaceRoot) { currentStateLocation = currentStateLocation.removeFirstSegments(segmentsToRemove); // Now add to the target workspace root - IPath targetStateLocation = newWorkspaceRoot.append(currentStateLocation); - return targetStateLocation; + return newWorkspaceRoot.append(currentStateLocation); } @@ -335,8 +334,7 @@ private static void loadFromPersistence() throws CheckstylePluginException { private static File getInternalConfigurationFile() { IPath configPath = CheckstylePlugin.getDefault().getStateLocation(); configPath = configPath.append(CHECKSTYLE_CONFIG_FILE); - File configFile = configPath.toFile(); - return configFile; + return configPath.toFile(); } /** diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigProperty.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigProperty.java index 89a65797b..665962c95 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigProperty.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigProperty.java @@ -148,8 +148,7 @@ public int compareTo(ConfigProperty obj) { @Override public ConfigProperty clone() { try { - ConfigProperty clone = (ConfigProperty) super.clone(); - return clone; + return (ConfigProperty) super.clone(); } catch (CloneNotSupportedException ex) { // Should not happen throw new InternalError(ex); diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ResolvableProperty.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ResolvableProperty.java index 405ae33b0..974fab4af 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ResolvableProperty.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ResolvableProperty.java @@ -99,8 +99,7 @@ public int hashCode() { @Override public ResolvableProperty clone() { try { - ResolvableProperty clone = (ResolvableProperty) super.clone(); - return clone; + return (ResolvableProperty) super.clone(); } catch (CloneNotSupportedException ex) { // should never happen throw new InternalError(ex); diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java index b628ac9f5..393657c5f 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java @@ -519,8 +519,7 @@ private static String getStandardMessage(String messageKey, RuleMetadata rule) { CheckstylePlugin.getPlatformLocale(), CheckstylePlugin.class.getClassLoader(), new UTF8Control()); - String message = resourceBundle.getString(messageKey); - return message; + return resourceBundle.getString(messageKey); } catch (MissingResourceException ex) { // let's continue to check the other alternative names } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationConfigureDialog.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationConfigureDialog.java index 982161651..f1ed3c536 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationConfigureDialog.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationConfigureDialog.java @@ -1070,11 +1070,9 @@ private boolean selectRule(RuleMetadata element, String filterText) { String ruleName = element.getRuleName(); String internalName = element.getInternalName(); String description = element.getDescription(); - boolean passes = (ruleName != null && matchPattern.matcher(ruleName).find()) + return (ruleName != null && matchPattern.matcher(ruleName).find()) || (internalName != null && matchPattern.matcher(internalName).find()) || (description != null && matchPattern.matcher(description).find()); - - return passes; } private boolean selectGroup(RuleGroupMetadata group, String filterText) { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationWorkingSetEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationWorkingSetEditor.java index 7e06b1247..51f1feb9d 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationWorkingSetEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/CheckConfigurationWorkingSetEditor.java @@ -136,8 +136,7 @@ public Control createContents(Composite ancestor) { // // Create the check configuration section of the screen. // - Composite configComposite = createCheckConfigContents(ancestor); - return configComposite; + return createCheckConfigContents(ancestor); } /** diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ConfigurationTypesUI.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ConfigurationTypesUI.java index 40035cb3f..339885b14 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ConfigurationTypesUI.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/configtypes/ConfigurationTypesUI.java @@ -122,8 +122,7 @@ public static ICheckConfigurationEditor getNewEditor(IConfigurationType configTy if (editorClass != null) { try { - ICheckConfigurationEditor editor = editorClass.getDeclaredConstructor().newInstance(); - return editor; + return editorClass.getDeclaredConstructor().newInstance(); } catch (ClassCastException | ReflectiveOperationException ex) { CheckstylePluginException.rethrow(ex); } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetSingleSelect.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetSingleSelect.java index 810d225b7..a9c212650 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetSingleSelect.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetSingleSelect.java @@ -82,8 +82,7 @@ protected Control getValueWidget(Composite parent) { @Override public String getValue() { - String result = mComboItem.getItem(mComboItem.getSelectionIndex()); - return result; + return mComboItem.getItem(mComboItem.getSelectionIndex()); } @Override diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/CheckFileOnOpenPartListener.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/CheckFileOnOpenPartListener.java index 365e57b6e..c8ec41ded 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/CheckFileOnOpenPartListener.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/CheckFileOnOpenPartListener.java @@ -272,8 +272,7 @@ private IMemento getMementoE3(IEditorReference editorRef) { Method getMementoMethod = editorRef.getClass().getMethod("getMemento", new Class[0]); getMementoMethod.setAccessible(true); - IMemento memento = (IMemento) getMementoMethod.invoke(editorRef, (Object[]) null); - return memento; + return (IMemento) getMementoMethod.invoke(editorRef, (Object[]) null); } catch (NoSuchMethodException | SecurityException | IllegalAccessException | InvocationTargetException ex) { CheckstyleLog.log(ex); } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PluginFilterEditors.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PluginFilterEditors.java index f3cfdf685..6079b1d4e 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PluginFilterEditors.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PluginFilterEditors.java @@ -109,8 +109,7 @@ public static IFilterEditor getNewEditor(IFilter filter) throws CheckstylePlugin if (editorClass != null) { try { - IFilterEditor editor = editorClass.getDeclaredConstructor().newInstance(); - return editor; + return editorClass.getDeclaredConstructor().newInstance(); } catch (ClassCastException | ReflectiveOperationException | SecurityException ex) { CheckstylePluginException.rethrow(ex); } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleQuickfix.java index 132ec3b3a..f39e707dd 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/misc/ArrayTypeStyleQuickfix.java @@ -176,9 +176,7 @@ private boolean isCStyle(List fragments) { private ArrayType createArrayType(Type componentType, int dimensions) { Type type = (Type) ASTNode.copySubtree(componentType.getAST(), componentType); - ArrayType arrayType = componentType.getAST().newArrayType(type, dimensions); - - return arrayType; + return componentType.getAST().newArrayType(type, dimensions); } }; } From 1b0c1043abbd0f6d28b5068d22eacc0764d2e3a7 Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 17:27:59 +0100 Subject: [PATCH 09/12] refactor: org.openrewrite.staticanalysis.RemoveEmptyJavaDocParameters --- .../src/net/sf/eclipsecs/core/builder/Auditor.java | 2 -- .../net/sf/eclipsecs/core/config/meta/MetadataFactory.java | 4 ---- .../ui/config/widgets/ConfigPropertyWidgetStringArray.java | 1 - .../ui/quickfixes/CheckstyleMarkerResolutionGenerator.java | 1 - .../sf/eclipsecs/ui/quickfixes/MarkerHelpContextProvider.java | 3 --- .../net/sf/eclipsecs/ui/util/table/EnhancedTableViewer.java | 1 - 6 files changed, 12 deletions(-) diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java index 297f78953..7c64fa645 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/builder/Auditor.java @@ -211,8 +211,6 @@ private IFile getFile(String fileName) { /** * Helper method to get an array of java.io.Files. This array gets passed to the checker. - * - * @return */ private List getFilesList() { List files = new ArrayList<>(); diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java index 393657c5f..9ba4d4ebd 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/MetadataFactory.java @@ -578,10 +578,6 @@ private static void doInitialization() throws CheckstylePluginException { loadRuleMetadata(); } - /** - * @param metadataFile - * @return - */ private static String groupId(String metadataFile) { String res = StringUtils.substringBetween(metadataFile, "/checks/", "/"); res = StringUtils.defaultString(res, metadataFile); diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetStringArray.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetStringArray.java index 7c035e50e..603caf276 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetStringArray.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetStringArray.java @@ -48,7 +48,6 @@ public String getValue() { /** * normalize array properties to be separated by a comma and a blank for better readability of the plain config file - * @param text * @return text with normalized separators */ private String normalizeSeparator(String text) { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleMarkerResolutionGenerator.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleMarkerResolutionGenerator.java index 26637b071..41bd272f3 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleMarkerResolutionGenerator.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleMarkerResolutionGenerator.java @@ -50,7 +50,6 @@ public boolean hasResolutions(IMarker marker) { } /** - * @param marker * @return {@code true} if this is a checkstyle marker */ private boolean isCheckstyleMarker(IMarker marker) { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/MarkerHelpContextProvider.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/MarkerHelpContextProvider.java index 9993c4d27..cf47137db 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/MarkerHelpContextProvider.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/MarkerHelpContextProvider.java @@ -137,9 +137,6 @@ public String getHref() { private static final class CheckstyleHelpContext implements IContext { private final String moduleName; - /** - * @param moduleName - */ private CheckstyleHelpContext(String moduleName) { this.moduleName = moduleName; } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedTableViewer.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedTableViewer.java index f8a742eee..925cadce5 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedTableViewer.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/util/table/EnhancedTableViewer.java @@ -204,7 +204,6 @@ public void installEnhancements() { /** * Set the sort column. By default the column 0 is used. - * @param sortedColumnIndex */ public void setSortedColumnIndex(int sortedColumnIndex) { mSortedColumnIndex = sortedColumnIndex; From 3f45db649bac9ae58bab0231f4910078382a31dc Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 17:35:00 +0100 Subject: [PATCH 10/12] refactor: org.openrewrite.staticanalysis.CompareEnumsWithEqualityOperator --- .../net/sf/eclipsecs/core/config/ConfigurationWriter.java | 2 +- .../src/net/sf/eclipsecs/core/config/Module.java | 6 +++--- .../eclipsecs/core/config/meta/ConfigPropertyMetadata.java | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java index 29b4e0399..d3def8b29 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java @@ -159,7 +159,7 @@ private static void writeModule(Module module, Branch parent, Severity parentSev // Write severity only if it differs from the parents severity Severity severity = parentSeverity; - if (module.getSeverity() != null && !Severity.inherit.equals(module.getSeverity())) { + if (module.getSeverity() != null && Severity.inherit != module.getSeverity()) { Element propertyEl = moduleEl.addElement(XMLTags.PROPERTY_TAG); propertyEl.addAttribute(XMLTags.NAME_TAG, XMLTags.SEVERITY_TAG); diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Module.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Module.java index c5bce6f81..1d833d4e1 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Module.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/Module.java @@ -271,11 +271,11 @@ public void setSeverity(Severity severityLevel) { } if (defaultLevel != null) { - if (severityLevel.equals(defaultLevel)) { + if (severityLevel == defaultLevel) { mSeverityLevel = null; setLastEnabledSeverity(null); - } else if (Severity.ignore.equals(severityLevel)) { - if (mSeverityLevel != null && !Severity.ignore.equals(mSeverityLevel)) { + } else if (Severity.ignore == severityLevel) { + if (mSeverityLevel != null && Severity.ignore != mSeverityLevel) { setLastEnabledSeverity(mSeverityLevel); } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/ConfigPropertyMetadata.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/ConfigPropertyMetadata.java index 103d5d03c..51b9d48f9 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/ConfigPropertyMetadata.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/meta/ConfigPropertyMetadata.java @@ -139,7 +139,7 @@ public List getPropertyEnumeration() { * @return boolean */ public boolean isHidden() { - return ConfigPropertyType.Hidden.equals(mDatatype); + return ConfigPropertyType.Hidden == mDatatype; } } From 9940a537eb721a8b6e9f15e7244e0cbb38fb536f Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 17:36:40 +0100 Subject: [PATCH 11/12] refactor: org.openrewrite.staticanalysis.FinalClass --- .../net/sf/eclipsecs/ui/quickfixes/CheckstyleQuickfixes.java | 2 +- .../src/net/sf/eclipsecs/ui/quickfixes/Messages.java | 2 +- .../src/net/sf/eclipsecs/ui/quickfixes/modifier/Messages.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleQuickfixes.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleQuickfixes.java index dbee24528..7c1ebc68e 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleQuickfixes.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/CheckstyleQuickfixes.java @@ -38,7 +38,7 @@ * @implNote Cached over the runtime of the application. Will not react to plugins loaded * dynamically. */ -public class CheckstyleQuickfixes { +public final class CheckstyleQuickfixes { /** * ID of the quickfix extension point diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/Messages.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/Messages.java index 3ebafec2e..21c78e9bd 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/Messages.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/Messages.java @@ -23,7 +23,7 @@ //CHECKSTYLE:OFF import org.eclipse.osgi.util.NLS; -public class Messages extends NLS { +public final class Messages extends NLS { private static final String BUNDLE_NAME = "net.sf.eclipsecs.ui.quickfixes.messages"; //$NON-NLS-1$ private Messages() { diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/Messages.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/Messages.java index 6eb053a0e..fee49a9e0 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/Messages.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/Messages.java @@ -23,7 +23,7 @@ //CHECKSTYLE:OFF import org.eclipse.osgi.util.NLS; -public class Messages extends NLS { +public final class Messages extends NLS { private static final String BUNDLE_NAME = "net.sf.eclipsecs.ui.quickfixes.modifier.messages"; //$NON-NLS-1$ private Messages() { From 6c34c682ed7494dd1854cbc3ed4964239e69d43c Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 17:54:37 +0100 Subject: [PATCH 12/12] refactor: fix checkstyle warning --- .../sf/eclipsecs/core/config/CheckConfigurationFactory.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java index a24946a8a..49b1bc065 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java @@ -147,9 +147,8 @@ public static ICheckConfiguration getDefaultCheckConfiguration() { return sDefaultBuiltInConfig; } else if (!sConfigurations.isEmpty()) { return sConfigurations.get(0); - } else { - return null; } + return null; } /**