From 39c643c62dacb0040f50db4b44c8374dcf0564c8 Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sun, 19 Jan 2025 17:21:53 +0100 Subject: [PATCH] refactor: org.openrewrite.staticanalysis.IsEmptyCallOnCollections --- .../sf/eclipsecs/core/config/CheckConfigurationFactory.java | 2 +- .../src/net/sf/eclipsecs/core/config/ConfigurationWriter.java | 2 +- .../core/config/GlobalCheckConfigurationWorkingSet.java | 2 +- .../core/projectconfig/LocalCheckConfigurationWorkingSet.java | 2 +- .../core/projectconfig/ProjectConfigurationFactory.java | 2 +- .../sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java | 4 ++-- .../net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java | 2 +- .../ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java index f3d1f9ff9..e74cff326 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/CheckConfigurationFactory.java @@ -145,7 +145,7 @@ public static ICheckConfiguration getDefaultCheckConfiguration() { return sDefaultCheckConfig; } else if (sDefaultBuiltInConfig != null) { return sDefaultBuiltInConfig; - } else if (sConfigurations.size() > 0) { + } else if (!sConfigurations.isEmpty()) { return sConfigurations.get(0); } else { return null; diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java index 581b3638e..29b4e0399 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationWriter.java @@ -109,7 +109,7 @@ public static void write(OutputStream out, List modules, ICheckConfigura // find the root module (Checker) // the root module is the only module that has no parent List rootModules = getChildModules(null, modules); - if (rootModules.size() < 1) { + if (rootModules.isEmpty()) { throw new CheckstylePluginException(Messages.errorNoRootModule); } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java index 392d487f6..71263225e 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/GlobalCheckConfigurationWorkingSet.java @@ -167,7 +167,7 @@ public void store() throws CheckstylePluginException { @Override public boolean isDirty() { - if (mDeletedConfigurations.size() > 0) { + if (!mDeletedConfigurations.isEmpty()) { return true; } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java index 93c63e439..659be0551 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/LocalCheckConfigurationWorkingSet.java @@ -110,7 +110,7 @@ public void store() throws CheckstylePluginException { @Override public boolean isDirty() { - if (mDeletedConfigurations.size() > 0) { + if (!mDeletedConfigurations.isEmpty()) { return true; } diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationFactory.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationFactory.java index d2bbf77b0..c546af788 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationFactory.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationFactory.java @@ -123,7 +123,7 @@ public static IProjectConfiguration getConfiguration(IProject project) */ public static boolean isCheckConfigInUse(ICheckConfiguration checkConfig) throws CheckstylePluginException { - return getProjectsUsingConfig(checkConfig).size() > 0; + return !getProjectsUsingConfig(checkConfig).isEmpty(); } /** diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java index 3b7680b22..d25f85183 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/preferences/CheckstylePreferencePage.java @@ -460,13 +460,13 @@ public boolean performOk() { .getString(CheckstyleUIPluginPrefs.PREF_ASK_BEFORE_REBUILD); boolean rebuild = MessageDialogWithToggle.ALWAYS.equals(promptRebuildPref) - && (needRebuildAllProjects || projectsToBuild.size() > 0); + && (needRebuildAllProjects || !projectsToBuild.isEmpty()); // // Prompt for rebuild // if (MessageDialogWithToggle.PROMPT.equals(promptRebuildPref) - && (needRebuildAllProjects || projectsToBuild.size() > 0)) { + && (needRebuildAllProjects || !projectsToBuild.isEmpty())) { MessageDialogWithToggle dialog = MessageDialogWithToggle.openYesNoQuestion(getShell(), Messages.CheckstylePreferencePage_titleRebuild, diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java index 0aa84906b..2bf03df1c 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/SimpleFileSetsEditor.java @@ -93,7 +93,7 @@ public void setFileSets(List fileSets) throws CheckstylePluginException mFileSets = fileSets; ICheckConfiguration config = null; - if (mFileSets.size() > 0) { + if (!mFileSets.isEmpty()) { config = (mFileSets.get(0)).getCheckConfig(); } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java index bb980e6d2..c24605af1 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/SimplifyBooleanReturnQuickfix.java @@ -133,7 +133,7 @@ private Boolean isReturnStatementTrue(final Statement node) { // the return statement might be wrapped in a block statement @SuppressWarnings("unchecked") final List statements = ((Block) node).statements(); - if (statements.size() > 0) { + if (!statements.isEmpty()) { return isReturnStatementTrue(statements.get(0)); } }