-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DBAPI implementation use session, fix execute for none-returning queries #169
Conversation
64218ba
to
e1b4163
Compare
@yunyu this usually means the commits within the PR were pushed to your branch with a different user (or no user) |
e1b4163
to
3772742
Compare
Got it, CLA fixed! |
Btw @lmangani do you know why the test fails with |
@lmangani is right. chDB session relies on persistence of database storage files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #163 #162
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Make dbapi implementation use session, which is stateful (most consumers of dbapi likely want statefulness). Also fix
execute
to not throw an exception for None-returning queries likeCREATE TABLE
.Documentation entry for user-facing changes