From 4ed39c29f7298f9a0a2b1efa449f084ec720f8ea Mon Sep 17 00:00:00 2001 From: sangilyun Date: Sun, 19 May 2024 20:17:55 +0900 Subject: [PATCH 1/2] delete post /me endpoint as it's going to use get /me endpoint instead --- src/user/user.controller.ts | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/user/user.controller.ts b/src/user/user.controller.ts index 7de5454e..b92d6ff8 100644 --- a/src/user/user.controller.ts +++ b/src/user/user.controller.ts @@ -47,22 +47,6 @@ export class UserController { return req['user']; } - /** - * This POST endpoint deviates from REST patterns. - * Please use `getUserByFirebaseId` above which is a GET endpoint. - * Do not delete this until frontend usage is migrated. - */ - @ApiBearerAuth('access-token') - @ApiOperation({ - description: - 'Returns user profile data with their nested partner access, partner admin, course user and session user data.', - }) - @Post('/me') - @UseGuards(FirebaseAuthGuard) - async getUserProfileByFirebaseId(@Req() req: Request): Promise { - return req['user']; - } - // TODO - work out if this is used anywhere and delete if necessary @ApiBearerAuth() @Post('/delete') From e9da9916807be6cd6740302675f227582476e446 Mon Sep 17 00:00:00 2001 From: sangilyun Date: Sat, 15 Jun 2024 19:14:39 +0900 Subject: [PATCH 2/2] merge develop and resolve a conflict --- src/user/user.controller.ts | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/user/user.controller.ts b/src/user/user.controller.ts index 2ea45444..686c09a4 100644 --- a/src/user/user.controller.ts +++ b/src/user/user.controller.ts @@ -47,22 +47,6 @@ export class UserController { return req['user']; } - /** - * This POST endpoint deviates from REST patterns. - * Please use `getUserByFirebaseId` above which is a GET endpoint. - * Do not delete this until frontend usage is migrated. - */ - @ApiBearerAuth('access-token') - @ApiOperation({ - description: - 'Returns user profile data with their nested partner access, partner admin, course user and session user data.', - }) - @Post('/me') - @UseGuards(FirebaseAuthGuard) - async getUserProfileByFirebaseId(@Req() req: Request): Promise { - return req['user']; - } - @ApiBearerAuth() @Delete() @UseGuards(FirebaseAuthGuard)