Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the POST /user/me endpoint #425

Closed
3 tasks
eleanorreem opened this issue May 15, 2024 · 6 comments
Closed
3 tasks

Delete the POST /user/me endpoint #425

eleanorreem opened this issue May 15, 2024 · 6 comments
Assignees
Labels
complexity: beginner Time needed to do this ticket is less than 1 day. first-timers-friendly Appropriate for first time contributors. good-first-issue Good for newcomers maintenance Maintenance / chore work stale This issue or PR is inactive.

Comments

@eleanorreem
Copy link
Contributor

eleanorreem commented May 15, 2024

Overview

This ticket involved removing an outdated POST /user/me endpoint. This issue was blocked by a frontend issue. The frontend needs to be migrated over to the new GET /user/me endpoint before this endpoint is deleted.

Action Items

  • Remove the POST /user/me endpoint from the user.controller.ts
  • Run unit tests to ensure everything is still working as expected.
  • Run Cypress tests to ensure everything is still working as expected
@eleanorreem eleanorreem added good-first-issue Good for newcomers complexity: beginner Time needed to do this ticket is less than 1 day. state: blocked Task is blocked. maintenance Maintenance / chore work first-timers-friendly Appropriate for first time contributors. labels May 15, 2024
@SangilYun
Copy link
Contributor

Hi @eleanorreem! Can I work on this?

Copy link

Thank you for your interest in contributing to Chayn! Please carefully read the CONTRIBUTING.md file and the README.md file for guidance. Let us know if you have any questions. Good luck!

@eleanorreem
Copy link
Contributor Author

Hi @SangilYun, Thanks for your interest 😄 Note that this issue is blocked until the linked frontend ticket is completed.I will update you when that ticket is complete! Let me know if you have any questions!

@kyleecodes
Copy link
Member

kyleecodes commented Jun 14, 2024

@SangilYun, this issue is now unblocked. Please let us know if your PR needs updates or is ready as is.

@github-actions github-actions bot added the stale This issue or PR is inactive. label Jul 15, 2024
@kyleecodes
Copy link
Member

Hi @SangilYun, thank you for your contributions to Chayn! I know you have been busy with other contributions, but are you still working on this one? Take as much time as you need. I am just checking in after a month of inactivity. Let us know if there's anything you need or if you would like to be unassigned this issue. Thanks again.

@eleanorreem
Copy link
Contributor Author

eleanorreem commented Jul 17, 2024

@kyleecodes this one was completed a while back and merged. We were leaving it open as it was blocked by a frontend migration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: beginner Time needed to do this ticket is less than 1 day. first-timers-friendly Appropriate for first time contributors. good-first-issue Good for newcomers maintenance Maintenance / chore work stale This issue or PR is inactive.
Projects
None yet
Development

No branches or pull requests

3 participants