remove test_old_message tests

Author: link2xt

src/tests/verified_chats.rs

@@ -273,137 +273,6 @@ async fn test_degrade_verified_oneonone_chat() -> Result<()> {
     Ok(())
 }
 
-/// Messages with old timestamps are difficult for verified chats:
-/// - They must not be sorted over a protection-changed info message.
-///   That's what `test_old_message_2` tests
-/// - If they change the protection, then they must not be sorted over existing other messages,
-///   because then the protection-changed info message would also be above these existing messages.
-///   That's what `test_old_message_3` tests.
-///
-/// `test_old_message_1` tests the case where both the old and the new message
-/// change verification
-#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
-async fn test_old_message_1() -> Result<()> {
-    let mut tcm = TestContextManager::new();
-    let alice = tcm.alice().await;
-    let bob = tcm.bob().await;
-    enable_verified_oneonone_chats(&[&alice, &bob]).await;
-
-    mark_as_verified(&alice, &bob).await;
-
-    let chat = alice.create_chat(&bob).await; // This creates a protection-changed info message
-    assert!(chat.is_protected());
-
-    // This creates protection-changed info message #2;
-    // even though the date is old, info message and email must be sorted below the original info message.
-    receive_imf(
-        &alice,
-        b"From: Bob <[email protected]>\n\
-          To: [email protected]\n\
-          Message-ID: <[email protected]>\n\
-          Date: Sat, 07 Dec 2019 19:00:27 +0000\n\
-          \n\
-          Message from Thunderbird\n",
-        true,
-    )
-    .await?;
-
-    alice.golden_test_chat(chat.id, "test_old_message_1").await;
-
-    Ok(())
-}
-
-#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
-async fn test_old_message_2() -> Result<()> {
-    let mut tcm = TestContextManager::new();
-    let alice = tcm.alice().await;
-    let bob = tcm.bob().await;
-    enable_verified_oneonone_chats(&[&alice, &bob]).await;
-
-    mark_as_verified(&alice, &bob).await;
-
-    // This creates protection-changed info message #1:
-    let chat = alice.create_chat(&bob).await;
-    assert!(chat.is_protected());
-    let protection_msg = alice.get_last_msg().await;
-    assert_eq!(
-        protection_msg.param.get_cmd(),
-        SystemMessage::ChatProtectionEnabled
-    );
-
-    // This creates protection-changed info message #2 with `timestamp_sort` greater by 1.
-    let first_email = receive_imf(
-        &alice,
-        b"From: Bob <[email protected]>\n\
-          To: [email protected]\n\
-          Message-ID: <[email protected]>\n\
-          Date: Sun, 08 Dec 2019 19:00:27 +0000\n\
-          \n\
-          Somewhat old message\n",
-        false,
-    )
-    .await?
-    .unwrap();
-
-    // Both messages will get the same timestamp, so this one will be sorted under the previous one
-    // even though it has an older timestamp.
-    let second_email = receive_imf(
-        &alice,
-        b"From: Bob <[email protected]>\n\
-          To: [email protected]\n\
-          Message-ID: <[email protected]>\n\
-          Date: Sat, 07 Dec 2019 19:00:27 +0000\n\
-          \n\
-          Even older message, that must NOT be shown before the info message\n",
-        true,
-    )
-    .await?
-    .unwrap();
-
-    assert_eq!(first_email.sort_timestamp, second_email.sort_timestamp);
-    assert_eq!(
-        first_email.sort_timestamp,
-        protection_msg.timestamp_sort + 1
-    );
-
-    alice.golden_test_chat(chat.id, "test_old_message_2").await;
-
-    Ok(())
-}
-
-#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
-async fn test_old_message_3() -> Result<()> {
-    let mut tcm = TestContextManager::new();
-    let alice = tcm.alice().await;
-    let bob = tcm.bob().await;
-    enable_verified_oneonone_chats(&[&alice, &bob]).await;
-
-    mark_as_verified(&alice, &bob).await;
-    mark_as_verified(&bob, &alice).await;
-
-    tcm.send_recv_accept(&bob, &alice, "Heyho from my verified device!")
-        .await;
-
-    // This unverified message must not be sorted over the message sent in the previous line:
-    receive_imf(
-        &alice,
-        b"From: Bob <[email protected]>\n\
-          To: [email protected]\n\
-          Message-ID: <[email protected]>\n\
-          Date: Sat, 07 Dec 2019 19:00:27 +0000\n\
-          \n\
-          Old, unverified message\n",
-        true,
-    )
-    .await?;
-
-    alice
-        .golden_test_chat(alice.get_pgp_chat(&bob).await.id, "test_old_message_3")
-        .await;
-
-    Ok(())
-}
-
 /// Alice is offline for some time.
 /// When she comes online, first her inbox is synced and then her sentbox.
 /// This test tests that the messages are still in the right order.