Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use device detector to filter bots #277

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tacataca
Copy link

@tacataca tacataca commented Mar 27, 2019

Change the bot filtering system to use the device detector gem.

Very straightforward swap to use a much better maintained list, however introduces an external dependancy. Also updates the rake task.

Took the liberty to also fix some issues with the CI.

Use the device detector gem to identify bots as they have a much better maintained list. Straightforward swap.
- Add a second test for wild card matching.
- A-Online Search doesn't appear on the latest bot user agent lists, so
changing with another example.
Remove nokogiri dependency and update task to use list from
device_detector
@rokumatsumoto
Copy link

rokumatsumoto commented Nov 4, 2019

Hi @johnmcaliley,

Can you or other contributors review this PR?

Thanks!

Copy link

@alexanderkustov alexanderkustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lusinh
Copy link
Contributor

lusinh commented Dec 2, 2020

@tacataca You should resolve conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants