Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Printing in ISR #1

Open
wizard97 opened this issue Jan 17, 2019 · 2 comments
Open

Printing in ISR #1

wizard97 opened this issue Jan 17, 2019 · 2 comments
Labels
bug Something isn't working fixed Fixed Bug

Comments

@wizard97
Copy link

I quickly looked at your Arduino sketch and noticed that you are printing over Serial in your packet handlers. The packet handlers run in an ISR, and printing over Serial in an ISR is undefined behavior.
@charlescao460
Copy link
Owner

Yeah actually I've found that there are some wired things happens to my Arduino Sketch when replacing answers. But it seems to be normal when capturing and sending. Anyway, I am going to refactor the entire sketch. As you might noticed, current sketch is messy and hard to modify (:зゝ∠). I'll let you know when I finish refactor.
Thank you very much for this notice. I didn't know this before.

@charlescao460 charlescao460 mentioned this issue Feb 12, 2019
Closed
@charlescao460 charlescao460 added the bug Something isn't working label Feb 13, 2019
@charlescao460 charlescao460 mentioned this issue Feb 25, 2019
Open
@charlescao460
Copy link
Owner

I've re-written the entire sketch in #5. It should work fine.

@charlescao460 charlescao460 added the fixed Fixed Bug label Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed Fixed Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wizard97 @charlescao460