Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.2.0 fails to build #19

Open
n3m6 opened this issue Sep 17, 2021 · 6 comments
Open

Version 2.2.0 fails to build #19

n3m6 opened this issue Sep 17, 2021 · 6 comments
Assignees
Labels
Waiting_on_requestor Issues/PR where we have responded and are currently waiting on the requestor to respond back

Comments

@n3m6
Copy link

n3m6 commented Sep 17, 2021

The typescript version fails to build. It seems the q library was not imported in the request_wrapper.ts file.

n3m6@yuki:~/work/payments-service$ yarn run build
yarn run v1.22.10
$ rimraf dist
$ nest build
node_modules/chargebee-typescript/lib/request_wrapper.d.ts:1:23 - error TS2688: Cannot find type definition file for 'q'.

1 /// <reference types="q" />
  1 /// <reference types="q" />
                        ~
node_modules/chargebee-typescript/lib/request_wrapper.d.ts:13:48 - error TS2503: Cannot find namespace 'Q'.

13     request(callBack?: any, envOptions?: any): Q.Promise<any>;
                                                  ~

Found 2 error(s).

Version 2.1.0 works fine though.

@mwalden2004
Copy link

I can reproduce this problem, this is affecting a project I am working on right now.

@Tobjoern
Copy link

I can confirm this problem, too. I'm actively affected by this issue.

@cb-yateshmathuria
Copy link
Contributor

Hi All, we have tried to reproduce this issue but we are not able to. Could you please tell us the following :

  1. How did you upgrade from 2.1.0 to 2.2.0?
  2. Could you please provide us your package.json and tsconfig.json files?

Thanks in advance!

@mwalden2004
Copy link

mwalden2004 commented Sep 30, 2021 via email

@cb-yateshmathuria
Copy link
Contributor

@mwalden2004 Thank you for the information.

We can't find chargebee-typescript in your package.json file. please confirm if and how you are using chargebee-typescript package in your project?

@n3m6 - Can you confirm if you are still facing the issue. If yes then could you provide your package.json and tsconfig.json files?

@cb-yateshmathuria cb-yateshmathuria added the Waiting_on_requestor Issues/PR where we have responded and are currently waiting on the requestor to respond back label Dec 15, 2021
@J4YF7O
Copy link

J4YF7O commented Jan 11, 2022

Same for my team : using 2.4.1

  • package.json
    "chargebee-typescript": "^2.4.1",
  • yarn.lock
chargebee-typescript@^2.4.1:
  version "2.4.1"
  resolved "https://registry.yarnpkg.com/chargebee-typescript/-/chargebee-typescript-2.4.1.tgz#e6800c9159f51cd91c43e6c5368a206049abec87"
  integrity sha512-0GdFerq1gIV9vvaAx00ErVMc1wkJBUaIrZw5Sy7ZfkgQZoUQ5Aml9cp8qy4suBTtI1tHLIQcChslS6Mj+grm2A==
  dependencies:
    q ">=1.0.1"
  • q
$ cat node_modules/q/package.json | grep version    
  "version": "1.5.1",

Fix :

yarn add -D @types/q

...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting_on_requestor Issues/PR where we have responded and are currently waiting on the requestor to respond back
Projects
None yet
Development

No branches or pull requests

6 participants