Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide more import system frames in stack traces #889

Closed
mhsmith opened this issue Jun 23, 2023 · 1 comment · Fixed by #1257
Closed

Hide more import system frames in stack traces #889

mhsmith opened this issue Jun 23, 2023 · 1 comment · Fixed by #1257

Comments

@mhsmith
Copy link
Member

mhsmith commented Jun 23, 2023

There is already some code to try and suppress frames from our import system, but it doesn't cover all cases. This makes stack traces much harder to read, e.g. #812 (comment).

Specifically, we should remove:

  • import_override
  • Everything in importlib

Newer versions of Python have a public API for manipulating tracebacks, so we should be able to remove most of these. Ideally it would also cover exceptions that that don't propagate into Java, because they may still be caught and logged.

@mhsmith mhsmith changed the title Hide import_override in stack traces Hide import system frames in stack traces Jun 23, 2023
@mhsmith
Copy link
Member Author

mhsmith commented Oct 7, 2024

This will be improved by #1257, leaving only the following:

@mhsmith mhsmith changed the title Hide import system frames in stack traces Hide more import system frames in stack traces Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant