Merge pull request #16 from m4olivei/14-zero-should-be-supported-unit

Issue #14 support an integer value of 0 as a supported unit.
chapter-three · Feb 14, 2017 · 1312ecf · 1312ecf
2 parents 78cea83 + 3282ddf
commit 1312ecf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Document/Base.php b/src/Document/Base.php
@@ -103,7 +103,7 @@ protected static function isSupportedUnit($value) {
       'cw',
       'pt',
     );
-    $re = '/^[1-9][0-9]*(' . implode('|', $units) . ')?$/';
+    $re = '/^(0|[1-9][0-9]*)(' . implode('|', $units) . ')?$/';
     return preg_match($re, $value);
   }
 

diff --git a/tests/Document/BaseTest.php b/tests/Document/BaseTest.php
@@ -110,7 +110,7 @@ public function testSetters() {
     }
     foreach (array(
         // Integers.
-        1, 10, 515,
+        0, 1, 10, 515,
         // With unit.
         '1vh', '10vw', '515vmin', '1vmax', '1gut', '1cw', '1pt',
       ) as $value
-Original file line number
+Diff line change
@@ Expand Up / @@ -103,7 +103,7 @@ protected static function isSupportedUnit($value) { @@
           'cw',
           'pt',
         );
-        $re = '/^[1-9][0-9]*(' . implode('|', $units) . ')?$/';
+        $re = '/^(0|[1-9][0-9]*)(' . implode('|', $units) . ')?$/';
         return preg_match($re, $value);
       }
@@ Expand Down @@