Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate const declarations into sparse subdomains' definedConst property #26052

Open
bradcray opened this issue Oct 8, 2024 · 0 comments
Open

Comments

@bradcray
Copy link
Member

bradcray commented Oct 8, 2024

Currently, the internal Chapel implementation of domains has a definedConst field that can be used to determine whether the domain was declared as const or var. However, as noted in #25243, this does not seem to be set up for sparse subdomains. This has the downside of disabling the domain localization optimization as noted in #25243 and also means that we can't have the setLocalSubdomain() routine issue an error if the user tries to call it on a const domain (as, I realized today, my test test/distributions/sparseBlock/targLocsLocBlocks.chpl accidentally does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant