Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/Revision Change_Requests_Duration.md #193

Open
klumb opened this issue Oct 26, 2020 · 7 comments
Open

Release/Revision Change_Requests_Duration.md #193

klumb opened this issue Oct 26, 2020 · 7 comments
Labels
Metrics Candidate Release Revisiting Metric Previously released metric that is being revisited and updated

Comments

@klumb
Copy link
Member

klumb commented Oct 26, 2020

This issue was created to collect comments about the upcoming metrics release.

This thread is for comments about Change_Requests_Duration.md

GitHub location: https://github.com/chaoss/wg-evolution/blob/master/metrics/Change_Requests_Duration.md

See all release candidates of metrics are at: https://chaoss.community/metrics/

@klumb
Copy link
Member Author

klumb commented Oct 26, 2020

Name change revision - From "reviews to "change request"

@foundjem
Copy link

Change Request LGTM!

Signed-Off-By: Armstrong [email protected]

@rpaik
Copy link
Member

rpaik commented Feb 16, 2021

Is there a reason why we would not consider PRs/MRs that are not accepted? If a change request is not accepted for valid reasons (e.g. the change would introduce a bug), I think it makes sense to include that change request if the goal of this metrics is to see how responsive reviewers are to change requests.

@foundjem
Copy link

@rpaik, are you suggesting that we include change requests that were not accepted? If that is the case, we may have to consider abandoned circumstances, which will make it almost impossible to compute the duration.

Signed-Off-By: Armstrong [email protected]

@rpaik
Copy link
Member

rpaik commented Feb 16, 2021

@foundjem how about if we consider change requests that have either been accepted or closed? The abandoned change requests will then be excluded.

@klumb
Copy link
Member Author

klumb commented Mar 6, 2021

closing for release

May want to address this last comment in the next release

@klumb klumb closed this as completed Mar 6, 2021
@ElizabethN
Copy link
Member

We need to revisit this metric. The question does not seem to match the rest of the metric definition and when looking through the above comments on this issue, we should clarify the "abandoned requests" nuance as mentioned above.

@ElizabethN ElizabethN reopened this Apr 8, 2022
@ElizabethN ElizabethN added the Revisiting Metric Previously released metric that is being revisited and updated label Apr 8, 2022
@ElizabethN ElizabethN transferred this issue from chaoss/wg-evolution Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metrics Candidate Release Revisiting Metric Previously released metric that is being revisited and updated
Projects
None yet
Development

No branches or pull requests

4 participants