-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/Revision Change_Requests_Duration.md #193
Comments
Name change revision - From "reviews to "change request" |
Change Request LGTM! Signed-Off-By: Armstrong [email protected] |
Is there a reason why we would not consider PRs/MRs that are not accepted? If a change request is not accepted for valid reasons (e.g. the change would introduce a bug), I think it makes sense to include that change request if the goal of this metrics is to see how responsive reviewers are to change requests. |
@rpaik, are you suggesting that we include change requests that were not accepted? If that is the case, we may have to consider abandoned circumstances, which will make it almost impossible to compute the duration. Signed-Off-By: Armstrong [email protected] |
@foundjem how about if we consider change requests that have either been accepted or closed? The abandoned change requests will then be excluded. |
closing for release May want to address this last comment in the next release |
We need to revisit this metric. The question does not seem to match the rest of the metric definition and when looking through the above comments on this issue, we should clarify the "abandoned requests" nuance as mentioned above. |
This issue was created to collect comments about the upcoming metrics release.
This thread is for comments about Change_Requests_Duration.md
GitHub location: https://github.com/chaoss/wg-evolution/blob/master/metrics/Change_Requests_Duration.md
See all release candidates of metrics are at: https://chaoss.community/metrics/
The text was updated successfully, but these errors were encountered: