From 2a97ff6c52c19c496fe428e03b8e66cea284c0d5 Mon Sep 17 00:00:00 2001
From: Jim Garlick <garlick.jim@gmail.com>
Date: Fri, 17 Jan 2025 14:32:04 -0800
Subject: [PATCH] build: drop configure --disable-tests option

Problem: configure --disable-tests doesn't accomplish anything.

Running 'make check' and getting a positive outcome when nothing
was run is misleading.  The right thing to do is to skip individual
tests when features are de-selected.

For now just remove this configure option.
---
 Makefile.am  |  4 ----
 configure.ac | 23 -----------------------
 2 files changed, 27 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 36412dfd..b5440b90 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -3,10 +3,6 @@ SUBDIRS = \
 	man \
 	etc
 
-if ENABLE_TESTS
-  SUBDIRS += tests
-endif
-
 EXTRA_DIST = diod.spec
 
 export DEB_BUILD_OPTIONS ?= nocheck terse
diff --git a/configure.ac b/configure.ac
index 14a18f0c..d25ccf58 100644
--- a/configure.ac
+++ b/configure.ac
@@ -96,10 +96,6 @@ AC_ARG_ENABLE([diodmount],
   [AS_HELP_STRING([--disable-diodmount], [do not build diodmount])],
   [],
   [enable_diodmount=auto])
-AC_ARG_ENABLE([tests],
-  [AS_HELP_STRING([--disable-tests], [do not build tests])],
-  [],
-  [enable_tests=auto])
 AC_ARG_ENABLE([impersonation],
   [AS_HELP_STRING([--enable-impersonation], [allow access=user])],
   [],
@@ -127,12 +123,6 @@ case "${host_os}" in
       *)
         enable_diodmount=yes;;
     esac
-    case "${enable_tests}" in
-      no)
-        ;;
-      *)
-        enable_tests=yes;;
-    esac
     case "${enable_impersonation}" in
       no)
         ;;
@@ -149,12 +139,6 @@ case "${host_os}" in
       *)
         enable_diodmount=no;;
     esac
-    case "${enable_tests}" in
-      yes)
-        ;;
-      *)
-        enable_tests=no;;
-    esac
     case "${enable_impersonation}" in
       no|auto)
         enable_impersonation=no;;
@@ -171,12 +155,6 @@ case "${host_os}" in
       *)
         enable_diodmount=no;;
     esac
-    case "${enable_tests}" in
-      yes)
-        ;;
-      *)
-        enable_tests=no;;
-    esac
     case "${enable_impersonation}" in
       no|auto)
         enable_impersonation=no;;
@@ -187,7 +165,6 @@ case "${host_os}" in
 esac
 
 AM_CONDITIONAL([ENABLE_DIODMOUNT], [test "x${enable_diodmount}" = "xyes"])
-AM_CONDITIONAL([ENABLE_TESTS], [test "x${enable_tests}" = "xyes"])
 AM_CONDITIONAL([USE_IMPERSONATION_LINUX], [test "x${enable_impersonation}" = "xlinux"])
 AM_CONDITIONAL([USE_IMPERSONATION_GANESHA], [test "x${enable_impersonation}" = "xganesha"])