Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization] Add cache header to cache images in the browser and CloudFront #956

Open
tihuan opened this issue May 30, 2024 · 3 comments
Labels
P0 Priority 0 - Critical, fix ASAP! performance Performance testing/tuning, load testing, etc.

Comments

@tihuan
Copy link
Contributor

tihuan commented May 30, 2024

Context:
Currently deep zoom assets aren't cached in the browser, so the browser would still request for the assets even when it already got it

DoD:

  1. Update CloudFront cache header to tell the browser to cache the images for at least an hour

Example:

Header Name: Cache-Control
Header Value: public, max-age=3600

In dev Cloudfront:
Screenshot 2024-05-30 at 9.36.41 AM.png

@tihuan tihuan added P1 Priority 1 - Improvement with wide impact, fix within 1 week performance Performance testing/tuning, load testing, etc. labels May 30, 2024
@tihuan
Copy link
Contributor Author

tihuan commented May 30, 2024

@ebezzi I see that staging spatial-deep-zoom cache behavior currently uses Cache Policy CachingOptimized. Can we add Cache-Control: public and max-age: 3600 on it, or do we need to create a new policy to do that?

Thank you!

@tihuan tihuan added P0 Priority 0 - Critical, fix ASAP! and removed P1 Priority 1 - Improvement with wide impact, fix within 1 week labels May 30, 2024
@tihuan
Copy link
Contributor Author

tihuan commented May 30, 2024

Bumping this to p0, since the zooming experience is significantly better with browser caching enabled

@tihuan
Copy link
Contributor Author

tihuan commented Jul 23, 2024

Still not cached Screenshot 2024-07-23 at 1.57.30 PM.png

@tihuan tihuan changed the title [Optimization] Add cache header to cache images in the browser [Optimization] Add cache header to cache images in the browser and CloudFront Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Priority 0 - Critical, fix ASAP! performance Performance testing/tuning, load testing, etc.
Projects
None yet
Development

No branches or pull requests

1 participant