Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Install' button gives misleading instructions. Make it link to "Installation" in the readme instead #344

Closed
haesleinhuepf opened this issue Nov 28, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@haesleinhuepf
Copy link

haesleinhuepf commented Nov 28, 2021

Description

Hi all,

potential new napari-plugin users might read misleading instructions when clicking the Install button on the napari hub page of a plugin. If those instructions don't work, that's unfortunate especially for users who try for the first time.

These plugins are affected for sure to my knowledge, at least on Windows, because you need to use conda to install prerequesites:

Furthermore, I see also related discussions here:

Steps/Code to Reproduce

On a Windows computer, in a napari bundle app, try to install one of the plugins listed above by following the instructions after clicking the Install button on the napari hub.

Expected Results

It would be great if clicking the Install button would lead to the Installation instructions written by the developers and not to generic instructions that don't work.

Potential alternative: Make the link behind the button configurable and keep its current behaviour as default in case no link is configured.

Thanks!

Best,
Robert

@haesleinhuepf haesleinhuepf added the bug Something isn't working label Nov 28, 2021
@DragaDoncila
Copy link
Collaborator

Potential alternative: Make the link behind the button configurable and keep its current behaviour as default in case no link is configured.

Since many plugin developers may not have an Installation section, I like this option. We could have this as one of the project links in config.yaml and defer to the pip install instructions if this is not explicitly configured by developers.

@neuromusic
Copy link
Collaborator

We could have this as one of the project links in config.yaml and defer to the pip install instructions if this is not explicitly configured by developers.

or .napari/INSTALL.md to replace the copy in the modal?

@neuromusic
Copy link
Collaborator

Thanks for bringing this up @haesleinhuepf !!

When we launched and added the "Install" button, our hope was that we would be able to soon replace the text in the popup with #242, however, as the plugin ecosystem has grown and these issues have surfaced, its clear that the simple instructions are insufficient for many plugins.

I'm optimistic that we can get closer to simplicity for users in 2022 with the work happening on the bundled app with conda support, but in the meantime, I agree that offering support for more complex/advanced installation instructions will be important.

@DragaDoncila
Copy link
Collaborator

or .napari/INSTALL.md to replace the copy in the modal?

This is probably an easier way to provide the content for the modal, but I do worry about the developers having to maintain so many files e.g. README, DESCRIPTION and now INSTALL which they might want in the other two documents? I suppose we could suggest that they include the INSTALL doc if they want it in multiple places?

@haesleinhuepf
Copy link
Author

haesleinhuepf commented Nov 29, 2021

I like the way you both approach this issue. And I agree, the simpler, the better, for both users and developers.

Btw. almost all plugins come with an "Installation" section, because it's part of the plugin template. Thus, I bet this link works in 95% of the cases independent from which [plugin] you enter:

https://napari-hub.org/plugins/[plugin]#installation

@neuromusic
Copy link
Collaborator

I do worry about the developers having to maintain so many files

agreed, but I think the problem is redundancy, not the number of files per se. in other words, plugin developers should only have to specify installation instructions once and this should be easily accessed from Github (via a shield?) or the napari hub page.

@neuromusic
Copy link
Collaborator

as the "stardist on windows" blog post highlights, much of the complexity here comes down to tailoring the installation to the user's environment (Win vs Mac vs Linux, for example) OR configuration options (such as cellpose's different installation paths for CPU and GPU).

@neuromusic
Copy link
Collaborator

Since the current functionality is consistent with how we designed the "Install button" feature (e.g. its not immediately actionable as a bug, but needs some design and implementation considerations), I'm going to move this to Discussions so we can try to tackle a better solution in Q1

@chanzuckerberg chanzuckerberg locked and limited conversation to collaborators Dec 1, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants