Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks with no output can't be cached #715

Open
adamnovak opened this issue Sep 12, 2024 · 0 comments
Open

Tasks with no output can't be cached #715

adamnovak opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working starter new contributors might start here

Comments

@adamnovak
Copy link
Contributor

I'm trying to plug Toil into MiniWDL's call caching, so I tried a simple workflow that runs a task with no outputs:

version 1.1

workflow TestWorkflow {
    input {
    }
    call TestTask {
    input:
    }
    output {
    }
}

task TestTask {
    input {
    }
    command <<<
        ls
    >>>
    output {
        Int number = 1
    }
    runtime {
        container: "ubuntu:latest"
        cpu: 1
    }
}

The result of the task can be added to the cache, but CallCache.get() always sees it as a cache miss, because the deserialized {} output JSON is a falsy empty dict.

if cache:

Probably the condition should have an is not None.

@mlin mlin added bug Something isn't working starter new contributors might start here labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working starter new contributors might start here
Projects
Status: Backlog
Development

No branches or pull requests

2 participants