Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge flowline #226

Open
changliao1025 opened this issue Jul 20, 2024 · 4 comments
Open

Edge flowline #226

changliao1025 opened this issue Jul 20, 2024 · 4 comments

Comments

@changliao1025
Copy link
Owner

There is a chance that a flowline passes through a bay cell like this:
image

This will cause a bug for the intersection algorithm.

@changliao1025
Copy link
Owner Author

In a reasonable scenario, the user should provide a flowline that "sticks out" of the study domain, which is defined by the boundary file. However, because the mesh resolution cannot fully describe the boundary file, such as the coastal line, it is possible to have this type of data quality issue.

@changliao1025
Copy link
Owner Author

To fix this issue programmingly instead of manually, it is possible to let the intersection algorithm automatically cut off the tail.

@changliao1025
Copy link
Owner Author

The requirement to fix this includes that the algorithm must know which flowline is the last one that sticks out, this information is stored within the "simplified flowline".

@changliao1025
Copy link
Owner Author

changliao1025 commented Jul 21, 2024

Multiple functions ensure that the first flowline is the last segment flows out of the domain.
We can also use the max segment index as the indicator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant