Fetch items by id, including children comments (#2)

* Groundwork for dynamic API endpoint

* Process path parameter and fetch data based on request

* Include tslint

* Initial attempt to fetch child comments

* Do not fetch kids if item is null

Author: chandlerwall

README.md

@@ -6,3 +6,6 @@
 Attempts to incorporate `webpack` have failed. Consider reviewing the commit history to see the various configurations that did not work. Simple functions operated without issue, but functions with Firebase functionality fail. The issue appeared to be caused by async/await functionality, but Promises in general had issues.
 
 At some point in the future, `dom` should be removed as a library. Additionally, `webpack` should be included. `webpack` is important due to its ability to reduce bundle sizes and streamline code generation. The bundle size without webpack is ~16MB for ANY function. With webpack, the `hello` function drops to ~3KB while hn-api drops to ~350KB.
+
+## Future Reference
+Do not use `console.dir()` with AWS. The logs are difficult to decipher (line breaks prevent useful grouping).

data/api-request-event-real.json

@@ -0,0 +1,43 @@
+{
+  "resource:": "/api/v1/item/{id}",
+  "path:": "/api/v1/item/12345",
+  "httpMethod:": "GET",
+  "headers:": null,
+  "multiValueHeaders:": null,
+  "queryStringParameters:": null,
+  "multiValueQueryStringParameters:": null,
+  "pathParameters:": {
+    "id:": "12345"
+  },
+  "stageVariables:": null,
+  "requestContext:": {
+    "path:": "/api/v1/item/{id}",
+    "accountId:": "729037857495",
+    "resourceId:": "zuwcux",
+    "stage:": "test-invoke-stage",
+    "domainPrefix:": "testPrefix",
+    "requestId:": "10891e3b-1c4a-11e9-8662-67f5384b099c",
+    "identity:": {
+      "cognitoIdentityPoolId:": null,
+      "cognitoIdentityId:": null,
+      "apiKey:": "test-invoke-api-key",
+      "cognitoAuthenticationType:": null,
+      "userArn:": "arn:aws:sts::729037857495:assumed-role/OrganizationAccountAccessRole/chandler",
+      "apiKeyId:": "test-invoke-api-key-id",
+      "userAgent:": "aws-internal/3 aws-sdk-java/1.11.465 Linux/4.9.137-0.1.ac.218.74.329.metal1.x86_64 OpenJDK_64-Bit_Server_VM/25.192-b12 java/1.8.0_192",
+      "accountId:": "729037857495",
+      "caller:": "AROAJFXXJ5BJW7Q32FK52:chandler",
+      "sourceIp:": "test-invoke-source-ip",
+      "accessKey:": "ASIA2TPQK4LLZJDJIRUX",
+      "cognitoAuthenticationProvider:": null,
+      "user:": "AROAJFXXJ5BJW7Q32FK52:chandler"
+    },
+    "domainName:": "testPrefix.testDomainName",
+    "resourcePath:": "/api/v1/item/{id}",
+    "httpMethod:": "GET",
+    "extendedRequestId:": "Txr6qE39PHcF7Fw=",
+    "apiId:": "jo0norcal4"
+  },
+  "body:": null,
+  "isBase64Encoded:": false
+}

data/api-request-event.json

@@ -0,0 +1,63 @@
+{
+  "body": "eyJ0ZXN0IjoiYm9keSJ9",
+  "resource": "/{proxy+}",
+  "path": "/path/to/resource",
+  "httpMethod": "POST",
+  "isBase64Encoded": true,
+  "queryStringParameters": {
+    "foo": "bar"
+  },
+  "pathParameters": {
+    "proxy": "/path/to/resource",
+    "id": "8863"
+  },
+  "stageVariables": {
+    "baz": "qux"
+  },
+  "headers": {
+    "Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8",
+    "Accept-Encoding": "gzip, deflate, sdch",
+    "Accept-Language": "en-US,en;q=0.8",
+    "Cache-Control": "max-age=0",
+    "CloudFront-Forwarded-Proto": "https",
+    "CloudFront-Is-Desktop-Viewer": "true",
+    "CloudFront-Is-Mobile-Viewer": "false",
+    "CloudFront-Is-SmartTV-Viewer": "false",
+    "CloudFront-Is-Tablet-Viewer": "false",
+    "CloudFront-Viewer-Country": "US",
+    "Host": "1234567890.execute-api.us-west-2.amazonaws.com",
+    "Upgrade-Insecure-Requests": "1",
+    "User-Agent": "Custom User Agent String",
+    "Via": "1.1 08f323deadbeefa7af34d5feb414ce27.cloudfront.net (CloudFront)",
+    "X-Amz-Cf-Id": "cDehVQoZnx43VYQb9j2-nvCh-9z396Uhbp027Y2JvkCPNLmGJHqlaA==",
+    "X-Forwarded-For": "127.0.0.1, 127.0.0.2",
+    "X-Forwarded-Port": "443",
+    "X-Forwarded-Proto": "https"
+  },
+  "requestContext": {
+    "accountId": "123456789012",
+    "resourceId": "123456",
+    "stage": "prod",
+    "requestId": "c6af9ac6-7b61-11e6-9a41-93e8deadbeef",
+    "requestTime": "09/Apr/2015:12:34:56 +0000",
+    "requestTimeEpoch": 1428582896000,
+    "identity": {
+      "cognitoIdentityPoolId": null,
+      "accountId": null,
+      "cognitoIdentityId": null,
+      "caller": null,
+      "accessKey": null,
+      "sourceIp": "127.0.0.1",
+      "cognitoAuthenticationType": null,
+      "cognitoAuthenticationProvider": null,
+      "userArn": null,
+      "userAgent": "Custom User Agent String",
+      "user": null
+    },
+    "path": "/prod/path/to/resource",
+    "resourcePath": "/{proxy+}",
+    "httpMethod": "POST",
+    "apiId": "1234567890",
+    "protocol": "HTTP/1.1"
+  }
+}

package-lock.json

@@ -3,9 +3,11 @@
   "version": "0.1.0",
   "description": "Serverless webpack example using Typescript",
   "scripts": {
+    "lint": "tslint --project .",
     "compile": "tsc",
+    "build": "npm run lint && npm run compile",
     "compile:watch": "npm run compile -- --watch",
-    "predeploy:dev": "npm run compile",
+    "predeploy:dev": "npm run build",
     "deploy:dev": "serverless deploy --stage dev",
     "preoffline": "npm run compile",
     "offline": "serverless offline",
@@ -21,6 +23,7 @@
     "serverless": "^1.36.1",
     "serverless-offline": "^4.1.4",
     "source-map-support": "^0.5.6",
+    "tslint": "^5.12.1",
     "typescript": "^3.2.4"
   },
   "author": "Chandler Wall",

package.json

@@ -18,10 +18,10 @@ functions:
     events:
       - http:
           method: get
-          path: hello
+          path: api/v1/meta/health
   hn-api:
     handler: dist/hn-api.hn
     events:
       - http:
           method: get
-          path: hn
+          path: api/v1/item/{id}

serverless.yml

@@ -1,12 +1,13 @@
 import {APIGatewayProxyHandler} from "aws-lambda";
 
 export const hello: APIGatewayProxyHandler = async (event, context) => {
+  // TODO - This function needs to be come a health check.
   return {
     statusCode: 200,
     body: JSON.stringify({
       message: "Go Serverless Webpack (Typescript) v1.0! Your function executed successfully!",
       input: event,
-      context: context,
+      context,
     }),
   };
 };