New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secondary addon module issue #25

Closed

vaDrn opened this issue Jun 30, 2021 · 4 comments · Fixed by #26

Assignees

Labels

vaDrn commented Jun 30, 2021 •

edited

Loading

SEPXXX.cnf.xml file generated by sccp manager contains only one entry for an addon module.
I tried adding cisco 7960 with two 7914 expansion modules and cisco 7965 with two 7916 modules with same results. Generated .cnf.xml file looks like this:

<addOnModules><addOnModule idx="1"><loadInformation>S00105000400</loadInformation></addOnModule></addOnModules></device>

Everything works without issues if I add second addon module entry manually through text editor:

  <addOnModules>
   <addOnModule idx="1"><loadInformation>S00105000400</loadInformation></addOnModule>
   <addOnModule idx="2"><loadInformation>S00105000400</loadInformation></addOnModule>
  </addOnModules>
</device>

The text was updated successfully, but these errors were encountered:

dkgroot assigned dkgroot and steve-lad and unassigned dkgroot

dkgroot added the Branch Develop label

Member

dkgroot commented Jul 3, 2021

Hmm I thought i had already addressed this in one but apparently was only a partial PR
PhantomVl/sccp_manager#105

@steve-lad Should at least give an indication where to look (I hope)

steve-lad added a commit that referenced this issue


          Fix Issue #25

c1aab66

Fix incorrect separator and key reference.

steve-lad added a commit that referenced this issue


          Revert "Fix Issue #25"

6fa4c86

This reverts commit c1aab66.

steve-lad added a commit that referenced this issue


          Revert "Revert "Fix Issue #25""

4ad3385

This reverts commit 6fa4c86.

steve-lad mentioned this issue

Fix issue #25 #26

Merged

steve-lad closed this as completed in #26

steve-lad added a commit that referenced this issue


          Merge pull request #26 from chan-sccp/Fix-Issue-#25

5af3c7d

Fix issue #25

Collaborator

steve-lad commented Jul 6, 2021

@vaDrn Please could you verify this fix - the xml in the cnf is not so elegant but should work.
@dkgroot has proposed a separate modification to tidy up the xml

Collaborator

steve-lad commented Jul 6, 2021

Fixes issue PhantomVl/sccp_manager#104

Author

vaDrn commented Jul 6, 2021

Yes, everything seems to be working fine. Generated cnf file looks correct. @steve-lad HUGE thanks for you work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment