Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on genji version #261

Closed
tdemin opened this issue Oct 15, 2020 · 4 comments · Fixed by #262
Closed

Panic on genji version #261

tdemin opened this issue Oct 15, 2020 · 4 comments · Fixed by #262
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/
Milestone

Comments

@tdemin
Copy link
Contributor

tdemin commented Oct 15, 2020

After having run go get -u -v github.com/genjidb/genji/cmd/genji, trying to run genji version results in this output:

~ > genji version
Using z.Allocator with starting ref: c74a000000000000
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x919018]

goroutine 1 [running]:
main.main.func2(0xc00007cb80, 0x1, 0x1)
        /home/tdemin/go/src/github.com/genjidb/genji/cmd/genji/main.go:100 +0x58
github.com/urfave/cli.(*Command).Run(0xc0000f6d80, 0xc00007cac0, 0x0, 0x0)
        /home/tdemin/go/src/github.com/urfave/cli/command.go:163 +0x4ed
github.com/urfave/cli.(*App).RunContext(0xc000001980, 0xb69e00, 0xc0000281f0, 0xc00000e080, 0x2, 0x2, 0x0, 0x0)
        /home/tdemin/go/src/github.com/urfave/cli/app.go:306 +0x81f
github.com/urfave/cli.(*App).Run(...)
        /home/tdemin/go/src/github.com/urfave/cli/app.go:217
main.main()
        /home/tdemin/go/src/github.com/genjidb/genji/cmd/genji/main.go:143 +0x612
@tdemin
Copy link
Contributor Author

tdemin commented Oct 15, 2020

The Git commit I built Genji from is 375ed7a.

@asdine asdine added bug Something isn't working good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/ labels Oct 15, 2020
@asdine
Copy link
Collaborator

asdine commented Oct 15, 2020

I supposed you run go get outside of a module? When that happens debug.ReadBuildInfo returns nil, which then panics here: https://github.com/genjidb/genji/blob/375ed7aafa0f1d508d14671adb450ac6eb4789dd/cmd/genji/main.go#L100

@tie
Copy link
Contributor

tie commented Oct 15, 2020

I think we should also provide official binaries via GitHub releases. The GOPATH go get is essentially development version, so we can’t do much about it.

@asdine asdine linked a pull request Oct 17, 2020 that will close this issue
@asdine
Copy link
Collaborator

asdine commented Oct 17, 2020

Closed by #262

@tie good idea, I added an issue about that here #269

@asdine asdine closed this as completed Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants