Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconnect event to ReconnectingWebsocket #106

Closed
wants to merge 1 commit into from

Conversation

chadxz
Copy link
Owner

@chadxz chadxz commented Oct 31, 2018

Closes #101.

@chadxz
Copy link
Owner Author

chadxz commented Oct 31, 2018

@GolDiV this is the code change i was describing in #101, but I have not tested it yet. I need to set back up my asterisk VM so i can give it a go in a real world scenario. Also needs tests.

Do you think an API like this would be sufficient for what you need?

@chadxz chadxz force-pushed the 101-reconnect-events branch from 12a98fd to 0a548d3 Compare October 31, 2018 07:09
@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #106   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         387    396    +9     
=====================================
+ Hits          387    396    +9
Impacted Files Coverage Δ
src/events/ReconnectingWebSocket.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315ef7f...0a548d3. Read the comment docs.

@chadxz chadxz closed this May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events of attempts to reconnect
1 participant