Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "create_depth_map_from_gempy" creates seemingly correct but very very small surfaces (wrong scale) #333

Open
phasyn8 opened this issue Jul 18, 2024 · 3 comments
Assignees
Labels
bug Something isn't working dependencies An issue related to the GemGIS dependencies
Milestone

Comments

@phasyn8
Copy link

phasyn8 commented Jul 18, 2024

Describe the bug
Visualization tool outputs wrong depth for: "create_depth_maps_from_gempy()"

The following line of code I believe is to blame:

1690: # Append depth to PolyData
1691: surf['Depth [m]'] = geo_model.solutions.raw_arrays.vertices[index][:, 2]\

The surfaces appear to still be correct but they occur in the wrong scale (much, much smaller)

To Reproduce
Steps to reproduce the behavior:

  1. make: gempy model , geo_model
  2. define: surface_list [surface1, surface2, ...]
  3. create depth map with: "gg.visualization.create_depth_maps_from_gempy(geo_model, surfaces=surface_list)
  4. Display poly data surfaces:
  5. See that surfaces are very very small ( <<1 meter )

Expected behavior
Surfaces should be scaled to the dimensional units used in the model extents

Desktop (please complete the following information):

  • OS: [macOS]
  • VScode
  • Version: 1.91.0
Copy link

Hello and welcome! Thanks for posting your first issue in the GemGIS project! Someone from our developers will get back to you. If your question is support related, we may transfer it to the Discussions.

@AlexanderJuestel
Copy link
Collaborator

Dear @phasyn8, thanks for mentioning that. In efforts to make GemGIS compatible with the latest versions of GemPy, GeoPandas and NumPy, I will put this on the list of To-Dos

@AlexanderJuestel AlexanderJuestel self-assigned this Jul 20, 2024
@AlexanderJuestel AlexanderJuestel added bug Something isn't working dependencies An issue related to the GemGIS dependencies labels Jul 20, 2024
@AlexanderJuestel AlexanderJuestel added this to the GemGIS 1.2 milestone Jul 20, 2024
@AlexanderJuestel AlexanderJuestel changed the title "create_depth_map_from_gempy" creates seemingly correct but very very small surfaces (wrong scale) [BUG] "create_depth_map_from_gempy" creates seemingly correct but very very small surfaces (wrong scale) Jul 20, 2024
AlexanderJuestel added a commit that referenced this issue Jul 20, 2024
@AlexanderJuestel
Copy link
Collaborator

Fixed in 3bd4087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies An issue related to the GemGIS dependencies
Projects
None yet
Development

No branches or pull requests

2 participants