Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Dynamic configuration for running nginx inside Docker #53

Closed
jmarin opened this issue Jun 3, 2015 · 5 comments
Closed

Dynamic configuration for running nginx inside Docker #53

jmarin opened this issue Jun 3, 2015 · 5 comments

Comments

@jmarin
Copy link
Contributor

jmarin commented Jun 3, 2015

Right now the API Proxy backend is hardcoded into the nginx.conf file. Investigate ways to make it configurable at runtime

@jmarin jmarin added this to the M3 milestone Jun 3, 2015
@hkeeler
Copy link
Member

hkeeler commented Jun 3, 2015

I think Automated Nginx Reverse Proxy for Docker describes the problem pretty well. His solution is to use the nginx-proxy Docker image, which uses docker-gen under the hood...both of which he wrote. :) It looks straightforward, and seems to have some traction in the community. Seems worth investigating further.

@jmarin, I think you had some alternatives as well?

@jmarin
Copy link
Contributor Author

jmarin commented Jul 31, 2015

@hkeeler @awolfe76 Since this is not a production website that will be exposed to the public, but more a test app, I think the easiest path would be to serve the content with Node.js and call it a day. The node server would proxy requests to the underlying APIs by reading environment variables passed at runtime, as we do with other services.
Thoughts?

@hkeeler
Copy link
Member

hkeeler commented Aug 3, 2015

Per today's standup, we decided to stick with Nginx for now, and just get CORS working for grasshopper API. This work will be tracked under cfpb/grasshopper#125.

@awolfe76
Copy link
Contributor

awolfe76 commented Aug 3, 2015

👍 Working toward that, leaving nginx.conf as is for now.

@awolfe76
Copy link
Contributor

Closing. #76 didn't close this but we're in an ok place. Can re-open if needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants