Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Optimize img tag #2

Open
kirillzakharov opened this issue Apr 25, 2018 · 10 comments
Open

Suggestion: Optimize img tag #2

kirillzakharov opened this issue Apr 25, 2018 · 10 comments

Comments

@kirillzakharov
Copy link
Contributor

Noticed there's an alt tag:

<img alt="Tim" src="tim.jpg">

I'd try something like this:

<img src="tim.jpg">

To save a few more bites I'd also rename the file to t.jpg. Better yet, use Base64.

@kirillzakharov kirillzakharov self-assigned this Apr 25, 2018
@kirillzakharov
Copy link
Contributor Author

I've removed the alt tag, but couldn't rename tim.jpg. Apparently you can't rename images on GitHub? I ain't pulling this repo down.

@Magellol
Copy link
Contributor

@kirillzakharov I'm not sure I agree with the base64 version. We'll have to see if removing an extra HTTP request is better than increasing the size of the HTML size. Could we benchmark it?

@kirillzakharov
Copy link
Contributor Author

kirillzakharov commented Apr 25, 2018

How come @Magellol is an Owner and I'm a Member. Wtf @lukechesser.

screen shot 2018-04-25 at 7 15 08 pm

@lukechesser
Copy link
Contributor

Cause you have stupid suggestions Kirill. See #1. That's the reason why Thomas is considered an owner. He's the reason this project will succeed.

@Magellol Magellol added the seo label Apr 26, 2018
@kirillzakharov
Copy link
Contributor Author

screen shot 2018-04-25 at 10 21 39 pm

@lukechesser Do you see this? Look at it.

@lukechesser
Copy link
Contributor

And look at how garbage the code is. Also. 8 commits lol. Wtf took 8 commits in this repo haha

@naoufal
Copy link

naoufal commented Apr 26, 2018

@Magellol @kirillzakharov @lukechesser Took the liberty of benchmarking it.

screen shot 2018-04-25 at 8 23 26 pm
Source

We should start by running the image through ImageOptim and then hosting the image on a CDN (upload it to Unsplash so that those suckers can pay bill 😏).

That should get you straight A's for the folks visiting the bones from Rose Hill, Mauritius.

@kirillzakharov
Copy link
Contributor Author

@naoufal Thanks for this. The original image was cloned from http://cesttim.com/

I did a few more tests on GTMetrix:

screen shot 2018-04-25 at 11 41 38 pm
Source

No favicon is unacceptable.

@Magellol
Copy link
Contributor

Magellol commented Apr 26, 2018

Also the SEO is probably not great. Needs at least more meta tags. I will tag this issue with the appropriate label so the SEO folks can look at it.

@lukechesser
Copy link
Contributor

Did someone say SEO? I'm a pro now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants