-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Optimize img tag #2
Comments
I've removed the |
@kirillzakharov I'm not sure I agree with the base64 version. We'll have to see if removing an extra HTTP request is better than increasing the size of the HTML size. Could we benchmark it? |
How come @Magellol is an |
Cause you have stupid suggestions Kirill. See #1. That's the reason why Thomas is considered an owner. He's the reason this project will succeed. |
@lukechesser Do you see this? Look at it. |
And look at how garbage the code is. Also. 8 commits lol. Wtf took 8 commits in this repo haha |
@Magellol @kirillzakharov @lukechesser Took the liberty of benchmarking it. We should start by running the image through ImageOptim and then hosting the image on a CDN (upload it to Unsplash so that those suckers can pay bill 😏). That should get you straight A's for the folks visiting the bones from Rose Hill, Mauritius. |
@naoufal Thanks for this. The original image was cloned from http://cesttim.com/ I did a few more tests on GTMetrix: No favicon is unacceptable. |
Also the SEO is probably not great. Needs at least more meta tags. I will tag this issue with the appropriate label so the SEO folks can look at it. |
Did someone say SEO? I'm a pro now. |
Noticed there's an alt tag:
<img alt="Tim" src="tim.jpg">
I'd try something like this:
<img src="tim.jpg">
To save a few more bites I'd also rename the file to
t.jpg
. Better yet, use Base64.The text was updated successfully, but these errors were encountered: