Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sklearn-like API #243

Open
bnaul opened this issue Mar 17, 2017 · 4 comments
Open

More sklearn-like API #243

bnaul opened this issue Mar 17, 2017 · 4 comments
Assignees

Comments

@bnaul
Copy link
Contributor

bnaul commented Mar 17, 2017

Currently we have a functional API with static methods like build_model.build_model_from_featureset and predict.model_predictions. Not only are these a bit of a mouthful, they're also a bit unintuitive because of how differently they are used than the corresponding sklearn functionality. I suggest that we try to modify our API to be more like that of sklearn, specifically:

  1. Add a Model class that wraps a sklearn model and provides an sklearn-like API (.fit, .predict, .predict_proba) for interacting with Featureset objects.
  2. (optional) Also change featurize to behave more like an sklearn preprocessor; maybe you'd initialize a Featureset and call .transform on a dataset? This is less obvious but there's probably some improvement to be made here as well.
@stefanv
Copy link
Contributor

stefanv commented Mar 17, 2017

I am very much in favor of this proposal.

@acrellin
Copy link
Member

Me too, and would like to hear more about what you have in mind regarding point 2.
👍

@bnaul
Copy link
Contributor Author

bnaul commented Mar 17, 2017

@arita37
Copy link

arita37 commented Jul 17, 2017

Additionnally, keeping api matching with Pandas and numpy would be a plus for better usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants