Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self upgrade PRs don't run checks #1546

Open
SgtCoDFish opened this issue Sep 5, 2024 · 1 comment
Open

Self upgrade PRs don't run checks #1546

SgtCoDFish opened this issue Sep 5, 2024 · 1 comment

Comments

@SgtCoDFish
Copy link
Member

See e.g. #1545

The required check didn't run until I closed + reopened the PR. This PR should instead be automatically merged if tests pass. From a discussion with @inteon and @wallrj this is apparently a known issue.

At a minimum we should document this flaw. Ideally it should be fixed of course!

@SgtCoDFish
Copy link
Member Author

@wallrj suggested the cause may be related to https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow - specifically:

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant