Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include GIF handling in image processing script #243

Closed
adamduncan opened this issue Jul 2, 2021 · 1 comment · Fixed by #244
Closed

Include GIF handling in image processing script #243

adamduncan opened this issue Jul 2, 2021 · 1 comment · Fixed by #244
Assignees
Labels
bug Something isn't working

Comments

@adamduncan
Copy link
Collaborator

adamduncan commented Jul 2, 2021

Currently we only support processing of jpg, png and svg.

We also need to support gif. I expect we'll need to update the scripts/images.js build task to include this extension, and make use of imagemin-gifsicle or similar.

See current PR in need of this support: #236

@Pete-Robelou
Copy link
Collaborator

All done.

I set the number of colours to 96, this offers a reasonable level of compression without degrading the image too much. Our mileage will vary a bit though depending on the image, ideally we need to encourage the use of jpg for photography and png for everything else.

There is also webp but that's a discussion for another day 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants