Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: add types.Snapshot interface #4902

Merged
merged 2 commits into from
Oct 17, 2024
Merged

rbd: add types.Snapshot interface #4902

merged 2 commits into from
Oct 17, 2024

Conversation

nixpanic
Copy link
Member

The rbdSnapshot/rbdImage object implements all functions for a useful
Snapshot interface. The rbd.Manager will be able to use this for
providing VolumeGroupSnapshot support.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@nixpanic nixpanic mentioned this pull request Oct 11, 2024
Open
@mergify mergify bot added the component/rbd Issues related to RBD label Oct 11, 2024
@nixpanic nixpanic requested a review from a team October 11, 2024 08:12
yati1998
yati1998 reviewed Oct 14, 2024
View reviewed changes
internal/rbd/snapshot.go Outdated Show resolved Hide resolved
@nixpanic
Copy link
Member Author

@yati1998 and @Rakshith-R , I've dropped the GetReadyToUse() function now. Please have a look again.

@nixpanic nixpanic requested a review from a team October 14, 2024 15:33
@nixpanic
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 17, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
rbd: use GetCreationTime() to build the CSI-Snapshot object
76654c8 
Signed-off-by: Niels de Vos <[email protected]>
@nixpanic
rbd: add types.Snapshot interface
3fb53c1 
The rbdSnapshot/rbdImage object implements all functions for a useful
Snapshot interface. The rbd.Manager will be able to use this for
providing VolumeGroupSnapshot support.

Signed-off-by: Niels de Vos <[email protected]>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Oct 17, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Oct 17, 2024
@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.30

@nixpanic
Copy link
Member Author

/test ci/centos/mini-e2e/k8s-1.30

@Madhu-1 , there seems to be a CephFS VolumeGroupSnapshot issue logs:

[FAILED] failed to test volumeGroupSnapshot: failed to delete volume group snapshot: failed to get VolumeGroupSnapshot: client rate limiter Wait returned an error: context deadline exceeded

@nixpanic
Copy link
Member Author

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 17, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e/k8s-1.30

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e/k8s-1.30

Failed in a similar ways as before logs:

  [FAILED] failed to test volumeGroupSnapshot: failed to delete volume group snapshot: failed to get VolumeGroupSnapshot: client rate limiter Wait returned an error: context deadline exceeded

  In [It] at: /go/src/github.com/ceph/ceph-csi/e2e/cephfs.go:2490 @ 10/17/24 10:01:18.951

@mergify mergify bot merged commit a51a6ae into ceph:devel Oct 17, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yati1998 yati1998 yati1998 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees
No one assigned
Labels
component/rbd Issues related to RBD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nixpanic @ceph-csi-bot @yati1998 @Rakshith-R