Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a makefile target for markdown linter check #159

Open
Madhu-1 opened this issue Oct 18, 2024 · 4 comments
Open

Add a makefile target for markdown linter check #159

Madhu-1 opened this issue Oct 18, 2024 · 4 comments
Assignees

Comments

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 18, 2024

Not sure what is the standard in this project, but wouldn't it be nice and convenient to add a make target for running markdown lint so that it can easily be invoked locally by developers
and this same make target would be invoked in the ci workflow?

@nb-ohad , @Madhu-1 - wdyt?

Originally posted by @obnoxxx in #16 (comment)

@nb-ohad
Copy link
Collaborator

nb-ohad commented Oct 20, 2024

@Madhu-1 Why do we need a markdown target where tunning the linter is already a one-liner?
If my assumption about the request is wrong, and the intent her is that we will run multiple linter using a single command then I am ok with this

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Oct 21, 2024

The request is to have a makefile target that uses the same version of linter that we have in CI and also passes the right configuration file where the developer does need not to worry about running static checks

@obnoxxx
Copy link
Collaborator

obnoxxx commented Dec 3, 2024

/assign

Copy link

github-actions bot commented Dec 3, 2024

Thanks for taking this issue! Let us know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants