Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntegrationTests: Port non-generic tests into generic module #1790

Closed
lemunozm opened this issue Apr 2, 2024 · 0 comments · Fixed by #1805
Closed

IntegrationTests: Port non-generic tests into generic module #1790

lemunozm opened this issue Apr 2, 2024 · 0 comments · Fixed by #1805
Assignees
@lemunozm
Labels
crcl-protocol Circle protocol related. I4-tests Test needs fixing or improving. Q3-medium Can be done with good experience in the language, but little knowledge of the codebase.

Comments

@lemunozm
Copy link
Contributor

lemunozm commented Apr 2, 2024 •
edited
Loading

Description

This implies port:

This allows:

  • Remove all utilities needed right now just for the above modules (runtime/integration-tests/src/util/* modules).
  • Better maintenability for future upgrades.
@lemunozm lemunozm added Q3-medium Can be done with good experience in the language, but little knowledge of the codebase. I4-tests Test needs fixing or improving. crcl-protocol Circle protocol related. labels Apr 2, 2024
This was referenced Apr 8, 2024
Merged
Merged
@lemunozm lemunozm self-assigned this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lemunozm lemunozm

Labels
crcl-protocol Circle protocol related. I4-tests Test needs fixing or improving. Q3-medium Can be done with good experience in the language, but little knowledge of the codebase.
Projects
None yet
Milestone
No milestone
1 participant
@lemunozm