Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Feedback on new designs #2471

Open
kattylucy opened this issue Oct 4, 2024 · 38 comments
Open

Product Feedback on new designs #2471

kattylucy opened this issue Oct 4, 2024 · 38 comments
Assignees

Comments

@kattylucy
Copy link
Collaborator

kattylucy commented Oct 4, 2024

I created this ticket for product to use as the placeholder and add the feedback during testing.

What are we testing?

Landing page (/pools)
Pool overview page (/pools/:poolId)
Reports page (pools/reporting/)
Data page (pools/data)
Creating a pool and updating a pool in the configuration tab

It relates to all the work in the following tickets

#2392
#2391
#2390
#2427
#2459
#2460

@kattylucy kattylucy self-assigned this Oct 4, 2024
@kattylucy kattylucy mentioned this issue Oct 4, 2024
1 task
@0x4Graham
Copy link

Hey!

Looks like updating the Target APY isn't working:
image
image

Never updated
image

@0x4Graham
Copy link

image Very very difficult to click on this

@sonam-jo
Copy link

sonam-jo commented Oct 4, 2024

For funds that have only 1 tranche, we should just have the name of the fund under Token, and Token price in the chart -- no junior -- same as the UI today
Screenshot 2024-10-04 at 13 14 15
Screenshot 2024-10-04 at 13 13 16

@sonam-jo
Copy link

sonam-jo commented Oct 4, 2024

Axis for APY chart looks off -- it neither is the same for all time windows, nor does it adjust to show the graph properly with different time windows

Screenshot 2024-10-04 at 13 16 14
Screenshot 2024-10-04 at 13 16 23
Screenshot 2024-10-04 at 13 16 33

@sonam-jo
Copy link

sonam-jo commented Oct 4, 2024

The only item missing from this Overview box is Expense ratio.

  1. Expense ratio is something we calculate, and should appear in every fund we create as long as we have the fees numbers and the NAV.
  2. There is a lot of blank space in the overview box. I would recommend increasing the spacing across the rows in line with Figma, and perhaps reducing the side of the chart so there is less white space on the page.
  3. There seems to be a difference in the font size for the titles (e.g. Asset type) and the respective fields (e.g. Private credit)

Screenshot 2024-10-04 at 13 19 33

@sonam-jo
Copy link

sonam-jo commented Oct 4, 2024

Transaction history table is not the same as FIgma

Screenshot 2024-10-04 at 13 24 36
Screenshot 2024-10-04 at 13 24 47

@0x4Graham
Copy link

Create pool button has the wrong colour
image

@0x4Graham
Copy link

When creating a pool, the APR for the tranche is also not set:

image

@0x4Graham
Copy link

When creating the pool, I only named the token "Twirl".

image

But the token name in the display is: Twirl Junior junior. Which shouldn't be the case.

@kattylucy
Copy link
Collaborator Author

The expense ratio is there but probably for this specific pool is 0 so it does not show.

For the APY, can you give me a bit more context on what do you mean? The filter is changing the APY based on if 30 days, 90 days, YTD. is this not what we want?

Image

@sonam-jo

@hieronx
Copy link
Contributor

hieronx commented Oct 9, 2024

Overall it looks amazing, really nice job @kattylucy ! Excited to see this go live soon.

I have quite a list of QA feedback, but they are almost all very small points :)

Landing page

  • The full pool cards should be clickable, now the white space at the bottom half isn't.

  • The ordering of the tranches should be senior at the top, rather than junior at the top.

  • For the min investment fields, the prefix $ sign is missing.

  • The color gray of the Total value locked (TVL) heading seems too light (#cfcfcf vs #82888D in design).

  • There should be more padding on the right side of the Governance submenu:

Screenshot 2024-10-09 at 11 45 23
  • The padding on the top seems a bit off compared to the design. In the implementation, the top padding is less than the left padding:
Screenshot 2024-10-09 at 11 39 15

While in the design, it is about the same:
Screenshot 2024-10-09 at 11 39 18

  • Nits:
    • Asset Type => Asset type
    • Min Investment => Min. investment
    • Tranches => Tranche

Pool overview

  • The expense ratio should be the sum of all the fees in the pool. So for Anemoy LTF, the number should be 0.15%. It is now incorrectly showing as 1.20% instead.

  • In the Reports section, none of the buttons have a hover action. I think it would be good to add this.

Screenshot 2024-10-09 at 11 33 23
  • The font size of the expense ratio tooltips appears too small:
Screenshot 2024-10-09 at 11 40 44

In the design it is 12px.

  • Nits:
    • Expense Ratio => Expense ratio
    • Cashflow statement => Cash flow statement
    • Executive Summary => Executive summary

@sonam-jo
Copy link

For the Transaction history table in the overview page, two changes:

  • change Principal payment to Sale
  • more description of the actions: e.g for the highlighted section in the screenshot, it should say Sale of 912797LK1, settled into Brokerage account

Screenshot 2024-10-09 at 16 12 33

@hieronx
Copy link
Contributor

hieronx commented Oct 10, 2024

  • To add to @sonam-jo 's comment above, we should also fix the correction transactions:
Screenshot 2024-10-10 at 21 25 38

These should display as Correction ↑ of Brokerage account (for a correction up), or Correction ↓ of Brokerage account (for a correction up), and Brokerage account should be a link.

  • I would add $ prefix here too, to be consistent with the landing page:
Screenshot 2024-10-10 at 21 26 45
  • On the Reports page, can we make the bars (significantly) wider, if you have selected a longer period like monthly?
Screenshot 2024-10-10 at 21 27 17

Similar to how the 30 day view on the pool overview chart also has wider bars than the longer time views:
Screenshot 2024-10-10 at 21 27 40

@hieronx
Copy link
Contributor

hieronx commented Oct 11, 2024

One more thing I noticed in the transaction history: the cash transfer here (on the bottom of the table for Anemoy LTF) should be from another account (Transfer account I think) to the Brokerage account, not from Brokerage account to Brokerage account. I think the assetFrom rather than asset should be used for the left side here.

Screenshot 2024-10-11 at 09 46 27

@kattylucy kattylucy mentioned this issue Oct 11, 2024
1 task
@hieronx
Copy link
Contributor

hieronx commented Oct 11, 2024

One more typo: Investor Type => Investor type on the landing page, within the cards.

@hieronx
Copy link
Contributor

hieronx commented Oct 11, 2024

On the Liquidity page, I'd make these two buttons secondary/gray, like the Download buttons on the overview page.

Screenshot 2024-10-11 at 12 02 00

@hieronx
Copy link
Contributor

hieronx commented Oct 11, 2024

The Invest button should be fully right aligned, and have some more left & right padding within the button.

I'd also make the Token column a bit wider by default, so the other 3 columns are more closely spaced together on the right side, like in the design.

Design:

Screenshot 2024-10-11 at 12 02 53

Implementation:

Screenshot 2024-10-11 at 12 03 04

@sonam-jo
Copy link

sonam-jo commented Oct 11, 2024

Overview page

Cosmetic changes

  • I still see junior in the token price for single tranche. it should just say Token price
  • Shift the spacing around for the Token/Invest row such that there is more space between Token and APY and Invest is all the way to the right with a bigger box (similar to the UI)
  • Do not show Pool analysis when there isn't any (like with DYF)
  • Icons next to the Balance Sheet, CF, P&L should be in grey with more padding between the icon and text
  • Min investment range for NS3 should be $5K - $25K, not the other way round. APY should also follow same logic of lower number first.
  • Connect wallet instead of Connect

UX

  • When there is Pool analysis, the report should be linked to Pool analysis title with an underline so it's clear that it can be clicked.
  • Currently the CTA is always Invest, when it should follow the logic from the ticket:
CTA on the table depends on investor status
- If the wallet is not connected, the CTA should be "Connect" and should open the connect wallet flow. Do not open side panel. 
- If the wallet is connected, but it is not on the memberlist of the fund, then show the "Onboard" button. The onboard button should follow the onboarding flow (i.e Open up new page to Anemoy onboarding). Do not open side panel. 
- If the wallet is connected & is onboarded to the fund but has not previously invested, then show "Invest" CTA. Clicking on the CTA should open the side panel. Side panel should show the renamed "Investment position" and now include Realized and Unrealized P&L. It will also now include the APY in the Price chart. 
- If the wallet is connected & is onboarded to the fund but has previously invested, then show "Invest / Redeem" CTA. Clicking on the CTA should open the side panel to Invest.

Screenshot 2024-10-11 at 11 07 39

@sonam-jo
Copy link

Landing page

UX

  • APY on Landing page does not match APY in the Overview pages for DYF and LTF. They should be the same as Overview page.

Cosmetic

  • Font size and spacing for single tranche pools with just APY and Min. investment looks off compared to the designs
  • Lighter grey background for Closed box
  • Can't really see NS2 icon
  • Once all the short descriptions are in, check if there is still extra blank space at the bottom of each box. If so, consider reducing the size of the boxes and increase the padding between the top row and bottom row pools

@hieronx
Copy link
Contributor

hieronx commented Oct 11, 2024

  • The name here (Bank account) is now correct, but the link is still incorrect:
Screenshot 2024-10-11 at 13 42 31

@hieronx
Copy link
Contributor

hieronx commented Oct 11, 2024

The APY in the token dialog should be shown as %, not denominated in LTF:

Screenshot 2024-10-11 at 15 00 23

@hieronx
Copy link
Contributor

hieronx commented Oct 11, 2024

The right padding of the sub items is now fixed, but the right padding of the chevron of the Governance item is still too little:

Screenshot 2024-10-11 at 15 03 48

@sonam-jo
Copy link

Reports page

Cosmetic

  • Can we fix the first column for all reports such that when the user scrolls to the right, you can still see all the row headings?
  • The calendar boxes next to the dates in the chart need to be closer to the dates. Same with the dropdown next to Monthly
  • In the table, the grey lines for the rows should be lighter, in line with Figma. (Same with chart?)
  • Change the date format in the chart from 11/10/2024 to Oct 11, 2024 (to be in line with the table)
  • Boxes around Balance sheet/P&L/CF to be light grey, not black
  • Can we have a smaller box for CSV?

@sonam-jo
Copy link

Data page

Cosmetic

  • Fix the top row so when the user scrolls down, they can still see all the headers
  • Change date format in the top box from 11/10/2024 to Oct 11, 2024 to be in line with the table
  • Calendar icons to be closer to the dates
  • All the fields in the filters seem to be in Bold, that's not needed
  • Title of the first field in the grey box on the top should be Data not Report
  • When the Network and Filter by address are in the same row, they are not aligned

Screenshot 2024-10-11 at 15 47 37

@sonam-jo
Copy link

Landing page

On the top, can we replace TVL with Total Assets Financed as we have on the website today?

Screenshot 2024-10-11 at 16 20 24

Screenshot 2024-10-11 at 16 18 33

@hieronx
Copy link
Contributor

hieronx commented Oct 14, 2024

  • The range should only be shown on the pool overview page. In the card, where the APY is shown per tranche, there should be no range. In this case the Senior APY should just be 4%.
Screenshot 2024-10-14 at 09 59 30
  • If no APY is set, - should be shown:
Screenshot 2024-10-14 at 10 00 10
  • The token price for Tinlake pools should also be fixed to 6 decimals
Screenshot 2024-10-14 at 10 19 22

@kattylucy
Copy link
Collaborator Author

kattylucy commented Oct 14, 2024

Can we fix the first column for all reports such that when the user scrolls to the right, you can still see all the row headings?

This is within the table. I will try but would leave this issue for last, since we need to change the table a bit for this and we use tables a lot across the app.

Change the date format in the chart from 11/10/2024 to Oct 11, 2024 (to be in line with the table)

Unfortunately HTML date type (which is what we are currently using) only accepts the YYYY-MM-DD format. It’s a bit more complex to do but since we use our input on different places (from fabric) and we want to deploy on Wednesday. Maybe we can have this changes that require more work for after the release? I don’t want to make a big change in the component and broke something else from lack of testing.

@sonam-jo

@sonam-jo
Copy link

Yes neither is launch blocking - we can do fixing table columns and date formatting post release.

@kattylucy
Copy link
Collaborator Author

Great - I will prepare tickets for those @sonam-jo

@hieronx
Copy link
Contributor

hieronx commented Oct 14, 2024

@kattylucy a small design change to the sidebar:

  • Can you add more padding to the Centrifuge logo so the left and right padding is aligned? Looks like it needs another 8px on top.
  • Can you add rgba(145, 150, 155, 0.13) as the background color for the active menu item? Also needs margin-right: 20px; border-radius: 4px; on the anchor tag.

See sample screenshot of how it should look:

Screenshot 2024-10-14 at 16 16 44

@BrianCarter-Design
Copy link
Collaborator

Hi @kattylucy I've reviewed done a full design QA on the pages that are in dev so far. I've added a link to the Figma file where I've documented all the feedback. I've noted everything I could find, so most of it is minor and perhaps a low priority, but just thought I would add everything.
https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u?node-id=4013-2504#986168970

@sonam-jo
Copy link

Start execution order CTA is showing up on the Liquidity page for the 3 Tinlake pools, when logged in as Alice or even when not connected to the wallet. Please remove.

Screenshot 2024-10-15 at 14 00 47

@sonam-jo
Copy link

For DYF, the APY of 8.95% is incorrect. I've created to investigate this post launch, but for the time being, can we please hardcode 15% target as APY for both the landing and overview pages.

@sonam-jo
Copy link

For NS3, we seem to be having the same issue as DYF. Can we please hardcode:

Landing page
8% target for Senior
16% target for Junior

Overview page
Overview box: Target APY with 8% - 16%
Token table: 8% target for Senior, and 16% target for Junior

@hieronx
Copy link
Contributor

hieronx commented Oct 15, 2024

@kattylucy to this point: #2471 (comment) looks mostly correct now, except the background color is only implemented on hover, but should be always on for the active item (so it shows permanently for that one, not just on hover).

Also looks like the margin right is more than the margin left. Could you set the margin left to the same as the current margin right value? (this was probably my mistake!)

Screenshot 2024-10-15 at 20 20 52

Finally looks like the margin top on the landing page within the main content should still be increased.

Implementation:

Screenshot 2024-10-15 at 20 22 41

Design:

Screenshot 2024-10-15 at 20 23 47

@sonam-jo
Copy link

Landing page

  1. For the laptop view, currently we can see 4 pools. Can we enforce showing only 3 pools so the short description does not run into 3 lines (remains to 2). You can then see if we can increase the font size to 14.
Screenshot 2024-10-16 at 11 12 24 Screenshot 2024-10-16 at 11 13 02
  1. For DYF, we keep the title as APY (like the rest of the pools) but add target after the 15%, like done for NS3. Please target, no capital T

  2. For NS3, APYs need to be swapped. Senior is 8% target and Junior is 16% target

  3. For NS2, can we change Investor type to Qualified US and non-US investors and Asset type to Residential real estate (same as NS3). Also missing $ for the 5K min investment.

@sonam-jo
Copy link

Overview page

  1. For DYF, can we change the font size in the service providers box so they all fit in 1 line
Screenshot 2024-10-16 at 11 16 16
  1. For DYF, keep the title as APY but change to 15% target

  2. For NS3, APYs need to be swapped. Senior is 8% target and Junior is 16% target. Shift the white box of service providers to the centre of the text.

@sonam-jo
Copy link

sonam-jo commented Oct 16, 2024

For the Tinlake pools, when clicking on Onboard -- its taking user to the Onboarding flow when users can no longer invest in them. For these 3 closed pools, please change the CTA to Closed and disabled

@kattylucy kattylucy mentioned this issue Oct 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants