-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Feedback on new designs #2471
Comments
The only item missing from this Overview box is Expense ratio.
|
The expense ratio is there but probably for this specific pool is 0 so it does not show. For the APY, can you give me a bit more context on what do you mean? The filter is changing the APY based on if 30 days, 90 days, YTD. is this not what we want? |
Overall it looks amazing, really nice job @kattylucy ! Excited to see this go live soon. I have quite a list of QA feedback, but they are almost all very small points :) Landing page
While in the design, it is about the same:
Pool overview
In the design it is 12px.
|
For the Transaction history table in the overview page, two changes:
|
These should display as
Similar to how the 30 day view on the pool overview chart also has wider bars than the longer time views: |
One more typo: |
Overview pageCosmetic changes
UX
|
Landing pageUX
Cosmetic
|
Reports pageCosmetic
|
Data pageCosmetic
|
Can we fix the first column for all reports such that when the user scrolls to the right, you can still see all the row headings? This is within the table. I will try but would leave this issue for last, since we need to change the table a bit for this and we use tables a lot across the app. Change the date format in the chart from 11/10/2024 to Oct 11, 2024 (to be in line with the table) Unfortunately HTML date type (which is what we are currently using) only accepts the YYYY-MM-DD format. It’s a bit more complex to do but since we use our input on different places (from fabric) and we want to deploy on Wednesday. Maybe we can have this changes that require more work for after the release? I don’t want to make a big change in the component and broke something else from lack of testing. |
Yes neither is launch blocking - we can do fixing table columns and date formatting post release. |
Great - I will prepare tickets for those @sonam-jo |
@kattylucy a small design change to the sidebar:
See sample screenshot of how it should look: |
Hi @kattylucy I've reviewed done a full design QA on the pages that are in dev so far. I've added a link to the Figma file where I've documented all the feedback. I've noted everything I could find, so most of it is minor and perhaps a low priority, but just thought I would add everything. |
For DYF, the APY of 8.95% is incorrect. I've created to investigate this post launch, but for the time being, can we please hardcode |
For NS3, we seem to be having the same issue as DYF. Can we please hardcode: Landing page Overview page |
@kattylucy to this point: #2471 (comment) looks mostly correct now, except the background color is only implemented on hover, but should be always on for the active item (so it shows permanently for that one, not just on hover). Also looks like the margin right is more than the margin left. Could you set the margin left to the same as the current margin right value? (this was probably my mistake!) Finally looks like the margin top on the landing page within the main content should still be increased. Implementation: Design: |
For the Tinlake pools, when clicking on Onboard -- its taking user to the Onboarding flow when users can no longer invest in them. For these 3 closed pools, please change the CTA to |
I created this ticket for product to use as the placeholder and add the feedback during testing.
What are we testing?
Landing page (/pools)
Pool overview page (/pools/:poolId)
Reports page (pools/reporting/)
Data page (pools/data)
Creating a pool and updating a pool in the configuration tab
It relates to all the work in the following tickets
#2392
#2391
#2390
#2427
#2459
#2460
The text was updated successfully, but these errors were encountered: