Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Option to watch config for changes + reload as needed #502

Open
cweagans opened this issue Jan 20, 2022 · 3 comments
Open

[feature] Option to watch config for changes + reload as needed #502

cweagans opened this issue Jan 20, 2022 · 3 comments

Comments

@cweagans
Copy link

Is your feature request related to a problem? Please describe.

When I'm building stuff locally with Centrifugo, it would be helpful to be able to make config changes in the json file and have centrifugo automatically reload/restart so that those config options take effect immediately.

Describe the solution you'd like.

What would the feature look like? How would it work? How would it change the API?

It would be great if it was as simple as centrifugo -c /path/to/config --watch or something like that.

@FZambia
Copy link
Member

FZambia commented Jan 20, 2022

Hello, you can simply use nodemon:

npm install -g nodemon
nodemon --watch config.json --exec ./centrifugo --signal SIGTERM

@cweagans
Copy link
Author

I know I can use external utils to do that. I'm running in a container and don't really want to load it up with a bunch of extra stuff.

@FZambia
Copy link
Member

FZambia commented Jan 22, 2022

This will require proper shutdown of all components in Centrifugo. Some components already can stop gracefully, some can not since it was not really required. While having graceful stop for everything is nice to have – it's not really a quick improvement and I can't give any ETAs for this. So for now the only recommendation – use external tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants