Skip to content

Commit 8547567

Browse files
authored
some cleanups in proxy code (#944)
1 parent b92f578 commit 8547567

11 files changed

+8
-56
lines changed

internal/proxy/connect_grpc.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,5 +55,5 @@ func (p *GRPCConnectProxy) UseBase64() bool {
5555
func (p *GRPCConnectProxy) ProxyConnect(ctx context.Context, req *proxyproto.ConnectRequest) (*proxyproto.ConnectResponse, error) {
5656
ctx, cancel := context.WithTimeout(ctx, p.config.Timeout.ToDuration())
5757
defer cancel()
58-
return p.client.Connect(grpcRequestContext(ctx, p.config), req, grpc.ForceCodec(grpcCodec))
58+
return p.client.Connect(grpcRequestContext(ctx, p.config), req)
5959
}

internal/proxy/grpc.go

-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import (
99

1010
"github.com/centrifugal/centrifugo/v6/internal/clientcontext"
1111
"github.com/centrifugal/centrifugo/v6/internal/middleware"
12-
"github.com/centrifugal/centrifugo/v6/internal/proxyproto"
1312

1413
"google.golang.org/grpc"
1514
"google.golang.org/grpc/credentials"
@@ -18,8 +17,6 @@ import (
1817
"google.golang.org/grpc/metadata"
1918
)
2019

21-
var grpcCodec = proxyproto.Codec{}
22-
2320
type rpcCredentials struct {
2421
key string
2522
value string

internal/proxy/publish_grpc.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func NewGRPCPublishProxy(name string, p Config) (*GRPCPublishProxy, error) {
4141
func (p *GRPCPublishProxy) ProxyPublish(ctx context.Context, req *proxyproto.PublishRequest) (*proxyproto.PublishResponse, error) {
4242
ctx, cancel := context.WithTimeout(ctx, p.config.Timeout.ToDuration())
4343
defer cancel()
44-
return p.client.Publish(grpcRequestContext(ctx, p.config), req, grpc.ForceCodec(grpcCodec))
44+
return p.client.Publish(grpcRequestContext(ctx, p.config), req)
4545
}
4646

4747
// Protocol ...

internal/proxy/refresh_grpc.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func NewGRPCRefreshProxy(name string, p Config) (*GRPCRefreshProxy, error) {
4141
func (p *GRPCRefreshProxy) ProxyRefresh(ctx context.Context, req *proxyproto.RefreshRequest) (*proxyproto.RefreshResponse, error) {
4242
ctx, cancel := context.WithTimeout(ctx, p.config.Timeout.ToDuration())
4343
defer cancel()
44-
return p.client.Refresh(grpcRequestContext(ctx, p.config), req, grpc.ForceCodec(grpcCodec))
44+
return p.client.Refresh(grpcRequestContext(ctx, p.config), req)
4545
}
4646

4747
// Name ...

internal/proxy/refresh_http.go

-7
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,6 @@ import (
77
"github.com/centrifugal/centrifugo/v6/internal/proxyproto"
88
)
99

10-
// RefreshRequestHTTP ...
11-
type RefreshRequestHTTP struct {
12-
baseRequestHTTP
13-
14-
UserID string `json:"user"`
15-
}
16-
1710
// HTTPRefreshProxy ...
1811
type HTTPRefreshProxy struct {
1912
config Config

internal/proxy/rpc_grpc.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func NewGRPCRPCProxy(name string, p Config) (*GRPCRPCProxy, error) {
4141
func (p *GRPCRPCProxy) ProxyRPC(ctx context.Context, req *proxyproto.RPCRequest) (*proxyproto.RPCResponse, error) {
4242
ctx, cancel := context.WithTimeout(ctx, p.config.Timeout.ToDuration())
4343
defer cancel()
44-
return p.client.RPC(grpcRequestContext(ctx, p.config), req, grpc.ForceCodec(grpcCodec))
44+
return p.client.RPC(grpcRequestContext(ctx, p.config), req)
4545
}
4646

4747
// Protocol ...

internal/proxy/sub_refresh_grpc.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func NewGRPCSubRefreshProxy(name string, p Config) (*GRPCSubRefreshProxy, error)
4141
func (p *GRPCSubRefreshProxy) ProxySubRefresh(ctx context.Context, req *proxyproto.SubRefreshRequest) (*proxyproto.SubRefreshResponse, error) {
4242
ctx, cancel := context.WithTimeout(ctx, p.config.Timeout.ToDuration())
4343
defer cancel()
44-
return p.client.SubRefresh(grpcRequestContext(ctx, p.config), req, grpc.ForceCodec(grpcCodec))
44+
return p.client.SubRefresh(grpcRequestContext(ctx, p.config), req)
4545
}
4646

4747
// Protocol ...

internal/proxy/sub_refresh_http.go

-8
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,6 @@ import (
77
"github.com/centrifugal/centrifugo/v6/internal/proxyproto"
88
)
99

10-
// SubRefreshRequestHTTP ...
11-
type SubRefreshRequestHTTP struct {
12-
baseRequestHTTP
13-
14-
UserID string `json:"user"`
15-
Channel string `json:"channel"`
16-
}
17-
1810
// HTTPSubRefreshProxy ...
1911
type HTTPSubRefreshProxy struct {
2012
config Config

internal/proxy/subscribe_grpc.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func NewGRPCSubscribeProxy(name string, p Config) (*GRPCSubscribeProxy, error) {
4141
func (p *GRPCSubscribeProxy) ProxySubscribe(ctx context.Context, req *proxyproto.SubscribeRequest) (*proxyproto.SubscribeResponse, error) {
4242
ctx, cancel := context.WithTimeout(ctx, p.config.Timeout.ToDuration())
4343
defer cancel()
44-
return p.client.Subscribe(grpcRequestContext(ctx, p.config), req, grpc.ForceCodec(grpcCodec))
44+
return p.client.Subscribe(grpcRequestContext(ctx, p.config), req)
4545
}
4646

4747
// Protocol ...

internal/proxy/subscribe_stream_grpc.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ func NewSubscribeStreamProxy(name string, p Config) (*SubscribeStreamProxy, erro
3636

3737
// SubscribeUnidirectional ...
3838
func (p *SubscribeStreamProxy) SubscribeUnidirectional(ctx context.Context, req *proxyproto.SubscribeRequest) (proxyproto.CentrifugoProxy_SubscribeUnidirectionalClient, error) {
39-
return p.client.SubscribeUnidirectional(grpcRequestContext(ctx, p.config), req, grpc.ForceCodec(grpcCodec))
39+
return p.client.SubscribeUnidirectional(grpcRequestContext(ctx, p.config), req)
4040
}
4141

4242
// SubscribeBidirectional ...
4343
func (p *SubscribeStreamProxy) SubscribeBidirectional(ctx context.Context) (proxyproto.CentrifugoProxy_SubscribeBidirectionalClient, error) {
44-
return p.client.SubscribeBidirectional(grpcRequestContext(ctx, p.config), grpc.ForceCodec(grpcCodec))
44+
return p.client.SubscribeBidirectional(grpcRequestContext(ctx, p.config))
4545
}

internal/proxyproto/codec.go

-30
This file was deleted.

0 commit comments

Comments
 (0)