Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis reversed history fix when meta does not exist #328

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Oct 30, 2023

Fixes centrifugal/centrifugo#732

I.e. fixes this error:

Lua redis lib command arguments must be strings or integers script: c9735f3dd5ac99ee9c4e59d9f5ac297b036f9443, on @user_script:25.

Also contains Redis broker LUA scripts refactoring like we did for presence recently.

Also, save one Redis call in history get scripts by using hmget instead of two hget calls.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #328 (2462188) into master (816d5db) will decrease coverage by 0.14%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   83.85%   83.72%   -0.14%     
==========================================
  Files          38       38              
  Lines        7472     7472              
==========================================
- Hits         6266     6256      -10     
- Misses        893      902       +9     
- Partials      313      314       +1     
Files Coverage Δ
broker_redis.go 73.05% <ø> (-0.70%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FZambia FZambia merged commit 91778bc into master Oct 30, 2023
10 checks passed
@FZambia FZambia deleted the broker_redis_history_fix branch October 30, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Redis error: Lua redis lib command arguments must be strings or integers
1 participant