Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulation logging tweaks #326

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Emulation logging tweaks #326

merged 1 commit into from
Oct 22, 2023

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Oct 21, 2023

Some changes in emulation handler logging which seem to better reflect what's happening.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #326 (15d9322) into master (f88d21a) will increase coverage by 0.12%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   83.97%   84.10%   +0.12%     
==========================================
  Files          38       38              
  Lines        7453     7454       +1     
==========================================
+ Hits         6259     6269      +10     
+ Misses        891      883       -8     
+ Partials      303      302       -1     
Files Coverage Δ
handler_http_stream.go 65.35% <100.00%> (ø)
handler_sse.go 71.72% <100.00%> (+0.68%) ⬆️
emulation.go 69.38% <25.00%> (+0.31%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FZambia FZambia merged commit 94a03a1 into master Oct 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant