Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server debug flags should be explicitly set #13

Open
stolsvik opened this issue Dec 20, 2022 · 0 comments
Open

Server debug flags should be explicitly set #13

stolsvik opened this issue Dec 20, 2022 · 0 comments

Comments

@stolsvik
Copy link
Contributor

Currently, the server uses whatever was last sent over (with a default of zero on both client and server). This is pretty annoying if you want debug on a particular request: After this request, the server will use this for any server initiated messages (server-to-client send and request). Thus, you will always have to basically send a dummy "reset" message afterwards. This effectively makes the ability to set debug options in the config object meaningless..

It would have been better if this was more explicit. One thought was to just use whatever was set on MatsSocket.debug at startup to be the server-to-client debug flags. However, this makes it impossible to set any other "in runtime", i.e. if you have an app, and want to turn on the server-side debug flags (using some admin config screen), you'd have to restart the MatsSocket.

It would be better if this was an explicit setting, preferably so that when setting it on the client, it was immediately sent over.

I am thinking a property with setter action. And renaming "AUTH"-type messages to "CONF" or something, so that one can use it for multiple such client-server and server-client comms which are only for the messaging layer, not user comms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant