Fix triangle.c pointer cast for x64 systems #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppizarror
changed the title
|
For OSX compatibility, on line 649 of triangle.c the following should be added: [LINE 649]/* Random number seed is not constant, but I've made it global anyway. */
/* Fix for MacOS*/
#ifndef __int64
#ifdef __APPLE__
typedef long long __int64;
#else
#error Must define __int64 for your platform
#endif
#endif
__int64 randomseed; /* Current random number seed. */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes triangle.c library, which assumes that
sizeof(long)equals 8, and usesunsigned longas the type of pointer. Butsizeof(long)equals 4 when compiling in VS/mingw/x64, so unsigned long cannot be the type of the pointer in x64.Now, I successfully compiled the project, and ran the tests!
Also, PR #4 should be merged as well.
Greetings,
Pablo