-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] In-app debug log collector throws NoSuchFileException
#1870
Comments
It isn't a crash, just an error log. Note that the process ID ( Think we should downgrade those logs to warning level and/or not print the entire stacktrace. |
NoSuchFileException
Thanks, that's a good catch! I have changed the title accordingly.
Wouldn't it be more appropriate to implement a check so that this Slightly offtopic: Pressing the button "Bug report" in the about sectioon of the app always says "No crash report found", even after background app crashes. Maybe this is related to this exception? Not sure. |
Agree. Treating exceptions as control flow is not only inefficient but also likely to confuse unassuming folks looking at the code or logs.
We relied on Android APIs on versions below v055n. Going forward (v055o onwards), it'll be our own homegrown crash reporter. Ideally, we'd have used something like Sentry or Firebase Crashlytics, but those are too privacy intrusive for some and hence we thought it was prudent to spend time rolling out whatever we could muster outside of those libraries (as our main concern is only the crashes of our network engine, which is written in Go, and not the UI, which is written in Kotlin). |
Understood. It's a good choice not to use potentially privacy invasive non-FOSS crash reporting libraries. From a quick glance I can understand that this homegrown crash reporter is already implemented for future app versions, correct? Otherwise I believe other FOSS apps have this issue as well and some have probably solved it. Maybe some good inspiration can be taken from other well-made FOSS apps. |
Bug description
Sometimesthe RethinkDNS background process crashes due to the app not able to access its collected log file I believe. This leaves the device without any block lists or firewall, which is rather bad for obvious leakage reasons.
The error is:
Logs
Please see the following log:
Logcat
Additional info
The text was updated successfully, but these errors were encountered: