Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybinds are subject to incorrect autorepeat when seeking #978

Open
0n-s opened this issue Sep 12, 2024 · 0 comments
Open

Keybinds are subject to incorrect autorepeat when seeking #978

0n-s opened this issue Sep 12, 2024 · 0 comments

Comments

@0n-s
Copy link

0n-s commented Sep 12, 2024

Overview Description:
Oh boy, so this is a fun one.

"autorepeat" here is keyboard autorepeat, i.e. when you hold down a key & it just types it over & over.

When e.g. seeking later into the video with e.g. →, while Celluloid is seeking, it doesn't seem to realize that I've actually released the key during that process. Due to my very speedy autorepeat settings, this causes seeks to be arbitrarily multiplied depending on how much time it takes to actually do the seek. IOW, it thinks I've entered → more than once, as if I had been holding it down the whole time during that one seek. At least, this is what I believe it's doing; it's practically not there with default autorepeat settings (these are the same for nearly every desktop & WM out there).

(as an aside: is Celluloid's input processing on a different thread? If not, that's probably the culprit)

Steps to Reproduce:
Set your keyboard autorepeat delay & interval very low & high, respectively. This'll make it easier to hit the problem. Then throttle Celluloid's CPU usage, to make seeks slower.

  1. Seek in a video 5 seconds with the → or ← key a bunch of times.

Actual Results:
The seek will randomly go much further into the video than it did before, in a manner that cannot be explained by mpv's seeks snapping to keyframe boundaries.

Expected Results:
The seek should only trigger once.

Version: 0.27

Additional Information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant