Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementation of test-case #002: DA Nodes sync large blocks #66

Merged
merged 6 commits into from
Sep 15, 2022

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Sep 6, 2022

  • compositions are ordered by test-case -> data-sets
  • adapt manifest.toml to accept roles

Should be reviewed after #59 is merged
Close #60

@Bidon15 Bidon15 self-assigned this Sep 6, 2022
@Bidon15 Bidon15 changed the title [Draft] Tc 002 da sync feat: implementation of test-case #002: DA Nodes sync large blocks Sep 9, 2022
@Bidon15 Bidon15 marked this pull request as ready for review September 9, 2022 08:40
@Bidon15 Bidon15 requested a review from vgonkivs September 9, 2022 12:20
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck. Only some personal preferences small nits

Renamed sync_nodes to appropriate naming
Rework id assignments from group sequences, not global ones anymore
remove obsolete snippets
adapt compositions for block-height
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+

@Bidon15 Bidon15 merged commit 1c19126 into celestiaorg:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

testground/tests: implement TC-002
4 participants